Re: [PATCH] target-arm: add support for v8 AES instructions

2013-11-06 Thread Ard Biesheuvel
On 6 November 2013 14:21, Peter Maydell wrote: > On 6 November 2013 13:05, Ard Biesheuvel wrote: [...] >> Thanks, I was wondering about that. Should there be another check? Not >> all v8 cores will implement these extensions, so we might also want to >> emulate one that doesn't, I suppose? > >

Re: [PATCH] target-arm: add support for v8 AES instructions

2013-11-06 Thread Peter Maydell
On 6 November 2013 13:05, Ard Biesheuvel wrote: > Well, to be honest, my primary motivation for posting it to the list > was so I could refer to it from the JIRA issue you told me about > yesterday, but I would be happy to fix these minor issues and do a > proper submission as well. However, consi

Re: [PATCH] target-arm: add support for v8 AES instructions

2013-11-06 Thread Ard Biesheuvel
On 6 November 2013 13:51, Peter Maydell wrote: > On 6 November 2013 11:22, Ard Biesheuvel wrote: >> This adds support for the AESE/AESD/AESMC/AESIMC instructions that >> are available on some v8 implementations of Aarch32. > > Thanks for this patch. Please could you send QEMU patches to > qemu-de

Re: [PATCH] target-arm: add support for v8 AES instructions

2013-11-06 Thread Peter Maydell
On 6 November 2013 11:22, Ard Biesheuvel wrote: > This adds support for the AESE/AESD/AESMC/AESIMC instructions that > are available on some v8 implementations of Aarch32. Thanks for this patch. Please could you send QEMU patches to qemu-de...@nongnu.org? (we do all our work on upstream qemu and

[PATCH] target-arm: add support for v8 AES instructions

2013-11-06 Thread Ard Biesheuvel
This adds support for the AESE/AESD/AESMC/AESIMC instructions that are available on some v8 implementations of Aarch32. Signed-off-by: Ard Biesheuvel --- target-arm/Makefile.objs | 1 + target-arm/crypto_helper.c | 196 + target-arm/helper.h