Dear Wolfgang Denk,
On 1 September 2011 14:51, Wolfgang Denk wrote:
> Dear Minkyu Kang,
>
> In message
> you
> wrote:
>>
>> > I know these were like this before, but those numbers are awfully
>> > magical. You should really define constants for them.
>>
>> We decided to use comments instead of
On Tue, Aug 30, 2011 at 5:55 AM, Chander Kashyap
wrote:
> mmc data transfer width is set as following:
> WIDE8[5]:
> 0 = Depend on WIDE4
> 1 = 8-bit mode
> WIDE4[1]:
> 1 = 4-bit mode
> 0 = 1-bit mode
>
> In case of 4-bit mode reset 8-bit mode and
> in case of 1-bit mode reset 8-bit mode and 4-bit
Dear Minkyu Kang,
In message
you wrote:
>
> > I know these were like this before, but those numbers are awfully
> > magical. You should really define constants for them.
>
> We decided to use comments instead of defines.
And now we ask you to fix this, because we don;t want such magic
constan
Dear Andy Fleming,
On 1 September 2011 10:23, Andy Fleming wrote:
> On Tue, Aug 30, 2011 at 5:55 AM, Chander Kashyap
> wrote:
>> mmc data transfer width is set as following:
>> WIDE8[5]:
>> 0 = Depend on WIDE4
>> 1 = 8-bit mode
>> WIDE4[1]:
>> 1 = 4-bit mode
>> 0 = 1-bit mode
>>
>> In case of 4-
Hi Chander.
this patch is correct.
Acked-by: Jaehoon Chung
Chander Kashyap wrote:
> mmc data transfer width is set as following:
> WIDE8[5]:
> 0 = Depend on WIDE4
> 1 = 8-bit mode
> WIDE4[1]:
> 1 = 4-bit mode
> 0 = 1-bit mode
>
> In case of 4-bit mode reset 8-bit mode and
> in case of 1-bit
mmc data transfer width is set as following:
WIDE8[5]:
0 = Depend on WIDE4
1 = 8-bit mode
WIDE4[1]:
1 = 4-bit mode
0 = 1-bit mode
In case of 4-bit mode reset 8-bit mode and
in case of 1-bit mode reset 8-bit mode and 4-bit mode
Signed-off-by: Chander Kashyap
---
drivers/mmc/s5p_mmc.c | 10
