Re: [PATCH] bootwrapper: Use local definition of string.h

2012-09-06 Thread Peter Maydell
On 4 September 2012 15:57, Jon Medhurst (Tixy) wrote: > The semihosting and FDT code makes use of libc style string > functions implemented in our string.c, however it relies of the system > providing the string.h header file. > > This causes problems on toolchains that don't provide these headers

Re: [PATCH] bootwrapper: Use local definition of string.h

2012-09-04 Thread Dave Martin
On Tue, Sep 04, 2012 at 04:26:32PM +0100, Jon Medhurst (Tixy) wrote: > On Tue, 2012-09-04 at 16:10 +0100, Peter Maydell wrote: > > On 4 September 2012 15:57, Jon Medhurst (Tixy) wrote: > > > diff --git a/string.h b/string.h > > > new file mode 100644 > > > index 000..f1aebdf > > > --- /dev/nul

Re: [PATCH] bootwrapper: Use local definition of string.h

2012-09-04 Thread Jon Medhurst (Tixy)
On Tue, 2012-09-04 at 16:10 +0100, Peter Maydell wrote: > On 4 September 2012 15:57, Jon Medhurst (Tixy) wrote: > > diff --git a/string.h b/string.h > > new file mode 100644 > > index 000..f1aebdf > > --- /dev/null > > +++ b/string.h > > @@ -0,0 +1,16 @@ > > +#ifndef STRING_H > > +#define STRI

Re: [PATCH] bootwrapper: Use local definition of string.h

2012-09-04 Thread Peter Maydell
On 4 September 2012 16:10, Peter Maydell wrote: > I guess to be fully consistent we should provide our own > stddef.h and stdint.h, but if it's not causing problems it's > not worth the effort. Actually, I'm wrong there. We're using gcc's -ffreestanding so it's being a conforming freestanding imp

Re: [PATCH] bootwrapper: Use local definition of string.h

2012-09-04 Thread Peter Maydell
On 4 September 2012 15:57, Jon Medhurst (Tixy) wrote: Thanks for this patch; looks pretty good. > The semihosting and FDT code makes use of libc style string > functions implemented in our string.c, however it relies of the system "relies on". (I can fix this when I commit the patch.) > provid

[PATCH] bootwrapper: Use local definition of string.h

2012-09-04 Thread Jon Medhurst (Tixy)
The semihosting and FDT code makes use of libc style string functions implemented in our string.c, however it relies of the system providing the string.h header file. This causes problems on toolchains that don't provide these headers, like Android toolchains, and it also means that we include dec