:robdcl...@gmail.com] On Behalf Of Rob
> >> Clark
> >> Sent: Thursday, September 08, 2011 3:44 AM
> >> To: Inki Dae
> >> Cc: linaro-dev@lists.linaro.org; dri-de...@lists.freedesktop.org
> >> Subject: Re: [PATCH] RFC: omapdrm DRM/KMS driver for
ber 08, 2011 3:44 AM
>> To: Inki Dae
>> Cc: linaro-dev@lists.linaro.org; dri-de...@lists.freedesktop.org
>> Subject: Re: [PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms
>>
>> On Wed, Sep 7, 2011 at 1:00 AM, Inki Dae wrote:
>> &
linaro.org; dri-de...@lists.freedesktop.org
> Subject: Re: [PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms
>
> On Wed, Sep 7, 2011 at 1:00 AM, Inki Dae wrote:
> > Hello, Rob.
> >
> [snip]
> >> >> +static void page_flip_cb(void *arg)
> >> >> +{
> &g
On Wed, Sep 7, 2011 at 1:00 AM, Inki Dae wrote:
> Hello, Rob.
>
[snip]
>> >> +static void page_flip_cb(void *arg)
>> >> +{
>> >> + struct drm_crtc *crtc = arg;
>> >> + struct drm_device *dev = crtc->dev;
>> >> + struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
>> >> + struct drm_p
c: dri-de...@lists.freedesktop.org; linaro-dev@lists.linaro.org;
> > Valkeinen, Tomi
> > Subject: Re: [PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms
> >
> > On Mon, Sep 5, 2011 at 4:58 AM, Inki Dae wrote:
> > > How about moving codes above into interrup
Subject: Re: [PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms
>
> On Mon, Sep 5, 2011 at 4:58 AM, Inki Dae wrote:
> > Hello, Rob.
> > I didn't look into any comments from other develops yet , so my comments
> > could be duplicated with other ones. below
On Mon, Sep 5, 2011 at 4:58 AM, Inki Dae wrote:
> Hello, Rob.
> I didn't look into any comments from other develops yet , so my comments
> could be duplicated with other ones. below is my opinions and I commented
> your codes also.
>
> We can discuss crtc, encoder and connector. in x86 world, my u
On Sun, Sep 04, 2011 at 11:29:43AM -0500, Rob Clark wrote:
> > Above set of get/put functions seem to do very little. Drop them for the
> > first round?
>
> The intention is to do attach/detach_pages here.. and in case of
> get/put_paddr do remapping into TILER if the buffer isn't physically
> con
On Sun, Sep 4, 2011 at 2:49 PM, Daniel Vetter wrote:
> On Sun, Sep 04, 2011 at 11:29:43AM -0500, Rob Clark wrote:
>> > Above set of get/put functions seem to do very little. Drop them for the
>> > first round?
>>
>> The intention is to do attach/detach_pages here.. and in case of
>> get/put_paddr
On Sat, Sep 3, 2011 at 1:53 PM, Daniel Vetter wrote:
> Hi Rob,
>
> I've taken a look at your driver, some comments inline. Can't really
> comment much on the kms side because of lack of expertise in that area.
>
> I think most can be trivially addressed by dropping the plugin layer ;-)
>
> Cheers,
Hi Rob,
I've taken a look at your driver, some comments inline. Can't really
comment much on the kms side because of lack of expertise in that area.
I think most can be trivially addressed by dropping the plugin layer ;-)
Cheers, Daniel
On Fri, Sep 02, 2011 at 03:07:27PM -0500, Rob Clark wrote:
On Sat, Sep 3, 2011 at 1:57 AM, Dave Airlie wrote:
>>
>> A simple "plugin" mechanism is provided to allow integration with
>> external kernel modules (*cough* PVR), but also to keep the code more
>> modular as support is added for various other accelerator blocks that
>> exist in various different
>
> A simple "plugin" mechanism is provided to allow integration with
> external kernel modules (*cough* PVR), but also to keep the code more
> modular as support is added for various other accelerator blocks that
> exist in various different OMAP variants. (2D accel, video encode/
> decode, etc.)
13 matches
Mail list logo
