Re: [PATCH] CPUFREQ : calculate delay after dbs_check_cpu

2011-02-21 Thread Vincent Guittot
Hi Amit, Thanks for this input about performance improvement. For the powersave_bias mode, it's normal that you have some performances improvement because we run freq_lo_jiffies in low freq and freq_high_jiffies in high freq with (freq_lo_jiffies + freq_high_jiffies) = sample_rate whereas the du

Re: [PATCH] CPUFREQ : calculate delay after dbs_check_cpu

2011-02-21 Thread Amit Kachhap
Hi Vincent, I checked this patch and I can see some performance improvement in my arm platform also. So in your patch there are 2 changes. First one is for calculating delay after rate_mult is set, this can be tested with cpufreq-bench tool. For the second part which requires enabling power save b

Re: [PATCH] CPUFREQ : calculate delay after dbs_check_cpu

2011-02-15 Thread Vincent Guittot
Hi, The ondemand delay value is calculated before calling dbs_check_cpu which can lead to a delay value of sampling_rate*sampling_down_factor but a frequency set to the lowest value. The main result is a slow responsiveness during this period. This patch moves the calculation of delay after the ca