Re: [PATCH][ ARM cpu hotplug 1/2 ] extract common code for arm cpu hotplug

2010-12-02 Thread Russell King - ARM Linux
On Tue, Nov 30, 2010 at 10:24:11AM -0600, Rob Herring wrote: > On 11/30/2010 05:03 AM, Russell King - ARM Linux wrote: >> On Tue, Nov 30, 2010 at 04:17:32PM +0530, Amit Kucheria wrote: >>> Since the main aim here is to consolidate as much code here as >>> possible while still allowing platforms to

Re: [PATCH][ ARM cpu hotplug 1/2 ] extract common code for arm cpu hotplug

2010-11-30 Thread Rob Herring
On 11/30/2010 05:03 AM, Russell King - ARM Linux wrote: On Tue, Nov 30, 2010 at 04:17:32PM +0530, Amit Kucheria wrote: Since the main aim here is to consolidate as much code here as possible while still allowing platforms to override the defaults, would you have an objection to the introduction

RE: [PATCH][ ARM cpu hotplug 1/2 ] extract common code for arm cpu hotplug

2010-11-30 Thread Will Deacon
Russell, > On Tue, Nov 30, 2010 at 11:03:31AM +, Russell King - ARM Linux wrote: > > I see no point to what is being proposed in this thread. It's _soo_ > > little code that the platforms have to implement that it really is > > not worth the effort. [...] > Note also that most implementatio

Re: [PATCH][ ARM cpu hotplug 1/2 ] extract common code for arm cpu hotplug

2010-11-30 Thread Russell King - ARM Linux
On Tue, Nov 30, 2010 at 04:17:32PM +0530, Amit Kucheria wrote: > Since the main aim here is to consolidate as much code here as > possible while still allowing platforms to override the defaults, > would you have an objection to the introduction of a struct smp_ops > that'll allow a platform to ove

Re: [PATCH][ ARM cpu hotplug 1/2 ] extract common code for arm cpu hotplug

2010-11-30 Thread Russell King - ARM Linux
On Tue, Nov 30, 2010 at 11:03:31AM +, Russell King - ARM Linux wrote: > I see no point to what is being proposed in this thread. It's _soo_ > little code that the platforms have to implement that it really is > not worth the effort. > > How do you know whether separating out the cache flushes

Re: [PATCH][ ARM cpu hotplug 1/2 ] extract common code for arm cpu hotplug

2010-11-30 Thread Amit Kucheria
On Tue, Nov 30, 2010 at 12:54 AM, Russell King - ARM Linux wrote: > > On Mon, Nov 29, 2010 at 06:27:02PM +0100, Vincent Guittot wrote: > > The goal of this patch is to remove as much duplicated code as > > possible in each platform hotplug file. I have also tried to keep in > > mind that current p

Re: [PATCH][ ARM cpu hotplug 1/2 ] extract common code for arm cpu hotplug

2010-11-29 Thread Russell King - ARM Linux
On Mon, Nov 29, 2010 at 06:27:02PM +0100, Vincent Guittot wrote: > The goal of this patch is to remove as much duplicated code as > possible in each platform hotplug file. I have also tried to keep in > mind that current platform upstreamed code make nearly no power > management in their current im

Re: [PATCH][ ARM cpu hotplug 1/2 ] extract common code for arm cpu hotplug

2010-11-29 Thread Vincent Guittot
The goal of this patch is to remove as much duplicated code as possible in each platform hotplug file. I have also tried to keep in mind that current platform upstreamed code make nearly no power management in their current implementation. I have added a new interface and a new file in order to -K

[PATCH][ ARM cpu hotplug 1/2 ] extract common code for arm cpu hotplug

2010-11-29 Thread Vincent Guittot
This patch extracts the common code of the cpu hotplug feature across arm platforms. The goal is to only keep the specific stuff of the platform in the sub-architecture. I have created a hotplug.c file in the arm/common directory after studying the cpu hotplug code of omap2, realview, s5pv310, ux5