Re: [PATCH 1/4] davinci: cpuidle - use global variable for ddr2 flag

2013-02-04 Thread Sekhar Nori
ore elaborate setup so I left that out. Target residency of state1 seems high and it is entered very infrequently. But that's not something introduced by this series. So for all the patches, you can add: Acked-by: Sekhar Nori Thanks, Sekhar ___ li

Re: [PATCH 0/4] davinci: cpuidle - some cleanups

2013-02-03 Thread Sekhar Nori
On 2/3/2013 5:52 PM, Daniel Lezcano wrote: > On 02/03/2013 12:54 PM, Sekhar Nori wrote: >> On 2/2/2013 12:19 AM, Len Brown wrote: >>> On 02/01/2013 08:48 AM, Daniel Lezcano wrote: >>>> This patchset does some cleanup. It could have been folded in a single >>>

Re: [PATCH 0/4] davinci: cpuidle - some cleanups

2013-02-03 Thread Sekhar Nori
On 2/2/2013 12:19 AM, Len Brown wrote: > On 02/01/2013 08:48 AM, Daniel Lezcano wrote: >> This patchset does some cleanup. It could have been folded in a single >> patch but the review would have been less clean than splitting it into >> small and trivial patches. >> >> The main purpose of this pat

Re: [PATCH][v2] ARM: davinci: cpuidle - remove ops

2012-05-23 Thread Sekhar Nori
On 5/23/2012 12:10 AM, Daniel Lezcano wrote: > On 05/22/2012 07:58 PM, Sekhar Nori wrote: >> Hi Daniel, >> >> On 5/21/2012 3:37 AM, Daniel Lezcano wrote: >>> This patch removes the ops usage because we have the index >>> passed as parameter to the idle fun

Re: [PATCH][v2] ARM: davinci: cpuidle - remove ops

2012-05-22 Thread Sekhar Nori
Hi Daniel, On 5/21/2012 3:37 AM, Daniel Lezcano wrote: > This patch removes the ops usage because we have the index > passed as parameter to the idle function and we can determine > if we do WFI or memory retention. > > The benefit of this cleanup is the removal of: > * the ops > * the statedat

Re: [PATCH 2/2] ARM: DAVINCI: cpuidle - remove ops

2012-05-20 Thread Sekhar Nori
Hi Daniel, On 5/10/2012 2:14 PM, Daniel Lezcano wrote: > This patch removes the ops usage because we have the index > passed as parameter to the idle function and we can determine > if we do WFI or memory retention. > > The benefit of this cleanup is the removal of: > * the ops > * the statedat

Re: [PATCH 1/2] ARM: DAVINCI: cpuidle - remove useless state count initialization

2012-05-20 Thread Sekhar Nori
Hi Daniel, On 5/10/2012 2:14 PM, Daniel Lezcano wrote: > The state count is initialized in the driver structure, the cpuidle > core uses it to initialize the device state count. > > Signed-off-by: Daniel Lezcano Looks good to me. Will queue for v3.6 Nit: In future, please use davinci in small