[PATCH powerdebug] Check null pointer before dereferencing

2014-06-25 Thread Salman Ahmed
= display_get_row_data(GPIO); - struct gpio_info *gpio = t->private; + if (!t) + return -1; - if (!t || !gpio) + struct gpio_info *gpio = t->private; + if (!gpio) return -1; switch (keyvalue) { -- Thanks, Salman

Re: Idlestat output question

2014-06-20 Thread Salman Ahmed
I tried 10 times running 15 seconds and out of that 3 times I got output without any P-state information.   -- Thanks, Salman Ahmed On Friday, 20 June 2014, 16:49, Amit Kucheria wrote: On Fri, Jun 20, 2014 at 4:01 PM, Salman Ahmed wrote: > Hello Amit, > > Actually, I ran it on

Re: Idlestat output question

2014-06-20 Thread Salman Ahmed
ce it just parses trace file. Is it possible there is any bug in kernel tracing code? --  Best Regards Salman Ahmed On Friday, 20 June 2014, 11:26, Salman Ahmed wrote: I am running it on Intel x86 platform and the output of 'cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_available_frequ

Re: Idlestat output question

2014-06-19 Thread Salman Ahmed
ri, Jun 20, 2014 at 9:47 AM, Salman Ahmed wrote: > Hello Amit, > > I have pulled changes and run with your suggested following command > sudo ./idlestat --trace -t 5 -f /tmp/myoutput -- top > > But still it came up with the output without any frequency information. What platform

Re: Idlestat output question

2014-06-19 Thread Salman Ahmed
not in idlestat tool. There is no cpu_frequency line in the trace file. --  Best Regards Salman Ahmed On Thursday, 19 June 2014, 18:23, Amit Kucheria wrote: Hi Salman, On Thu, Jun 19, 2014 at 1:36 PM, Salman Ahmed wrote: > Hello, > Running top command with idlestat tool doesn'

Idlestat output question

2014-06-19 Thread Salman Ahmed
e state? -- Best Regards Salman Ahmed ___ linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev