Re: [PATCH v5 00/17] Introduce Xen support on ARM (based on 3.6-rc5)

2012-09-18 Thread Konrad Rzeszutek Wilk
On Tue, Sep 18, 2012 at 02:57:05PM +0100, Stefano Stabellini wrote: > On Tue, 18 Sep 2012, Arnd Bergmann wrote: > > On Monday 17 September 2012, Stefano Stabellini wrote: > > > > > I am also attaching to this email the dts'es that I am currently using > > > for dom0 and domU: vexpress-v2p-ca15-tc1

Re: [PATCH v5 00/17] Introduce Xen support on ARM (based on 3.6-rc5)

2012-09-18 Thread Konrad Rzeszutek Wilk
On Tue, Sep 18, 2012 at 12:34:29PM +, Arnd Bergmann wrote: > On Monday 17 September 2012, Stefano Stabellini wrote: > > > I am also attaching to this email the dts'es that I am currently using > > for dom0 and domU: vexpress-v2p-ca15-tc1.dts (that includes > > vexpress-v2m-rs1-rtsm.dtsi) is th

Re: [PATCH v4 10/24] xen/arm: compile and run xenbus

2012-09-17 Thread Konrad Rzeszutek Wilk
On Mon, Sep 17, 2012 at 02:45:00PM +0100, Stefano Stabellini wrote: > On Mon, 17 Sep 2012, Konrad Rzeszutek Wilk wrote: > > On Fri, Sep 14, 2012 at 12:13:12PM +0100, Stefano Stabellini wrote: > > > bind_evtchn_to_irqhandler can legitimately return 0 (irq 0): it is

Re: [PATCH v4 12/24] xen/arm: introduce CONFIG_XEN on ARM

2012-09-17 Thread Konrad Rzeszutek Wilk
On Mon, Sep 17, 2012 at 04:07:37PM +0400, Sergei Shtylyov wrote: > Hello. > > On 17-09-2012 14:57, Stefano Stabellini wrote: > > >>>Changes in v2: > > >>>- mark Xen guest support on ARM as EXPERIMENTAL. > > >>>Signed-off-by: St

Re: [PATCH v4 10/24] xen/arm: compile and run xenbus

2012-09-17 Thread Konrad Rzeszutek Wilk
On Mon, Sep 17, 2012 at 12:05:59PM +0100, Stefano Stabellini wrote: > On Fri, 14 Sep 2012, Konrad Rzeszutek Wilk wrote: > > On Fri, Sep 14, 2012 at 12:13:12PM +0100, Stefano Stabellini wrote: > > > bind_evtchn_to_irqhandler can legitimately return 0 (irq 0): it is

Re: [PATCH v4 10/24] xen/arm: compile and run xenbus

2012-09-17 Thread Konrad Rzeszutek Wilk
d event channel. > > > Changes in v4: > > - do not xs_reset_watches on dom0. > > > Changes in v2: > > - refactor xenbus_init. > > Signed-off-by: Stefano Stabellini Acked-by: Konrad Rzeszutek Wilk If you would like I can also carry this in my tree

Re: [PATCH v4 00/24] Introduce Xen support on ARM (based on 3.6-rc5)

2012-09-14 Thread Konrad Rzeszutek Wilk
On Fri, Sep 14, 2012 at 12:12:59PM +0100, Stefano Stabellini wrote: > Hi all, > this patch series implements Xen support for ARMv7 with virtualization > extensions. It allows a Linux guest to boot as dom0 and > as domU on Xen on ARM. PV console, disk and network frontends and > backends are all wo

Re: [PATCH v4 15/24] xen/arm: receive Xen events on ARM

2012-09-14 Thread Konrad Rzeszutek Wilk
On Fri, Sep 14, 2012 at 12:13:17PM +0100, Stefano Stabellini wrote: > Compile events.c on ARM. > Parse, map and enable the IRQ to get event notifications from the device > tree (node "/xen"). > > Signed-off-by: Stefano Stabellini Acked-by: Konrad Rzeszutek Wilk >

Re: [PATCH v4 23/24] xen: update xen_add_to_physmap interface

2012-09-14 Thread Konrad Rzeszutek Wilk
ersions." > > Note: this patch should be already in Konrad's tree, it is here just for > convenience. > > Changes in v2: > > - remove erroneous comment in the commit message. > > Signed-off-by: Stefano Stabellini Acked-by: Konrad Rzeszutek Wilk .. and I

Re: [PATCH v4 19/24] xen/arm: compile blkfront and blkback

2012-09-14 Thread Konrad Rzeszutek Wilk
On Fri, Sep 14, 2012 at 12:13:21PM +0100, Stefano Stabellini wrote: > Signed-off-by: Stefano Stabellini > Acked-by: Konrad Rzeszutek Wilk So this should go through Jen's tree or at least get his Ack. But doing all of these patches seperatly is painfull - and remembering where they

Re: [PATCH v4 14/24] xen/arm: initialize grant_table on ARM

2012-09-14 Thread Konrad Rzeszutek Wilk
On Fri, Sep 14, 2012 at 12:13:16PM +0100, Stefano Stabellini wrote: > Initialize the grant table mapping at the address specified at index 0 > in the DT under the /xen node. > After the grant table is initialized, call xenbus_probe (if not dom0). So we don't really care about the grant's size then

Re: [PATCH v4 24/24] MAINTAINERS: add myself as Xen ARM maintainer

2012-09-14 Thread Konrad Rzeszutek Wilk
On Fri, Sep 14, 2012 at 12:13:26PM +0100, Stefano Stabellini wrote: > Signed-off-by: Stefano Stabellini > CC: Arnd Bergmann > CC: Konrad Rzeszutek Wilk Acked-by: Konrad Rzeszutek Wilk > --- > MAINTAINERS |7 +++ > 1 files changed, 7 insertions(+), 0 deletions(-)

Re: [PATCH v4 07/24] xen/arm: Xen detection and shared_info page mapping

2012-09-14 Thread Konrad Rzeszutek Wilk
On Fri, Sep 14, 2012 at 12:13:09PM +0100, Stefano Stabellini wrote: > Check for a node in the device tree compatible with "xen,xen", if it is > present set xen_domain_type to XEN_HVM_DOMAIN and continue > initialization. > > Map the real shared info page using XENMEM_add_to_physmap with > XENMAPSP

Re: [PATCH v4 09/24] xen/arm: Introduce xen_ulong_t for unsigned long

2012-09-14 Thread Konrad Rzeszutek Wilk
to apic_physbase. > > > Signed-off-by: Stefano Stabellini Acked-by: Konrad Rzeszutek Wilk for the generic parts; all other: Reviewed-by: Konrad Rzeszutek Wilk > --- > arch/arm/include/asm/xen/interface.h |8 ++-- > arch/ia64/include/asm/xen/interface.h |1 + >

Re: [PATCH v4 10/24] xen/arm: compile and run xenbus

2012-09-14 Thread Konrad Rzeszutek Wilk
On Fri, Sep 14, 2012 at 12:13:12PM +0100, Stefano Stabellini wrote: > bind_evtchn_to_irqhandler can legitimately return 0 (irq 0): it is not > an error. > > If Linux is running as an HVM domain and is running as Dom0, use > xenstored_local_init to initialize the xenstore page and event channel. L

Re: [PATCH v4 06/24] docs: Xen ARM DT bindings

2012-09-14 Thread Konrad Rzeszutek Wilk
On Fri, Sep 14, 2012 at 12:13:08PM +0100, Stefano Stabellini wrote: > Add a doc to describe the Xen ARM device tree bindings > > > Changes in v4: > > - "xen,xen" should be last as it is less specific; > - update reg property using 2 address-cells and 2 size-cells. > > > Signed-off-by: Stefano

Re: [PATCH v4 02/24] xen/arm: hypercalls

2012-09-14 Thread Konrad Rzeszutek Wilk
s, even if > at the moment is unused; > - use ldm instead of pop; > - fix up comments. > > > Signed-off-by: Stefano Stabellini Reviewed-by: Konrad Rzeszutek Wilk .. since this is all in non-x86 and non-Xen generic parts so cannot provide you with an Ack :-) > --- > arc

Re: [PATCH v2 10/23] xen/arm: compile and run xenbus

2012-08-09 Thread Konrad Rzeszutek Wilk
> > Right, the original patch didn't break anything with PV domains. The case > > it doesn't handle is an HVM initial domain with an already-running > > Xenstore domain; I think this applies both to ARM and hybrid/PVH on x86. > > In that case, usage would be set to LOCAL instead of HVM. > > > Rig

Re: [PATCH v2 23/23] [HACK] xen/arm: implement xen_remap_domain_mfn_range

2012-08-07 Thread Konrad Rzeszutek Wilk
On Mon, Aug 06, 2012 at 03:27:26PM +0100, Stefano Stabellini wrote: > From: Ian Campbell > > Do not apply! OK. > > This is a simple, hacky implementation of xen_remap_domain_mfn_range, > using XENMAPSPACE_gmfn_foreign. > > It should use same interface as hybrid x86. Yeah, Mukesh - can you sha

Re: [PATCH v2 21/23] xen: update xen_add_to_physmap interface

2012-08-07 Thread Konrad Rzeszutek Wilk
On Mon, Aug 06, 2012 at 03:27:24PM +0100, Stefano Stabellini wrote: > Update struct xen_add_to_physmap to be in sync with Xen's version of the > structure. > The size field was introduced by: > > changeset: 24164:707d27fe03e7 > user:Jean Guyader > date:Fri Nov 18 13:42:08 2011 +

Re: [PATCH v2 20/23] xen/arm: compile netback

2012-08-07 Thread Konrad Rzeszutek Wilk
On Mon, Aug 06, 2012 at 03:27:23PM +0100, Stefano Stabellini wrote: > Signed-off-by: Stefano Stabellini OK. Looks good. > --- > arch/arm/include/asm/xen/hypercall.h | 19 +++ > drivers/net/xen-netback/netback.c|1 + > drivers/net/xen-netfront.c |1 + > 3 f

Re: [PATCH v2 19/23] xen/arm: compile blkfront and blkback

2012-08-07 Thread Konrad Rzeszutek Wilk
On Mon, Aug 06, 2012 at 03:27:22PM +0100, Stefano Stabellini wrote: OK. Looks good. > Signed-off-by: Stefano Stabellini > --- > drivers/block/xen-blkback/blkback.c |1 + > include/xen/interface/io/protocols.h |3 +++ > 2 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/d

Re: [PATCH v2 18/23] xen: allow privcmd for HVM guests

2012-08-07 Thread Konrad Rzeszutek Wilk
On Mon, Aug 06, 2012 at 03:27:21PM +0100, Stefano Stabellini wrote: > This patch removes the "return -ENOSYS" for auto_translated_physmap > guests from privcmd_mmap, thus it allows ARM guests to issue privcmd > mmap calls. However privcmd mmap calls are still going to fail for HVM > and hybrid gues

Re: [PATCH v2 17/23] xen/arm: implement alloc/free_xenballooned_pages with alloc_pages/kfree

2012-08-07 Thread Konrad Rzeszutek Wilk
On Mon, Aug 06, 2012 at 03:27:20PM +0100, Stefano Stabellini wrote: > Only until we get the balloon driver to work. OK. Acked-by be. > > Signed-off-by: Stefano Stabellini > --- > arch/arm/xen/enlighten.c | 18 ++ > 1 files changed, 18 insertions(+), 0 deletions(-) > > diff --

Re: [PATCH v2 15/23] xen/arm: receive Xen events on ARM

2012-08-07 Thread Konrad Rzeszutek Wilk
On Mon, Aug 06, 2012 at 03:27:18PM +0100, Stefano Stabellini wrote: > Compile events.c on ARM. > Parse, map and enable the IRQ to get event notifications from the device > tree (node "/xen"). > > Signed-off-by: Stefano Stabellini > --- > arch/arm/include/asm/xen/events.h | 18 +

Re: [PATCH v2 16/23] xen: clear IRQ_NOAUTOEN and IRQ_NOREQUEST

2012-08-07 Thread Konrad Rzeszutek Wilk
On Mon, Aug 06, 2012 at 03:27:19PM +0100, Stefano Stabellini wrote: > Reset the IRQ_NOAUTOEN and IRQ_NOREQUEST flags that are enabled by > default on ARM. If IRQ_NOAUTOEN is set, __setup_irq doesn't call > irq_startup, that is responsible for calling irq_unmask at startup time. > As a result event

Re: [PATCH v2 13/23] xen/arm: get privilege status

2012-08-07 Thread Konrad Rzeszutek Wilk
On Mon, Aug 06, 2012 at 03:27:16PM +0100, Stefano Stabellini wrote: > Use Xen features to figure out if we are privileged. > > XENFEAT_dom0 was introduced by 23735 in xen-unstable.hg. Looks good. > > Signed-off-by: Stefano Stabellini > --- > arch/arm/xen/enlighten.c |7 +++ >

Re: [PATCH v2 12/23] xen/arm: introduce CONFIG_XEN on ARM

2012-08-07 Thread Konrad Rzeszutek Wilk
On Mon, Aug 06, 2012 at 03:27:15PM +0100, Stefano Stabellini wrote: > Changes in v2: > > - mark Xen guest support on ARM as EXPERIMENTAL. OK. Looks good. > > Signed-off-by: Stefano Stabellini > --- > arch/arm/Kconfig | 10 ++ > 1 files changed, 10 insertions(+), 0 deletions(-) > > d

Re: [PATCH v2 11/23] xen: do not compile manage, balloon, pci, acpi and cpu_hotplug on ARM

2012-08-07 Thread Konrad Rzeszutek Wilk
On Mon, Aug 06, 2012 at 03:27:14PM +0100, Stefano Stabellini wrote: > Changes in v2: > > - make pci.o depend on CONFIG_PCI and acpi.o depend on CONFIG_ACPI. > > Signed-off-by: Stefano Stabellini Looks good. > --- > drivers/xen/Makefile | 11 --- > 1 files changed, 8 insertions(+), 3

Re: [PATCH v2 10/23] xen/arm: compile and run xenbus

2012-08-07 Thread Konrad Rzeszutek Wilk
On Mon, Aug 06, 2012 at 03:27:13PM +0100, Stefano Stabellini wrote: > bind_evtchn_to_irqhandler can legitimately return 0 (irq 0): it is not > an error. > > If Linux is running as an HVM domain and is running as Dom0, use > xenstored_local_init to initialize the xenstore page and event channel. >

Re: [PATCH v2 09/23] xen/arm: Introduce xen_ulong_t for unsigned long

2012-08-07 Thread Konrad Rzeszutek Wilk
On Mon, Aug 06, 2012 at 03:27:12PM +0100, Stefano Stabellini wrote: > All the original Xen headers have xen_ulong_t as unsigned long type, however > when they have been imported in Linux, xen_ulong_t has been replaced with > unsigned long. That might work for x86 and ia64 but it does not for arm. >

Re: [PATCH v2 08/23] xen/arm: Introduce xen_pfn_t for pfn and mfn types

2012-08-07 Thread Konrad Rzeszutek Wilk
On Mon, Aug 06, 2012 at 03:27:11PM +0100, Stefano Stabellini wrote: > All the original Xen headers have xen_pfn_t as mfn and pfn type, however > when they have been imported in Linux, xen_pfn_t has been replaced with > unsigned long. That might work for x86 and ia64 but it does not for arm. > Bring

Re: [PATCH v2 07/23] xen/arm: Xen detection and shared_info page mapping

2012-08-07 Thread Konrad Rzeszutek Wilk
On Mon, Aug 06, 2012 at 03:27:10PM +0100, Stefano Stabellini wrote: > Check for a "/xen" node in the device tree, if it is present set > xen_domain_type to XEN_HVM_DOMAIN and continue initialization. > > Map the real shared info page using XENMEM_add_to_physmap with > XENMAPSPACE_shared_info. > >

Re: [PATCH v2 06/23] xen: missing includes

2012-08-07 Thread Konrad Rzeszutek Wilk
On Mon, Aug 06, 2012 at 03:27:09PM +0100, Stefano Stabellini wrote: > Changes in v2: > - remove pvclock hack; > - remove include linux/types.h from xen/interface/xen.h. I think I can take in my tree now right by itself right? Or do you want to keep this in your patchqueue? If so, Ack from me. > >

Re: [PATCH v2 04/23] xen/arm: sync_bitops

2012-08-07 Thread Konrad Rzeszutek Wilk
On Mon, Aug 06, 2012 at 03:27:07PM +0100, Stefano Stabellini wrote: > sync_bitops functions are equivalent to the SMP implementation of the > original functions, independently from CONFIG_SMP being defined. > > We need them because _set_bit etc are not SMP safe if !CONFIG_SMP. But > under Xen you

Re: [PATCH v2 05/23] xen/arm: empty implementation of grant_table arch specific functions

2012-08-07 Thread Konrad Rzeszutek Wilk
On Mon, Aug 06, 2012 at 03:27:08PM +0100, Stefano Stabellini wrote: > Changes in v2: > > - return -ENOSYS rather than -1. Ack. > > Signed-off-by: Stefano Stabellini > --- > arch/arm/xen/Makefile |2 +- > arch/arm/xen/grant-table.c | 53 >

Re: [PATCH v2 03/23] xen/arm: page.h definitions

2012-08-07 Thread Konrad Rzeszutek Wilk
On Mon, Aug 06, 2012 at 03:27:06PM +0100, Stefano Stabellini wrote: > ARM Xen guests always use paging in hardware, like PV on HVM guests in > the X86 world. > > Signed-off-by: Stefano Stabellini Ack.. with one nitpick > +/* XXX: this shouldn't be here */ .. but its here b/c the frontend drive

Re: [PATCH v2 01/23] arm: initial Xen support

2012-08-07 Thread Konrad Rzeszutek Wilk
On Mon, Aug 06, 2012 at 03:27:04PM +0100, Stefano Stabellini wrote: > - Basic hypervisor.h and interface.h definitions. > - Skeleton enlighten.c, set xen_start_info to an empty struct. > - Make xen_initial_domain dependent on the SIF_PRIVILIGED_BIT. > > The new code only compiles when CONFIG_XEN i

Re: [Xen-devel] [PATCH 01/24] arm: initial Xen support

2012-08-02 Thread Konrad Rzeszutek Wilk
On Thu, Aug 02, 2012 at 08:35:51AM +0100, Ian Campbell wrote: > On Wed, 2012-08-01 at 19:27 +0100, Rob Herring wrote: > > On 07/26/2012 10:33 AM, Stefano Stabellini wrote: > > > - Basic hypervisor.h and interface.h definitions. > > > - Skelethon enlighten.c, set xen_start_info to an empty struct. >

Re: [PATCH 24/24] [HACK] xen/arm: implement xen_remap_domain_mfn_range

2012-08-01 Thread Konrad Rzeszutek Wilk
On Thu, Jul 26, 2012 at 04:34:06PM +0100, Stefano Stabellini wrote: > From: Ian Campbell > > Do not apply! Mukesh, I believe this is similar to what you had in mind. > > This is a simple, hacky implementation of xen_remap_domain_mfn_range, > using XENMAPSPACE_gmfn_foreign. > > It should use s

Re: [PATCH 23/24] hvc_xen: allow dom0_write_console for HVM guests

2012-08-01 Thread Konrad Rzeszutek Wilk
On Thu, Jul 26, 2012 at 04:34:05PM +0100, Stefano Stabellini wrote: > On ARM all guests are HVM guests, including Dom0. > Allow dom0_write_console to be called by an HVM domain. Um, but xen_hvm_domain() != xen_pv_domain() so won't this return without printing anything? > > Signed-off-by: Stefano

Re: [PATCH 21/24] arm/v2m: initialize arch_timers even if v2m_timer is not present

2012-08-01 Thread Konrad Rzeszutek Wilk
On Thu, Jul 26, 2012 at 04:34:03PM +0100, Stefano Stabellini wrote: > Signed-off-by: Stefano Stabellini Should the maintainer of the v2m be CC-ed here? This looks like a bug-fix of itself? > --- > arch/arm/mach-vexpress/v2m.c | 11 ++- > 1 files changed, 6 insertions(+), 5 deletions(-

Re: [PATCH 20/24] xen: update xen_add_to_physmap interface

2012-08-01 Thread Konrad Rzeszutek Wilk
On Thu, Jul 26, 2012 at 04:34:02PM +0100, Stefano Stabellini wrote: > Update struct xen_add_to_physmap to be in sync with Xen's version of the > structure. > The size field was introduced by: > > changeset: 24164:707d27fe03e7 > user:Jean Guyader > date:Fri Nov 18 13:42:08 2011 +

Re: [PATCH 18/24] xen/arm: compile blkfront and blkback

2012-08-01 Thread Konrad Rzeszutek Wilk
On Thu, Jul 26, 2012 at 04:34:00PM +0100, Stefano Stabellini wrote: > Signed-off-by: Stefano Stabellini > --- > drivers/block/xen-blkback/blkback.c |1 + > include/xen/interface/io/protocols.h |3 +++ > 2 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/drivers/block/xen-

Re: [Xen-devel] [PATCH 17/24] xen: allow privcmd for HVM guests

2012-08-01 Thread Konrad Rzeszutek Wilk
On Fri, Jul 27, 2012 at 03:10:13PM +0100, Stefano Stabellini wrote: > On Fri, 27 Jul 2012, Jan Beulich wrote: > > >>> On 26.07.12 at 17:33, Stefano Stabellini > > >>> wrote: > > > In order for privcmd mmap to work correctly, xen_remap_domain_mfn_range > > > needs to be implemented for HVM guests.

Re: [PATCH 15/24] xen/arm: receive Xen events on ARM

2012-08-01 Thread Konrad Rzeszutek Wilk
On Thu, Jul 26, 2012 at 04:33:57PM +0100, Stefano Stabellini wrote: > Compile events.c on ARM. > Parse, map and enable the IRQ to get event notifications from the device > tree (node "/xen"). > > On ARM Linux irqs are not enabled by default: > > - call enable_percpu_irq for xen_events_irq (driver

Re: [PATCH 14/24] xen/arm: initialize grant_table on ARM

2012-08-01 Thread Konrad Rzeszutek Wilk
On Thu, Jul 26, 2012 at 04:33:56PM +0100, Stefano Stabellini wrote: > Initialize the grant table mapping at the address specified at index 0 > in the DT under the /xen node. Is it always index 0? If so, should it have a #define for the other index values? > After the grant table is initialized, c

Re: [PATCH 13/24] xen/arm: get privilege status

2012-08-01 Thread Konrad Rzeszutek Wilk
On Fri, Jul 27, 2012 at 03:33:50PM +0100, Ian Campbell wrote: > On Fri, 2012-07-27 at 15:25 +0100, Stefano Stabellini wrote: > > On Fri, 27 Jul 2012, Ian Campbell wrote: > > > On Thu, 2012-07-26 at 16:33 +0100, Stefano Stabellini wrote: > > > > Use Xen features to figure out if we are privileged. >

Re: [PATCH 12/24] xen/arm: Introduce xen_guest_init

2012-08-01 Thread Konrad Rzeszutek Wilk
On Thu, Jul 26, 2012 at 04:33:54PM +0100, Stefano Stabellini wrote: > We used to rely on a core_initcall to initialize Xen on ARM, however > core_initcalls are actually called after early consoles are initialized. > That means that hvc_xen.c is going to be initialized before Xen. > > Given the lac

Re: [Xen-devel] [PATCH 04/24] xen/arm: sync_bitops

2012-08-01 Thread Konrad Rzeszutek Wilk
On Fri, Jul 27, 2012 at 10:28:25AM +0100, Ian Campbell wrote: > On Thu, 2012-07-26 at 17:37 +0100, Konrad Rzeszutek Wilk wrote: > > On Thu, Jul 26, 2012 at 04:33:46PM +0100, Stefano Stabellini wrote: > > > sync_bitops functions are equivalent to the SMP implementation of

Re: [Xen-devel] [PATCH 11/24] xen/arm: introduce CONFIG_XEN on ARM

2012-08-01 Thread Konrad Rzeszutek Wilk
On Thu, Jul 26, 2012 at 04:33:53PM +0100, Stefano Stabellini wrote: > Signed-off-by: Stefano Stabellini > --- > arch/arm/Kconfig | 10 ++ > 1 files changed, 10 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index a91009c..9c54cb4 100644 > --- a/arc

Re: [PATCH 09/24] xen/arm: compile and run xenbus

2012-08-01 Thread Konrad Rzeszutek Wilk
On Thu, Jul 26, 2012 at 04:33:51PM +0100, Stefano Stabellini wrote: > bind_evtchn_to_irqhandler can legitimately return 0 (irq 0): it is not > an error. > > If Linux is running as an HVM domain and is running as Dom0, use > xenstored_local_init to initialize the xenstore page and event channel. >

Re: [PATCH 08/24] xen/arm: Introduce xen_pfn_t for pfn and mfn types

2012-08-01 Thread Konrad Rzeszutek Wilk
On Thu, Jul 26, 2012 at 04:33:50PM +0100, Stefano Stabellini wrote: > All the original Xen headers have xen_pfn_t as mfn and pfn type, however > when they have been imported in Linux, xen_pfn_t has been replaced with > unsigned long. That might work for x86 and ia64 but it does not for arm. How co

Re: [PATCH 07/24] xen/arm: Xen detection and shared_info page mapping

2012-08-01 Thread Konrad Rzeszutek Wilk
On Thu, Jul 26, 2012 at 04:33:49PM +0100, Stefano Stabellini wrote: > Check for a "/xen" node in the device tree, if it is present set > xen_domain_type to XEN_HVM_DOMAIN and continue initialization. > > Map the real shared info page using XENMEM_add_to_physmap with > XENMAPSPACE_shared_info. > >

Re: [PATCH 05/24] xen/arm: empty implementation of grant_table arch specific functions

2012-08-01 Thread Konrad Rzeszutek Wilk
On Thu, Jul 26, 2012 at 04:33:47PM +0100, Stefano Stabellini wrote: > Signed-off-by: Stefano Stabellini > --- > arch/arm/xen/Makefile |2 +- > arch/arm/xen/grant-table.c | 53 > > 2 files changed, 54 insertions(+), 1 deletions(-) > create

Re: [Xen-devel] [PATCH 01/24] arm: initial Xen support

2012-08-01 Thread Konrad Rzeszutek Wilk
> > > +struct pvclock_wall_clock { > > > + u32 version; > > > + u32 sec; > > > + u32 nsec; > > > +} __attribute__((__packed__)); > > > > That is weird. It is 4+4+4 = 12 bytes? Don't you want it to be 16 bytes? > > I agree that 16 bytes would be a better choice, but it needs to match > the s

Re: [Xen-devel] [PATCH 02/24] xen/arm: hypercalls

2012-07-27 Thread Konrad Rzeszutek Wilk
On Thu, Jul 26, 2012 at 04:33:44PM +0100, Stefano Stabellini wrote: > Use r12 to pass the hypercall number to the hypervisor. > > We need a register to pass the hypercall number because we might not > know it at compile time and HVC only takes an immediate argument. > > Among the available regist

Re: [Xen-devel] [PATCH 01/24] arm: initial Xen support

2012-07-27 Thread Konrad Rzeszutek Wilk
On Thu, Jul 26, 2012 at 04:33:43PM +0100, Stefano Stabellini wrote: > - Basic hypervisor.h and interface.h definitions. > - Skelethon enlighten.c, set xen_start_info to an empty struct. Skeleton > - Do not limit xen_initial_domain to PV guests. Better wording: Make xen_initial_domain dependent o

Re: [Xen-devel] [PATCH 04/24] xen/arm: sync_bitops

2012-07-27 Thread Konrad Rzeszutek Wilk
On Thu, Jul 26, 2012 at 04:33:46PM +0100, Stefano Stabellini wrote: > sync_bitops functions are equivalent to the SMP implementation of the > original functions, independently from CONFIG_SMP being defined. So why can't the code be changed to use that? Is it that the _set_bit, _clear_bit, etc are

Re: [Xen-devel] [PATCH 03/24] xen/arm: page.h definitions

2012-07-27 Thread Konrad Rzeszutek Wilk
On Thu, Jul 26, 2012 at 04:33:45PM +0100, Stefano Stabellini wrote: > ARM Xen guests always use paging in hardware, like PV on HVM guests in > the X86 world. Nice, so no dealing with the P2M at all in the guest? > > Signed-off-by: Stefano Stabellini > --- > arch/arm/include/asm/xen/page.h |

Re: [PATCH] acpi : remove power from acpi_processor_cx structure

2012-07-25 Thread Konrad Rzeszutek Wilk
On Tue, Jul 24, 2012 at 11:12:29PM +0200, Daniel Lezcano wrote: > Remove the power field as it is not used. > > Signed-off-by: Daniel Lezcano > Cc: Konrad Rzeszutek Wilk Acked. > --- > drivers/acpi/processor_idle.c|2 -- > drivers/xen/xen-acpi-processor.c |