Re: [PATCH v8 1/2] video: drm: exynos: Add display-timing node parsing using video helper function

2013-02-27 Thread Joonyoung Shim
On 02/28/2013 11:45 AM, Vikas Sajjan wrote: Hi, On 28 February 2013 08:07, Joonyoung Shim wrote: On 02/27/2013 08:49 PM, Vikas Sajjan wrote: Add support for parsing the display-timing node using video helper function. The DT node parsing and pinctrl selection is done only if 'dev.of

Re: [PATCH v8 1/2] video: drm: exynos: Add display-timing node parsing using video helper function

2013-02-27 Thread Joonyoung Shim
OF_USE_NATIVE_MODE); + if (ret) { + DRM_ERROR("failed: of_get_fb_videomode()\n" + "with return value: %d\n", ret); Could you make this error log to one line? except this, Acked-by: Joonyoung Shim +

Re: [PATCH V2] ARM: S5P: Fix compilation error for exynos4_defconfig

2011-06-03 Thread Joonyoung Shim
y.c} (100%) There is one white space but Acked-by: Joonyoung Shim diff --git a/arch/arm/mach-exynos4/Kconfig b/arch/arm/mach-exynos4/Kconfig index b92c1e5..a45a022 100644 --- a/arch/arm/mach-exynos4/Kconfig +++ b/arch/arm/mach-exynos4/Kconfig @@ -91,6 +91,11 @@ config EXYNOS4_SETUP_FIMC

Re: [PATCH V2] ARM: S5P: Fix compilation error for exynos4_defconfig

2011-06-03 Thread Joonyoung Shim
On 2011-06-03 오후 5:44, Tushar Behera wrote: Hi, On Friday 03 June 2011 01:20 PM, Joonyoung Shim wrote: On 2011-06-03 오후 4:04, Tushar Behera wrote: Added Kconfig entry for setup-usb-phy.c on which EHCI support is dependent on. Following the naming convention of other setup files, we have