Re: [PATCH V2 6/6] Thermal: Add ST-Ericsson DB8500 thermal properties and platform data.

2012-10-24 Thread Joe Perches
On Wed, 2012-10-24 at 19:58 +0800, hongbo.zhang wrote: > This patch adds device tree properties for ST-Ericsson DB8500 thermal driver, > also adds the platform data to support the old fashion. Just a trivial note: > diff --git a/arch/arm/mach-ux500/board-mop500.c > b/arch/arm/mach-ux500/board-mo

Re: [PATCH 5/5] Thermal: Add ST-Ericsson db8500 thermal dirver.

2012-10-17 Thread Joe Perches
On Wed, 2012-10-17 at 20:53 +0530, Viresh Kumar wrote: > On 16 October 2012 17:14, hongbo.zhang wrote: [] > > diff --git a/drivers/thermal/db8500_cpufreq_cooling.c > > b/drivers/thermal/db8500_cpufreq_cooling.c [] > > +#include > > +#include > > +#include > > +#include > > +#include > > +#in

Re: [PATCH 1/2] cpufreq: Improve debug prints

2012-10-17 Thread Joe Perches
On Wed, 2012-10-17 at 12:03 +0530, Viresh Kumar wrote: > On 17 October 2012 11:56, Joe Perches wrote: > > Oh good, but please use a space between KBUILD_MODNAME > > and the quoted ": ". > > Anything technical behind it or just for code formatting? Just code forma

Re: [PATCH 1/2] cpufreq: Improve debug prints

2012-10-17 Thread Joe Perches
On Wed, 2012-10-17 at 10:50 +0530, Viresh Kumar wrote: > With debug options on, it is difficult to locate cpufreq core's debug prints. [] > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c [] > @@ -15,6 +15,8 @@ > +#define pr_fmt(fmt) "cpufreq: " fmt I'd prefer that #define pr_f

Re: [PATCH 1/2] cpufreq: Improve debug prints

2012-10-17 Thread Joe Perches
On Wed, 2012-10-17 at 11:25 +0530, Viresh Kumar wrote: > On 17 October 2012 11:09, Joe Perches wrote: > > On Wed, 2012-10-17 at 10:50 +0530, Viresh Kumar wrote: > >> With debug options on, it is difficult to locate cpufreq core's debug > >> prints. > >

Re: [PATCH 1/2] cpufreq: Improve debug prints

2012-10-17 Thread Joe Perches
On Wed, 2012-10-17 at 11:47 +0530, Viresh Kumar wrote: > On 17 October 2012 11:34, Joe Perches wrote: > > I believe you are quoting KBUILD_MODNAME > > Yes. :( > Far better output with this. Thanks. Oh good, but please use a space between KBUILD_MODNAME and the quoted ":

Re: [PATCH v4 1/3] devfreq: Core updates to support devices which can idle

2012-10-08 Thread Joe Perches
On Mon, 2012-10-08 at 14:02 +0530, Rajagopal Venkat wrote: > On 8 October 2012 13:44, MyungJoo Ham wrote: [] > > Thank you! [] > Thanks for reviewing and testing this patchset. Both of you quoted all of the original large patch. That's quite impolite to all the rest of us on this list. Please c

Re: [RFC 1/4] ARM: topology: Add arch_scale_freq_power function

2012-06-13 Thread Joe Perches
On Wed, 2012-06-13 at 20:27 +0100, Andy Whitcroft wrote: > On Wed, Jun 13, 2012 at 02:52:49PM +0200, Peter Zijlstra wrote: > > On Tue, 2012-06-12 at 14:02 +0200, Vincent Guittot wrote: > > > } > > > smp_wmb(); > > > } > > > > You know what.. we should make checkpatch report an er

Re: [PATCH 1/2] drivers: create a pinmux subsystem v3

2011-06-13 Thread Joe Perches
On Mon, 2011-06-13 at 18:58 +0200, Linus Walleij wrote: > This creates a subsystem for handling of pinmux devices. These are > devices that enable and disable groups of pins on primarily PGA and > BGA type of chip packages and common in embedded systems. Trivia only: > diff --git a/drivers/pinctr