Re: [PATCH v4] sched: fix init NOHZ_IDLE flag

2013-02-27 Thread Frederic Weisbecker
On Wed, Feb 27, 2013 at 09:28:26AM +0100, Vincent Guittot wrote: > > Ok I don't like having a per cpu state in struct sched domain but for > > now I can't find anything better. So my suggestion is that we do this > > and describe well the race, define the issue in the changelog and code > > comment

Re: [RFC/PATCH 1/5] context tracking: conditionalize guest support based on CONFIG_KVM

2013-02-27 Thread Frederic Weisbecker
2013/2/27 Kevin Hilman : > From 61e35f069a64c03a2bce348487d41072aeb9f36b Mon Sep 17 00:00:00 2001 > From: Kevin Hilman > Date: Thu, 14 Feb 2013 10:17:37 -0800 > Subject: [PATCH] context tracking: conditionalize guest support based on > CONFIG_KVM > > So that it can build on !KVM systems too. > >

Re: [PATCH v4] sched: fix init NOHZ_IDLE flag

2013-02-26 Thread Frederic Weisbecker
2013/2/26 Vincent Guittot : > On 26 February 2013 14:16, Frederic Weisbecker wrote: >> 2013/2/22 Vincent Guittot : >>> I wanted to avoid having to use the sd pointer for testing NOHZ_IDLE >>> flag because it occurs each time we go into idle but it seems to be >>&

Re: [RFC/PATCH 4/5] cputime: use do_div() for nsec resolution conversion helpers

2013-02-26 Thread Frederic Weisbecker
2013/2/21 Kevin Hilman : > From a8a0a8b8b12512a7f862ade459cd88d2b48e2bf3 Mon Sep 17 00:00:00 2001 > From: Kevin Hilman > Date: Thu, 14 Feb 2013 11:27:36 -0800 > Subject: [PATCH 4/5] cputime: use do_div() for nsec resolution conversion > helpers > > For the nsec resolution conversions to be useful

Re: [PATCH v4] sched: fix init NOHZ_IDLE flag

2013-02-26 Thread Frederic Weisbecker
2013/2/22 Vincent Guittot : > I wanted to avoid having to use the sd pointer for testing NOHZ_IDLE > flag because it occurs each time we go into idle but it seems to be > not easily feasible. > Another solution could be to add a synchronization step between > rcu_assign_pointer(dom 1, NULL) and cre

Re: [RFC/PATCH 1/5] context tracking: conditionalize guest support based on CONFIG_KVM

2013-02-22 Thread Frederic Weisbecker
On Wed, Feb 20, 2013 at 11:41:38AM -0800, Kevin Hilman wrote: > So that it can build on !KVM systems too. > > Signed-off-by: Kevin Hilman > --- > kernel/context_tracking.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/kernel/context_tracking.c b/kernel/context_tracking.c > index

Re: [PATCH v4] sched: fix init NOHZ_IDLE flag

2013-02-22 Thread Frederic Weisbecker
On Thu, Feb 21, 2013 at 09:29:16AM +0100, Vincent Guittot wrote: > On my smp platform which is made of 5 cores in 2 clusters, I have the > nr_busy_cpu field of sched_group_power struct that is not null when the > platform is fully idle. The root cause seems to be: > During the boot sequence, some C

Re: [RFC/PATCH 2/5] kernel_cpustat: convert to atomic 64-bit accessors

2013-02-21 Thread Frederic Weisbecker
2013/2/21 Russell King - ARM Linux : > On Thu, Feb 21, 2013 at 10:53:07PM +0100, Frederic Weisbecker wrote: >> That too should be kcpustat_this_cpu_set(), or kcpustat_this_cpu_add() >> FWIW. But we probably don't need the overhead of atomic_add() that >> does a LOCK. >

Re: [RFC/PATCH 2/5] kernel_cpustat: convert to atomic 64-bit accessors

2013-02-21 Thread Frederic Weisbecker
2013/2/21 Frederic Weisbecker : > 2013/2/21 Kevin Hilman : >> Subject: [PATCH 2/5] kernel_cpustat: convert to atomic 64-bit accessors >> >> Use the atomic64_* accessors for all the kernel_cpustat fields to >> ensure atomic access on non-64 bit platforms. >>

Re: [RFC/PATCH 2/5] kernel_cpustat: convert to atomic 64-bit accessors

2013-02-21 Thread Frederic Weisbecker
2013/2/21 Kevin Hilman : > Subject: [PATCH 2/5] kernel_cpustat: convert to atomic 64-bit accessors > > Use the atomic64_* accessors for all the kernel_cpustat fields to > ensure atomic access on non-64 bit platforms. > > Thanks to Mats Liljegren for CGROUP_CPUACCT related fixes. > > Cc: Mats Liljeg

Re: [RFC/PATCH 4/5] cputime: use do_div() for nsec resolution conversion helpers

2013-02-21 Thread Frederic Weisbecker
2013/2/20 Kevin Hilman : > For the nsec resolution conversions to be useful on non 64-bit > architectures, do_div() needs to be used for the 64-bit divisions. > > Signed-off-by: Kevin Hilman > --- The patch looks good. I'll run and apply it if everything's fine. _

Re: [PATCH v2 1/2] sched: fix init NOHZ_IDLE flag

2013-02-20 Thread Frederic Weisbecker
2013/2/8 Vincent Guittot : > On 8 February 2013 16:35, Frederic Weisbecker wrote: >> What if the following happen (inventing function names but you get the idea): >> >> CPU 0 CPU 1 >> >> dom = new_domain(...)

Re: [PATCH v2 1/2] sched: fix init NOHZ_IDLE flag

2013-02-20 Thread Frederic Weisbecker
2013/2/18 Frederic Weisbecker : > 2013/2/8 Vincent Guittot : >> On 8 February 2013 16:35, Frederic Weisbecker wrote: >>> What if the following happen (inventing function names but you get the >>> idea): >>> >>> CPU 0

Re: [PATCH v2 1/2] sched: fix init NOHZ_IDLE flag

2013-02-18 Thread Frederic Weisbecker
2013/2/18 Vincent Guittot : > On 18 February 2013 15:38, Frederic Weisbecker wrote: >> I pasted the original at: http://pastebin.com/DMm5U8J8 > > We can clear the idle flag only in the nohz_kick_needed which will not > be called if the sched_domain is NULL so the sequence w

Re: [PATCH v2 1/2] sched: fix init NOHZ_IDLE flag

2013-02-18 Thread Frederic Weisbecker
2013/2/4 Vincent Guittot : > On 1 February 2013 19:03, Frederic Weisbecker wrote: >>> diff --git a/kernel/sched/core.c b/kernel/sched/core.c >>> index 257002c..fd41924 100644 >>> --- a/kernel/sched/core.c >>> +++ b/kernel/sched/core.c >>> @@ -5884,

Re: [PATCH v2 1/2] sched: fix init NOHZ_IDLE flag

2013-02-18 Thread Frederic Weisbecker
2013/1/29 Vincent Guittot : > On my smp platform which is made of 5 cores in 2 clusters,I have the > nr_busy_cpu field of sched_group_power struct that is not null when the > platform is fully idle. The root cause seems to be: > During the boot sequence, some CPUs reach the idle loop and set their

Re: [PATCH Resend 1/3] sched: fix nr_busy_cpus with coupled cpuidle

2013-02-18 Thread Frederic Weisbecker
2013/1/25 Vincent Guittot : > > Le 25 janv. 2013 13:00, "Frederic Weisbecker" a écrit : > > >> >> 2013/1/25 Vincent Guittot : >> > This sequence is not the right one >> > >> >> I'm going to look for the saved trace to check

Re: [PATCH Resend 1/3] sched: fix nr_busy_cpus with coupled cpuidle

2013-02-18 Thread Frederic Weisbecker
2012/12/3 Vincent Guittot : > With the coupled cpuidle driver (but probably also with other drivers), > a CPU loops in a temporary safe state while waiting for other CPUs of its > cluster to be ready to enter the coupled C-state. If an IRQ or a softirq > occurs, the CPU will stay in this internal l

Re: [PATCH Resend 1/3] sched: fix nr_busy_cpus with coupled cpuidle

2013-02-18 Thread Frederic Weisbecker
2013/1/25 Vincent Guittot : > This sequence is not the right one > >> I'm going to look for the saved trace to check the sequence above > > I haven't been able to reproduce the bug that this patch was supposed to > solved. The patch 2 and 3 seem enough to fix the nr_busy_cpus field. I will > contin

Re: [RFC] Scheduler recorder and playback

2012-03-08 Thread Frederic Weisbecker
On Thu, Mar 08, 2012 at 03:20:53PM +0200, Pantelis Antoniou wrote: > Hi there, > > There's considerable activity in the subject of the scheduler lately and how > to > adapt it to the peculiarities of the new class of hardware coming out lately, > like the big.LITTLE class of devices from a numbe