Re: [RFC PATCH 05/17] ARM: kernel: save/restore kernel IF

2011-07-11 Thread Frank Hofmann
On Mon, 11 Jul 2011, Lorenzo Pieralisi wrote: [ ... ] The array of pointers is there to save pgdir on idle entry, one per-cpu. If you're going through cpu_{do_}suspend/resume, the TTBRs are saved/restored anyway, what do you need to keep the virtual addresses around for ? Because I switch m

Re: [RFC PATCH 05/17] ARM: kernel: save/restore kernel IF

2011-07-11 Thread Frank Hofmann
On Mon, 11 Jul 2011, Lorenzo Pieralisi wrote: On Fri, Jul 08, 2011 at 05:12:22PM +0100, Frank Hofmann wrote: Hi Lorenzo, only a few comments at this stage. The sr_entry.S code is both exclusively .arm (using conditionals and long-distance adr, i.e. not Thumb2-clean), and it uses post-armv5

Re: [RFC PATCH 05/17] ARM: kernel: save/restore kernel IF

2011-07-08 Thread Frank Hofmann
Hi Lorenzo, only a few comments at this stage. The sr_entry.S code is both exclusively .arm (using conditionals and long-distance adr, i.e. not Thumb2-clean), and it uses post-armv5 instructions (like wfi). Same for the other *.S code in the patch series. It's non-generic assembly within arch