Re: [PATCH 2/5] clk: notifier handler for dynamic voltage scaling

2013-03-10 Thread Francesco Lavra
On 02/28/2013 05:49 AM, Mike Turquette wrote: > Dynamic voltage and frequency scaling (dvfs) is a common power saving > technique in many of today's modern processors. This patch introduces a > common clk rate-change notifier handler which scales voltage > appropriately whenever clk_set_rate is ca

Re: [PATCH 4/4] cpufreq: governor: Implement per policy instances of governors

2013-02-10 Thread Francesco Lavra
Hi, On 02/04/2013 12:38 PM, Viresh Kumar wrote: > Currently, there can't be multiple instances of single governor_type. If we > have > a multi-package system, where we have multiple instances of struct policy (per > package), we can't have multiple instances of same governor. i.e. We can't > hav

Re: [PATCH 2/2][V2] cpuidle - optimize the select function for the 'menu' governor

2012-12-16 Thread Francesco Lavra
Hi Daniel, On 12/14/2012 02:57 PM, Daniel Lezcano wrote: > As the power is backward sorted in the states array and we are looking for > the state consuming the little power as possible, instead of looking from > the beginning of the array, we look from the end. That should save us some > iteration

Re: [PATCH] ab8500: remove explicit handling of battery type

2012-12-01 Thread Francesco Lavra
Hi, On 11/28/2012 08:27 PM, Rajanikanth H.V wrote: > From: "Rajanikanth H.V" > > property, battery-type shall be one of supported technology type > instead blank > - refer: Documentation/devicetree/bindings/power_supply/ab8500/fg.txt > for the list supported types > - this patch appends to

Re: [PATCH] genirq: Add default affinity mask command line option

2012-11-24 Thread Francesco Lavra
Hi, On 11/19/2012 03:47 PM, Punit Agrawal wrote: > The patch was picked up as-is from the RT patches as it implements a > functionality that we wanted to better control IRQ affinity. Being part > of the RT patches, I hope that it'll merge into mainline via that route > and I am not going to try to

Re: [PATCH V6 1/2] Thermal: Add ST-Ericsson DB8500 thermal driver.

2012-11-18 Thread Francesco Lavra
>> used to active thermal update when trip points are reached. >> >> Signed-off-by: hongbo.zhang >> Reviewed-by: Viresh Kumar >> Reviewed-by: Francesco Lavra > > Patch is refreshed and applied to thermal next. > refreshed patch attached. [...] > diff --git a/dr

Re: [PATCH] genirq: Add default affinity mask command line option

2012-11-18 Thread Francesco Lavra
Hi, On 11/12/2012 05:57 PM, Punit Agrawal wrote: > I am attaching a patch by Thomas Gleixner which adds a kernel > command line parameter to set the defauilt IRQ affinity mask. Could > you please integrate this in your tree for the next Linaro release? > > I've been using this patch for sometime

Re: [RFC] cpuidle - remove the power_specified field in the driver

2012-11-18 Thread Francesco Lavra
Hi, On 11/12/2012 09:26 PM, Daniel Lezcano wrote: > This patch follows the discussion about reinitializing the power usage > when a C-state is added/removed. > > https://lkml.org/lkml/2012/10/16/518 > > We realized the power usage field is never filled and when it is > filled for tegra, the pow

Re: [PATCH 1/4] mfd: ab8500: add devicetree support for fuelgauge

2012-11-10 Thread Francesco Lavra
On 11/07/2012 07:45 PM, Rajanikanth H V wrote: > On Thu, 1 Nov 2012, Francesco Lavra wrote: > [...] >>> +btech = of_get_property(np_bat_supply, >>> +"stericsson,battery-type", NULL); >>> +if (!btech) { >>> +

Re: [PATCH 1/4] mfd: ab8500: add devicetree support for fuelgauge

2012-11-01 Thread Francesco Lavra
On 10/31/2012 04:40 PM, Rajanikanth H.V wrote: > From: "Rajanikanth H.V" > > - This patch adds device tree support for fuelgauge driver > - optimize bm devices platform_data usage and of_probe(...) > Note: of_probe() routine for battery managed devices is made > common across all bm drivers.

Re: [PATCH V3 4/5] Thermal: Add ST-Ericsson DB8500 thermal driver.

2012-11-01 Thread Francesco Lavra
ot;, i, j); > + if (of_property_read_string(np, prop_name, &tmp_str)) > + goto err_parse_dt; > + > + if (strlen(tmp_str) > THERMAL_NAME_LENGTH) > + goto err_parse_

Re: [PATCH 1/4] mfd: ab8500: add devicetree support for fuelgauge

2012-10-27 Thread Francesco Lavra
On 10/27/2012 06:00 PM, Rajanikanth HV wrote: > On 27 October 2012 20:37, Francesco Lavra wrote: >> On 10/25/2012 08:30 AM, Rajanikanth H.V wrote: >>> From: "Rajanikanth H.V" >>> + bat_tech = of_get_property(np_bat_supply, >>> +

Re: [PATCH 4/4] mfd: ab8500: add devicetree support for chargalg

2012-10-27 Thread Francesco Lavra
On 10/25/2012 08:30 AM, Rajanikanth H.V wrote: > From: "Rajanikanth H.V" > > This patch adds device tree support for charging algorithm > driver > > Signed-off-by: Rajanikanth H.V [...] > diff --git a/drivers/power/abx500_chargalg.c b/drivers/power/abx500_chargalg.c > index 88b5cc1..829fcfd 100

Re: [PATCH 3/4] mfd: ab8500: add devicetree support for charger

2012-10-27 Thread Francesco Lavra
On 10/25/2012 08:30 AM, Rajanikanth H.V wrote: > From: "Rajanikanth H.V" > > This patch adds device tree support for ab8500-charger > driver > > Signed-off-by: Rajanikanth H.V [...] > diff --git a/drivers/power/ab8500_charger.c b/drivers/power/ab8500_charger.c > index 78a730c..956943e 100644 >

Re: [PATCH 2/4] mfd: ab8500: add devicetree support for btemp

2012-10-27 Thread Francesco Lavra
On 10/25/2012 08:30 AM, Rajanikanth H.V wrote: > From: "Rajanikanth H.V" > > This patch adds device tree support for > battery-temperature-monitor driver > > Signed-off-by: Rajanikanth H.V > --- > Documentation/devicetree/bindings/mfd/ab8500.txt |6 ++ > .../bindings/power_supply/ab8500/

Re: [PATCH 1/4] mfd: ab8500: add devicetree support for fuelgauge

2012-10-27 Thread Francesco Lavra
On 10/25/2012 08:30 AM, Rajanikanth H.V wrote: > From: "Rajanikanth H.V" > > - This patch adds device tree support for fuelgauge driver > - optimize bm devices platform_data usage and of_probe(...) > Note: of_probe() routine for battery managed devices is made > common across all bm drivers.

Re: [PATCH V2 5/6] Thermal: Add ST-Ericsson DB8500 thermal driver.

2012-10-27 Thread Francesco Lavra
On Thu Oct 25 11:13:59 2012, Hongbo Zhang wrote: > From: "hongbo.zhang" > > This diver is based on the thermal management framework in thermal_sys.c. A > thermal zone device is created with the trip points to which cooling devices > can be bound, the current cooling device is cpufreq, e.g. CPU fr

Re: [PATCH V2 4/6] Thermal: Remove the cooling_cpufreq_list.

2012-10-26 Thread Francesco Lavra
dy at this moment. What's more, there is no need to > maintain > such a list, we can get cpufreq_cooling_device instance by the private > thermal_cooling_device.devdata. > > Signed-off-by: hongbo.zhang FWIW, Reviewed-by: Francesco Lavra

Re: [PATCH V2 4/6] Thermal: Remove the cooling_cpufreq_list

2012-10-25 Thread Francesco Lavra
Hi, Hongbo Zhang wrote: > Problem of using this list is that the cpufreq_get_max_state callback will be > called when register cooling device by thermal_cooling_device_register, but > this list isn't ready at this moment. What's more, there is no need to > maintain > such a list, we can get cpufre

Re: [PATCH] mfd: ab8500: add devicetree support for fuelgauge

2012-10-23 Thread Francesco Lavra
Hi, On 10/23/2012 11:20 AM, Rajanikanth HV wrote: >>> diff --git a/drivers/power/ab8500_fg.c b/drivers/power/ab8500_fg.c >>> index bf02225..ff64dd4 100644 >>> --- a/drivers/power/ab8500_fg.c >>> +++ b/drivers/power/ab8500_fg.c >>> @@ -22,15 +22,16 @@ > [...] >>> >>> #define MILLI_TO_MICRO

Re: [PATCH 1/5] Thermal: do bind operation after thermal zone or cooling device register returns.

2012-10-23 Thread Francesco Lavra
Hi, On 10/23/2012 10:23 AM, Hongbo Zhang wrote: > Hi Francesco, > I found out more points about this issue. > > [1] > cdev should be ready when get_max_state callback be called, otherwise > parameter cdev is useless, imagine there may be cases that > get_max_state call back is shared by more than

Re: [PATCH 5/5] Thermal: Add ST-Ericsson db8500 thermal dirver.

2012-10-22 Thread Francesco Lavra
On 10/22/2012 02:02 PM, Hongbo Zhang wrote: [...] >>> +static irqreturn_t prcmu_low_irq_handler(int irq, void *irq_data) >>> +{ >>> + struct db8500_thermal_zone *pzone = irq_data; >>> + struct db8500_thsens_platform_data *ptrips; >>> + unsigned long next_low, next_high; >>> + unsign

Re: [PATCH 5/5] Thermal: Add ST-Ericsson db8500 thermal dirver.

2012-10-21 Thread Francesco Lavra
Hi Hongbo, On 10/16/2012 01:44 PM, hongbo.zhang wrote: > From: "hongbo.zhang" > > This diver is based on the thermal management framework in thermal_sys.c. > A thermal zone device is created with the trip points to which cooling > devices can be bound, the current cooling device is cpufreq, e.g.

Re: [PATCH 1/5] Thermal: do bind operation after thermal zone or cooling device register returns.

2012-10-21 Thread Francesco Lavra
Hi, On 10/16/2012 01:44 PM, hongbo.zhang wrote: > From: "hongbo.zhang" > > In the previous bind function, cdev->get_max_state(cdev, &max_state) is called > before the registration function finishes, but at this moment, the parameter > cdev at thermal driver layer isn't ready--it will get ready o

Re: [PATCH] mfd: ab8500: add devicetree support for fuelgauge

2012-10-20 Thread Francesco Lavra
Hi Rajanikanth, On 10/16/2012 05:36 AM, Rajanikanth H.V wrote: > From: "Rajanikanth H.V" > > - This patch adds device tree support for fuelgauge driver > - optimize bm devices platform_data usage and of_probe(...) > Note: of_probe() routine for battery managed devices is made > common across

Re: [PATCH 1/4] mfd: ab8500: add devicetree support for fuelgauge

2012-10-06 Thread Francesco Lavra
Hi, On 10/01/2012 06:08 AM, Rajanikanth H.V wrote: > From: "Rajanikanth H.V" > > - This patch adds device tree support for fuelguage driver > - optimize bm devices platform_data usage and of_probe(...) > Note: of_probe() routine for battery managed devices is made > common across all bm driv

Re: [PATCH 4/4] cpuidle - support multiple drivers

2012-09-29 Thread Francesco Lavra
Hi, On 09/25/2012 12:43 AM, Daniel Lezcano wrote: ... > diff --git a/drivers/cpuidle/sysfs.c b/drivers/cpuidle/sysfs.c > index 5f809e3..2596422 100644 > --- a/drivers/cpuidle/sysfs.c > +++ b/drivers/cpuidle/sysfs.c > @@ -43,21 +43,46 @@ out: > return i; > } > > +struct cbarg { > + cha

Re: mfd: Implement devicetree support for AB8500 Btemp

2012-09-15 Thread Francesco Lavra
On 09/10/2012 01:21 PM, Rajanikanth HV wrote: ... > -static int __devinit ab8500_btemp_probe(struct platform_device *pdev) > +static int __devinit > +btemp_of_probe(struct device *dev, > + struct device_node *np, > + struct abx500_bm_plat_data *bm_pdata) > { > - int irq

Re: [PATCH] mfd: Implement devicetree support for AB8500 fg

2012-09-15 Thread Francesco Lavra
Hi, On 09/10/2012 11:44 AM, Rajanikanth HV wrote: ... > +static int __devinit > +fg_of_probe(struct device *dev, > + struct device_node *np, > + struct abx500_bm_plat_data *bm_pdata) > +{ > + u8 val; > + u32 pval; > + int i; > + int ext_ther

Re: [RFC PATCH v7] media: add v4l2 subdev driver for S5K4ECGX sensor

2012-09-12 Thread Francesco Lavra
Hi Sangwook, two remarks from my review on September 9th haven't been addressed. I believe those remarks are correct, but please let me know if I'm missing something. See below. On 09/12/2012 01:26 PM, Sangwook Lee wrote: > +static int s5k4ecgx_s_power(struct v4l2_subdev *sd, int on) > +{ > +

Re: [RFC PATCH v6] media: add v4l2 subdev driver for S5K4ECGX sensor

2012-09-10 Thread Francesco Lavra
Hi, On 09/10/2012 05:04 PM, Sylwester Nawrocki wrote: > Hi, > > On 09/09/2012 06:01 PM, Francesco Lavra wrote: >>> +static int s5k4ecgx_load_firmware(struct v4l2_subdev *sd) >>> +{ >>> + const struct firmware *fw; >>> + int err, i

Re: [RFC PATCH v6] media: add v4l2 subdev driver for S5K4ECGX sensor

2012-09-09 Thread Francesco Lavra
Hi, I'm going to report the (few) things which are also present in Sylwester's tree. On 09/06/2012 05:08 PM, Sangwook Lee wrote: > This patch adds driver for S5K4ECGX sensor with embedded ISP SoC, > S5K4ECGX, which is a 5M CMOS Image sensor from Samsung > The driver implements preview mode of the

Re: [PATCH 2/2] Thermal: Add ST-Ericsson db8500 thermal dirver.

2012-08-31 Thread Francesco Lavra
On Fri, Aug 31, 2012 at 12:05 PM, Hongbo Zhang wrote: >> > +/* Local function to create cpufreq clip table */ >> > +static int cpufreq_table_create(struct platform_device *pdev, >> > + struct freq_clip_table **freq_tab, int *num_freq) >> > +{ >> > + struct cpufreq_frequency_tab

Re: [PATCH 2/2] Thermal: Add ST-Ericsson db8500 thermal dirver.

2012-08-31 Thread Francesco Lavra
Hi, On Fri, Aug 10, 2012 at 1:20 PM, hongbo.zhang wrote: > From: "hongbo.zhang" > > This diver is based on the thermal management framework in thermal_sys.c. > A thermal zone device is created with the trip points to which cooling > devices can be binded, the current cooling device is cpufreq, e