Re: [PATCH] usb: gadget: s3c-hsotg: fix kernel panic

2012-03-21 Thread Felipe Balbi
Hi, On Mon, Mar 19, 2012 at 05:52:08PM +0100, Lukasz Majewski wrote: > On Fri, 16 Mar 2012 13:35:20 + > Sangwook Lee wrote: > > > Fix kernel panic from s3c_hsotg_udc_stop. > > if udc_is_newstyle is true, s3c_hsotg_udc_stop should not > > call disconnect, unbind. > > > > As running rmmod g_ma

Re: Adding USB charge current property in the Linux Battery core

2011-11-09 Thread Felipe Balbi
Hi, On Wed, Nov 09, 2011 at 12:30:19PM +, Ashish Jangam wrote: > > > > On Wed, Nov 09, 2011 at 01:43:37PM +0530, ashishj3 wrote: > > > > > For a better performance in USB charging operation, the DA9052/53 > > > > charging > > > > > current can be configured in accordance with the USB host curr

Re: Adding USB charge current property in the Linux Battery core

2011-11-09 Thread Felipe Balbi
On Wed, Nov 09, 2011 at 12:13:14PM +, Ashish Jangam wrote: > > > -Original Message- > > From: Felipe Balbi [mailto:ba...@ti.com] > > Sent: Wednesday, November 09, 2011 1:50 PM > > To: Ashish Jangam > > Cc: linaro-dev@lists.linaro.org; linux-ker...@v

Re: Adding USB charge current property in the Linux Battery core

2011-11-09 Thread Felipe Balbi
Hi, On Wed, Nov 09, 2011 at 01:43:37PM +0530, ashishj3 wrote: > For a better performance in USB charging operation, the DA9052/53 charging > current can be configured in accordance with the USB host current > delivering capacity (known through USB drivers negotiation). > > To implement this usef

Re: [PATCH v3] usb: musb: ux500: optimize DMA callback routine

2011-08-22 Thread Felipe Balbi
Hi, On Wed, Aug 17, 2011 at 11:03:40AM +0200, Per Forlin wrote: > From: Per Forlin > > Skip the use of work queue and call musb_dma_completion() directly from > DMA callback context. > > Here follows measurements on a Snowball board with ondemand governor active. > > Performance using work que

Re: [PATCH v6] usb: gadget: storage: make FSG_NUM_BUFFERS variable size

2011-08-22 Thread Felipe Balbi
Hi, On Fri, Aug 19, 2011 at 09:21:27PM +0200, Per Forlin wrote: > FSG_NUM_BUFFERS is set to 2 as default. > Usually 2 buffers are enough to establish a good buffering pipeline. > The number may be increased in order to compensate a for bursty VFS > behaviour. > > Here follows a description of sys

Re: [PATCH v4] usb: gadget: storage_common: make FSG_NUM_BUFFERS variable size

2011-08-18 Thread Felipe Balbi
Hi, On Thu, Aug 18, 2011 at 11:28:46AM +0200, Per Forlin wrote: > From: Per Forlin > > FSG_NUM_BUFFERS is set to 2 as default. > Usually 2 buffers are enough to establish a good buffering pipeline. > The number may be increased in order to compensate a for bursty VFS > behaviour. > > Here follo

Re: [PATCH v2] usb: musb: ux500: optimize DMA callback routine

2011-08-15 Thread Felipe Balbi
Hi, On Sun, Aug 14, 2011 at 07:50:46PM +0200, Per Forlin wrote: > On 12 August 2011 11:41, Felipe Balbi wrote: > > Hi, > > > > On Mon, Aug 08, 2011 at 01:01:06PM +0200, Per Forlin wrote: > >> From: Per Forlin > >> > >> Skip the use of work qu

Re: [PATCH v2] usb: musb: ux500: optimize DMA callback routine

2011-08-12 Thread Felipe Balbi
Hi, On Mon, Aug 08, 2011 at 01:01:06PM +0200, Per Forlin wrote: > From: Per Forlin > > Skip the use of work queue and call musb_dma_completion() directly from > DMA callback context. > > Here follows measurements on a Snowball board with ondemand governor active. > > Performance using work que

Re: [PATCH v3] usb: gadget: storage_common: make FSG_NUM_BUFFERS variable size

2011-08-12 Thread Felipe Balbi
On Mon, Aug 08, 2011 at 11:43:35PM +0200, Per Forlin wrote: > FSG_NUM_BUFFERS is set to 2 as default. > Usually 2 buffers are enough to establish a good buffering pipeline. > The number may be increased in order to compensate a for bursty VFS > behaviour. > > Here follows a description of system t

Re: [PATCH v3] usb: gadget: storage_common: make FSG_NUM_BUFFERS variable size

2011-08-09 Thread Felipe Balbi
Hi, On Tue, Aug 09, 2011 at 09:57:19AM -0400, Alan Stern wrote: > On Mon, 8 Aug 2011, Per Forlin wrote: > > > FSG_NUM_BUFFERS is set to 2 as default. > > Usually 2 buffers are enough to establish a good buffering pipeline. > > The number may be increased in order to compensate a for bursty VFS >

Re: [PATCH] usb: musb: ux500: optimize DMA callback routine

2011-08-08 Thread Felipe Balbi
Hi, On Mon, Aug 08, 2011 at 10:32:38AM +0200, Per Forlin wrote: [snip] > -/* Work function invoked from DMA callback to handle rx transfers. */ > -static void ux500_rx_work(struct work_struct *data) > +void ux500_dma_callback(void *private_data) > { > - struct ux500_dma_channel *ux500_chann

Re: [PATCH] usb: musb: ux500: set dma config for both src and dst

2011-08-03 Thread Felipe Balbi
On Wed, Aug 03, 2011 at 03:53:10PM +0200, Per Forlin wrote: > On 3 August 2011 15:31, Felipe Balbi wrote: > > On Tue, Aug 02, 2011 at 05:33:39PM +0200, Per Forlin wrote: > >> From: Per Forlin > >> > >> The dma driver requires both src and dst to be set. >

Re: [PATCH] usb: musb: cppi: fix build errors due to DBG and missing musb variable

2011-08-03 Thread Felipe Balbi
Hi, On Wed, Aug 03, 2011 at 03:39:15PM +0200, Per Forlin wrote: > From: Per Forlin > > Replace DBG with dev_dbg add fix invalid access of musb->controller. > With this patch cppi_dma builds successfully. > > Signed-off-by: Per Forlin > Cc: applied, thanks -- balbi signature.asc Descripti

Re: [PATCH] usb: musb: ux500: set dma config for both src and dst

2011-08-03 Thread Felipe Balbi
On Tue, Aug 02, 2011 at 05:33:39PM +0200, Per Forlin wrote: > From: Per Forlin > > The dma driver requires both src and dst to be set. > This fix is needed in order to run gadget mass storage. > Patch is verified on snowball. > > Signed-off-by: Per Forlin should this go for stable too ?? --

Re: [PATCH] usb: musb: ux500: replace missing DBG with dev_dbg

2011-08-03 Thread Felipe Balbi
On Wed, Aug 03, 2011 at 03:27:28PM +0200, Per Förlin wrote: > On 08/03/2011 03:17 PM, Felipe Balbi wrote: > > On Wed, Aug 03, 2011 at 02:22:17PM +0200, Per Forlin wrote: > >> From: Per Forlin > >> > >> ux500_dma.c fail to compile becase DBG has been removed f

Re: [PATCH] usb: musb: ux500: replace missing DBG with dev_dbg

2011-08-03 Thread Felipe Balbi
On Wed, Aug 03, 2011 at 02:22:17PM +0200, Per Forlin wrote: > From: Per Forlin > > ux500_dma.c fail to compile becase DBG has been removed from musb_debug. > Use dev_dbg for all prints. > > Signed-off-by: Per Forlin > Acked-by: Mian Yousaf Kaukab applied, thanks. Let me know if this should go

Re: [PATCH] usb: musb: ux500: replace missing DBG with dev_dbg

2011-08-03 Thread Felipe Balbi
Hi, On Wed, Aug 03, 2011 at 02:22:17PM +0200, Per Forlin wrote: > From: Per Forlin > > ux500_dma.c fail to compile becase DBG has been removed from musb_debug. > Use dev_dbg for all prints. > > Signed-off-by: Per Forlin > Acked-by: Mian Yousaf Kaukab does this affect any stable release ? --

Re: [PATCH] usb: musb: ux500: set dma config for both src and dst

2011-08-03 Thread Felipe Balbi
On Tue, Aug 02, 2011 at 05:33:39PM +0200, Per Forlin wrote: > From: Per Forlin > > The dma driver requires both src and dst to be set. > This fix is needed in order to run gadget mass storage. > Patch is verified on snowball. > > Signed-off-by: Per Forlin applied, thanks -- balbi signature