Re: [Powertop] [PATCH v2 1/2] Updates to support Android platform

2012-09-24 Thread Arjan van de Ven
On 9/25/2012 7:34 AM, Rajagopal Venkat wrote: >> On 09/24/2012 06:28 AM, Rajagopal Venkat wrote: >>> >>> This patch adds following minor changes to prepare powertop >>> to support Android platform. >>> >>> - Add missing HAVE_CONFIG_H conditional check. >>> - remove un-used ethtool_cmd_speed_set and

Re: [Powertop] [PATCH v2 1/2] Updates to support Android platform

2012-09-24 Thread Arjan van de Ven
On 9/25/2012 7:34 AM, Rajagopal Venkat wrote: >> On 09/24/2012 06:28 AM, Rajagopal Venkat wrote: >>> >>> This patch adds following minor changes to prepare powertop >>> to support Android platform. >>> >>> - Add missing HAVE_CONFIG_H conditional check. >>> - remove un-used ethtool_cmd_speed_set and

Re: [Powertop] [PATCH] Fix timer and work perf events timestamp tracing

2012-09-06 Thread Arjan van de Ven
On 9/6/2012 6:42 AM, Rajagopal Venkat wrote: > (305177)(4380506988525) (4380506988525) > (4380507324219) (4380507019042) (0)<<< > (4380507354736) (4380596923827) (4380596893310) > (4380507415771) (4380606964111) (4380606903076)

Re: [Powertop] [PATCH] Fix timer and work perf events timestamp tracing

2012-09-05 Thread Arjan van de Ven
On 9/5/2012 10:45 AM, Rajagopal Venkat wrote: > On 5 September 2012 22:52, Arjan van de Ven wrote: >> On 9/5/2012 10:19 AM, Rajagopal Venkat wrote: >>> On 5 September 2012 22:39, Arjan van de Ven wrote: >>>> On 9/5/2012 9:56 AM, Rajagopal Venkat wrote: >

Re: [Powertop] [PATCH] Fix timer and work perf events timestamp tracing

2012-09-05 Thread Arjan van de Ven
On 9/5/2012 10:19 AM, Rajagopal Venkat wrote: > On 5 September 2012 22:39, Arjan van de Ven wrote: >> On 9/5/2012 9:56 AM, Rajagopal Venkat wrote: >>>> measure1: >>>> ev3.start >>>> ev1.end <<<<< >>> >>> evX.end

Re: [Powertop] [PATCH] Fix timer and work perf events timestamp tracing

2012-09-05 Thread Arjan van de Ven
On 9/5/2012 9:56 AM, Rajagopal Venkat wrote: >> measure1: >> ev3.start >> ev1.end < > > evX.end < > These events are causing numbers to go wrong. but out of a 20 second window.. this is a tiny tiny window... if you see 100.1% I'd buy this reasoning. but you're seeing much more than that

Re: [Powertop] [PATCH v2] conditionally disable pci if not supported

2012-06-25 Thread Arjan van de Ven
On 6/25/2012 9:00 AM, Rajagopal Venkat wrote: > > diff --git a/src/lib.h b/src/lib.h > index 588c023..d354151 100644 > --- a/src/lib.h > +++ b/src/lib.h > @@ -30,6 +30,10 @@ > #endif > #include > > +#if HAVE_CONFIG_H > +#include "config.h" > +#endif > + > #ifndef DISABLE_I18N > #define

Re: [Powertop] [PATCH] conditionally disable pci support on ARM platforms

2012-06-22 Thread Arjan van de Ven
On 6/22/2012 11:42 AM, Rajagopal Venkat wrote: > +case "$host" in > +arm*) > + AC_DEFINE([HAVE_NO_PCI],[1],[Define if host platform is ARM]) > + ;; > +*) > + PKG_CHECK_MODULES([PCIUTILS], [libpci],[],[ > + AC_SEARCH_LIBS([pci_get_dev], [pci], [], AC_MSG_ERROR([libpci > is r

Re: [PATCH powertop2.0] Modification to fix the removal of lock_depth field

2011-06-23 Thread Arjan van de Ven
On 6/22/2011 10:12 PM, Amit Daniel Kachhap wrote: lock_depth field is removed from the power frequency events in the new linux kernel(2.6.38 onwards). So this creates issue to retrieve the lower members of the trace data. To fix this problem 2 separate structures are created and their use depends