Re: [PATCH PM-QA v2 13/25] Rewrite logic to check for sampling_rate

2015-02-02 Thread Amit Kucheria
On Tue, Feb 3, 2015 at 3:14 AM, Lisa Nguyen wrote: > On 1 February 2015 at 22:00, Amit Kucheria wrote: >> On Mon, Feb 2, 2015 at 7:34 AM, Lisa Nguyen wrote: >>> Set the sampling_rate to zero if the sampling_rate attribute cannot >>> be found in either directories listed in the if condition. This

Re: [PATCH PM-QA 0/4] Minor sanity scripts adjustments

2015-02-02 Thread Amit Kucheria
On Tue, Feb 3, 2015 at 6:52 AM, Lisa Nguyen wrote: > My previous patchset[1] had too many types of patches (cleanups, > bug fixes, additions, etc.), so it will be broken up much further > to make it easy on the eyes :) > > This particular set focuses on renaming existing sanity scripts, > adding a

[PATCH PM-QA 4/4] Android: Update makefiles with new test numbers

2015-02-02 Thread Lisa Nguyen
Update the Android makefiles to include new test numbers to run cputopology_sanity.sh, cpuhotplug_00.sh (formerly 1_sanity_check.sh), and cpuhotplug_99.sh (formerly z_sanity_check.sh). Signed-off-by: Lisa Nguyen --- cpuhotplug/Android.mk |4 +--- cputopology/Android.mk |2 +- 2 files ch

[PATCH PM-QA 3/4] cputopology: Add cputopology_sanity.sh

2015-02-02 Thread Lisa Nguyen
Every test module has a sanity script. Add one for cputopology to check for topology entries for all cpus. Signed-off-by: Lisa Nguyen --- cputopology/cputopology_sanity.sh | 49 cputopology/cputopology_sanity.txt |1 + 2 files changed, 50 insertions(+)

[PATCH PM-QA 2/4] cpuhotplug: Rename z_sanity_check files to cpuhotplug_99 files

2015-02-02 Thread Lisa Nguyen
z_sanity_check.sh doesn't have a meaningful name. Rename it to cpuhotplug_99 as the last script to run to see if all cpus are back online after running previous cpuhotplug scripts. Signed-off-by: Lisa Nguyen --- cpuhotplug/cpuhotplug_99.sh | 40 cpuho

[PATCH PM-QA 1/4] cpuhotplug: Rename 1_sanity_check files to cpuhotplug_00 files

2015-02-02 Thread Lisa Nguyen
1_sanity_check.sh script didn't have a meaningful name. Rename it to cpuhotplug_00 as the first script to check if all cpus are online before the other cpuhotplug scripts begin. Signed-off-by: Lisa Nguyen --- cpuhotplug/1_sanity_check.sh | 40 cpuhotpl

[PATCH PM-QA 0/4] Minor sanity scripts adjustments

2015-02-02 Thread Lisa Nguyen
My previous patchset[1] had too many types of patches (cleanups, bug fixes, additions, etc.), so it will be broken up much further to make it easy on the eyes :) This particular set focuses on renaming existing sanity scripts, adding a new one to the cputopology test module, and if the changes l

Re: [PATCH PM-QA v2 13/25] Rewrite logic to check for sampling_rate

2015-02-02 Thread Lisa Nguyen
On 1 February 2015 at 22:00, Amit Kucheria wrote: > On Mon, Feb 2, 2015 at 7:34 AM, Lisa Nguyen wrote: >> Set the sampling_rate to zero if the sampling_rate attribute cannot >> be found in either directories listed in the if condition. This will >> also resolve minor bugs where the sampling_rate

[ACTIVITY] LAVA team weekly report, week 6

2015-02-02 Thread lava-team
Team Work Logged # tyler-baker Progress # * LAVA-1511 - Upstream Kernel CI * LAVA-1830 - Implement file upload API in lava-ci (80.0%) * Had a quick discussion with Milo, who pointed out the example was incorrect. After fixing up the code, the single file uplo

Re: [PATCH PM-QA v2 24/25] cpufreq: Rewrite logic to check if powersave is supported

2015-02-02 Thread Lisa Nguyen
On 1 February 2015 at 22:03, Amit Kucheria wrote: > On Mon, Feb 2, 2015 at 7:34 AM, Lisa Nguyen wrote: >> With this new change, the final result for the cpufreq_09 >> script will always show up and be counted in LAVA. > > Why? I'll look into this in detail. It was a quick hack since the cpufreq_

Re: [PATCH PM-QA v2 23/25] cpufreq: Check to see if scaling_available_governors is available

2015-02-02 Thread Lisa Nguyen
On 1 February 2015 at 22:02, Amit Kucheria wrote: > On Mon, Feb 2, 2015 at 7:34 AM, Lisa Nguyen wrote: >> Before searching for specific governors, check to see if the >> scaling_available_governors attribute exists first. It is to add >> more error handling. > > This doesn't seem to handle intera

Re: [PATCH PM-QA v2 09/25] Fix the syntax to call C programs

2015-02-02 Thread Lisa Nguyen
On 1 February 2015 at 21:44, Amit Kucheria wrote: > On Mon, Feb 2, 2015 at 7:34 AM, Lisa Nguyen wrote: >> In PM-QA, there are programs written in C (e.g. cpuidle_killer, >> uevent_reader) that run in the background while some scripts are >> being. >> >> However, remove the extra slash and period

Re: [PATCH PM-QA v2 00/25] Removing bashisms and other cleanups

2015-02-02 Thread Lisa Nguyen
On 1 February 2015 at 22:16, Amit Kucheria wrote: > On Mon, Feb 2, 2015 at 11:40 AM, Amit Kucheria > wrote: >> Hi Lisa, >> >> On Mon, Feb 2, 2015 at 7:34 AM, Lisa Nguyen wrote: >>> Changes in v2: >>> - Reorganized previous patchset and recreated patches based on >>> logical change >>> - Rewritt