Re: [PATCH V2 5/6] USB: OHCI: make ohci-at91 a separate driver

2013-06-22 Thread Manjunath Goudar
On 23 June 2013 00:38, Alan Stern wrote: > On Sun, 23 Jun 2013, Manjunath Goudar wrote: > > > > As a general rule, you should never change code that you don't > > > understand. Do you _know_ that it will be safe to call ohci_setup() or > > > ohci_restart() at this point? > > > > > > > > From Dav

Re: [PATCH V2 5/6] USB: OHCI: make ohci-at91 a separate driver

2013-06-22 Thread Alan Stern
On Sun, 23 Jun 2013, Manjunath Goudar wrote: > > As a general rule, you should never change code that you don't > > understand. Do you _know_ that it will be safe to call ohci_setup() or > > ohci_restart() at this point? > > > > > From David Brownell comment I am understanding,instead of calling

Re: [PATCH V2 5/6] USB: OHCI: make ohci-at91 a separate driver

2013-06-22 Thread Manjunath Goudar
On 21 June 2013 22:03, Alan Stern wrote: > On Fri, 21 Jun 2013, Manjunath Goudar wrote: > > > On 20 June 2013 22:23, Alan Stern wrote: > > > > > On Thu, 20 Jun 2013, Manjunath Goudar wrote: > > > > > > > > > @@ -686,7 +631,7 @@ ohci_hcd_at91_drv_suspend(struct > platform_device > > > > > *pdev,