Re: [PATCH v2 10/23] xen/arm: compile and run xenbus

2012-08-08 Thread Daniel De Graaf
On 08/08/2012 12:51 PM, Stefano Stabellini wrote: > On Tue, 7 Aug 2012, Daniel De Graaf wrote: >> On 08/07/2012 02:21 PM, Konrad Rzeszutek Wilk wrote: >>> On Mon, Aug 06, 2012 at 03:27:13PM +0100, Stefano Stabellini wrote: bind_evtchn_to_irqhandler can legitimately return 0 (irq 0): it is not

Re: [PATCH v2 10/23] xen/arm: compile and run xenbus

2012-08-08 Thread Daniel De Graaf
On 08/08/2012 01:19 PM, Stefano Stabellini wrote: > On Wed, 8 Aug 2012, Daniel De Graaf wrote: >> On 08/08/2012 12:51 PM, Stefano Stabellini wrote: >>> On Tue, 7 Aug 2012, Daniel De Graaf wrote: On 08/07/2012 02:21 PM, Konrad Rzeszutek Wilk wrote: > On Mon, Aug 06, 2012 at 03:27:13PM +0100

Re: [PATCH v2 15/23] xen/arm: receive Xen events on ARM

2012-08-08 Thread Stefano Stabellini
On Tue, 7 Aug 2012, Konrad Rzeszutek Wilk wrote: > On Mon, Aug 06, 2012 at 03:27:18PM +0100, Stefano Stabellini wrote: > > Compile events.c on ARM. > > Parse, map and enable the IRQ to get event notifications from the device > > tree (node "/xen"). > > > > Signed-off-by: Stefano Stabellini > > --

Re: [PATCH v2 10/23] xen/arm: compile and run xenbus

2012-08-08 Thread Stefano Stabellini
On Wed, 8 Aug 2012, Daniel De Graaf wrote: > On 08/08/2012 01:19 PM, Stefano Stabellini wrote: > > On Wed, 8 Aug 2012, Daniel De Graaf wrote: > >> On 08/08/2012 12:51 PM, Stefano Stabellini wrote: > >>> On Tue, 7 Aug 2012, Daniel De Graaf wrote: > On 08/07/2012 02:21 PM, Konrad Rzeszutek Wilk

Re: [PATCH v2 21/23] xen: update xen_add_to_physmap interface

2012-08-08 Thread Stefano Stabellini
On Tue, 7 Aug 2012, Konrad Rzeszutek Wilk wrote: > On Mon, Aug 06, 2012 at 03:27:24PM +0100, Stefano Stabellini wrote: > > Update struct xen_add_to_physmap to be in sync with Xen's version of the > > structure. > > The size field was introduced by: > > > > changeset: 24164:707d27fe03e7 > > user:

Re: [PATCH v2 10/23] xen/arm: compile and run xenbus

2012-08-08 Thread Stefano Stabellini
On Wed, 8 Aug 2012, Daniel De Graaf wrote: > On 08/08/2012 12:51 PM, Stefano Stabellini wrote: > > On Tue, 7 Aug 2012, Daniel De Graaf wrote: > >> On 08/07/2012 02:21 PM, Konrad Rzeszutek Wilk wrote: > >>> On Mon, Aug 06, 2012 at 03:27:13PM +0100, Stefano Stabellini wrote: > bind_evtchn_to_irq

Re: [PATCH v2 10/23] xen/arm: compile and run xenbus

2012-08-08 Thread Stefano Stabellini
On Tue, 7 Aug 2012, Daniel De Graaf wrote: > On 08/07/2012 02:21 PM, Konrad Rzeszutek Wilk wrote: > > On Mon, Aug 06, 2012 at 03:27:13PM +0100, Stefano Stabellini wrote: > >> bind_evtchn_to_irqhandler can legitimately return 0 (irq 0): it is not > >> an error. > >> > >> If Linux is running as an HV

Re: [PATCH v2 09/23] xen/arm: Introduce xen_ulong_t for unsigned long

2012-08-08 Thread Stefano Stabellini
On Tue, 7 Aug 2012, Konrad Rzeszutek Wilk wrote: > On Mon, Aug 06, 2012 at 03:27:12PM +0100, Stefano Stabellini wrote: > > All the original Xen headers have xen_ulong_t as unsigned long type, however > > when they have been imported in Linux, xen_ulong_t has been replaced with > > unsigned long. Th

Re: [PATCH v2 06/23] xen: missing includes

2012-08-08 Thread Stefano Stabellini
On Tue, 7 Aug 2012, Konrad Rzeszutek Wilk wrote: > On Mon, Aug 06, 2012 at 03:27:09PM +0100, Stefano Stabellini wrote: > > Changes in v2: > > - remove pvclock hack; > > - remove include linux/types.h from xen/interface/xen.h. > > I think I can take in my tree now right by itself right? Or do > you

Re: [PATCH v2 03/23] xen/arm: page.h definitions

2012-08-08 Thread Stefano Stabellini
On Tue, 7 Aug 2012, Konrad Rzeszutek Wilk wrote: > On Mon, Aug 06, 2012 at 03:27:06PM +0100, Stefano Stabellini wrote: > > ARM Xen guests always use paging in hardware, like PV on HVM guests in > > the X86 world. > > > > Signed-off-by: Stefano Stabellini > > Ack.. with one nitpick > > > +/* XXX

Re: [PATCH v2 01/23] arm: initial Xen support

2012-08-08 Thread Stefano Stabellini
On Tue, 7 Aug 2012, Konrad Rzeszutek Wilk wrote: > On Mon, Aug 06, 2012 at 03:27:04PM +0100, Stefano Stabellini wrote: > > - Basic hypervisor.h and interface.h definitions. > > - Skeleton enlighten.c, set xen_start_info to an empty struct. > > - Make xen_initial_domain dependent on the SIF_PRIVILIG

Re: [Xen-devel] [PATCH v2 07/23] xen/arm: Xen detection and shared_info page mapping

2012-08-08 Thread Stefano Stabellini
On Mon, 6 Aug 2012, David Vrabel wrote: > On 06/08/12 15:27, Stefano Stabellini wrote: > > Check for a "/xen" node in the device tree, if it is present set > > xen_domain_type to XEN_HVM_DOMAIN and continue initialization. > > > > Map the real shared info page using XENMEM_add_to_physmap with > >

Re: [PATCH v2 02/23] xen/arm: hypercalls

2012-08-08 Thread Dave Martin
On Mon, Aug 06, 2012 at 03:27:05PM +0100, Stefano Stabellini wrote: > Use r12 to pass the hypercall number to the hypervisor. > > We need a register to pass the hypercall number because we might not > know it at compile time and HVC only takes an immediate argument. > > Among the available regist