Re: [Xen-devel] [PATCH 10/24] xen: do not compile manage, balloon, pci, acpi and cpu_hotplug on ARM

2012-07-27 Thread Stefano Stabellini
On Fri, 27 Jul 2012, Jan Beulich wrote: > >>> On 26.07.12 at 17:33, Stefano Stabellini > >>> wrote: > > --- a/drivers/xen/Makefile > > +++ b/drivers/xen/Makefile > > @@ -1,11 +1,15 @@ > > -obj-y += grant-table.o features.o events.o manage.o balloon.o > > +ifneq ($(CONFIG_ARM),y) > > +obj-y

Re: [Xen-devel] [PATCH 06/24] xen: missing includes

2012-07-27 Thread Stefano Stabellini
On Fri, 27 Jul 2012, Jan Beulich wrote: > >>> On 26.07.12 at 17:33, Stefano Stabellini > >>> wrote: > > --- a/include/xen/interface/xen.h > > +++ b/include/xen/interface/xen.h > > @@ -10,7 +10,10 @@ > > #define __XEN_PUBLIC_XEN_H__ > > > > #include > > +#include > > +#ifdef CONFIG_X86 > >

Re: [PATCH 18/24] xen/arm: compile blkfront and blkback

2012-07-27 Thread Stefano Stabellini
On Fri, 27 Jul 2012, Ian Campbell wrote: > On Thu, 2012-07-26 at 16:34 +0100, Stefano Stabellini wrote: > > > > +#define XEN_IO_PROTO_ABI_ARM"arm-abi" > > I wonder if we ought to call this arm-aarch32-abi or something? So aarch64 has just been renamed to arm64 and you want to rename arm

Re: [PATCH 12/24] xen/arm: Introduce xen_guest_init

2012-07-27 Thread Ian Campbell
On Fri, 2012-07-27 at 16:54 +0100, Stefano Stabellini wrote: > On Fri, 27 Jul 2012, Ian Campbell wrote: > > On Thu, 2012-07-26 at 16:33 +0100, Stefano Stabellini wrote: > > > We used to rely on a core_initcall to initialize Xen on ARM, however > > > core_initcalls are actually called after early co

Re: [PATCH 12/24] xen/arm: Introduce xen_guest_init

2012-07-27 Thread Stefano Stabellini
On Fri, 27 Jul 2012, Ian Campbell wrote: > On Thu, 2012-07-26 at 16:33 +0100, Stefano Stabellini wrote: > > We used to rely on a core_initcall to initialize Xen on ARM, however > > core_initcalls are actually called after early consoles are initialized. > > That means that hvc_xen.c is going to be

Re: [PATCH 07/24] xen/arm: Xen detection and shared_info page mapping

2012-07-27 Thread Ian Campbell
On Fri, 2012-07-27 at 15:48 +0100, Stefano Stabellini wrote: > On Fri, 27 Jul 2012, Ian Campbell wrote: > > On Thu, 2012-07-26 at 16:33 +0100, Stefano Stabellini wrote: > > > Check for a "/xen" node in the device tree, if it is present set > > > xen_domain_type to XEN_HVM_DOMAIN and continue initia

Re: [Xen-devel] [PATCH 02/24] xen/arm: hypercalls

2012-07-27 Thread Ian Campbell
On Fri, 2012-07-27 at 15:21 +0100, Russell King - ARM Linux wrote: > On Fri, Jul 27, 2012 at 02:02:18PM +0100, Stefano Stabellini wrote: > > > > > +/** > > > > > + * hypercall.h > > > > > + * > > > > > + * Linux-specific hy

Re: [Xen-devel] [PATCH 02/24] xen/arm: hypercalls

2012-07-27 Thread Ian Campbell
On Fri, 2012-07-27 at 14:02 +0100, Stefano Stabellini wrote: > On Fri, 27 Jul 2012, Ian Campbell wrote: > > On Thu, 2012-07-26 at 17:33 +0100, Konrad Rzeszutek Wilk wrote: > > > On Thu, Jul 26, 2012 at 04:33:44PM +0100, Stefano Stabellini wrote: > > > > Use r12 to pass the hypercall number to the h

Re: [PATCH 13/24] xen/arm: get privilege status

2012-07-27 Thread Ian Campbell
On Fri, 2012-07-27 at 15:25 +0100, Stefano Stabellini wrote: > On Fri, 27 Jul 2012, Ian Campbell wrote: > > On Thu, 2012-07-26 at 16:33 +0100, Stefano Stabellini wrote: > > > Use Xen features to figure out if we are privileged. > > > > > > XENFEAT_dom0 was introduced by 23735 in xen-unstable.hg. >

Re: [Xen-devel] [PATCH 02/24] xen/arm: hypercalls

2012-07-27 Thread Russell King - ARM Linux
On Fri, Jul 27, 2012 at 03:39:31PM +0100, Ian Campbell wrote: > On Fri, 2012-07-27 at 15:21 +0100, Russell King - ARM Linux wrote: > > On Fri, Jul 27, 2012 at 02:02:18PM +0100, Stefano Stabellini wrote: > > > > > > +/** > >

Re: [PATCH 07/24] xen/arm: Xen detection and shared_info page mapping

2012-07-27 Thread Stefano Stabellini
On Fri, 27 Jul 2012, Ian Campbell wrote: > On Thu, 2012-07-26 at 16:33 +0100, Stefano Stabellini wrote: > > Check for a "/xen" node in the device tree, if it is present set > > xen_domain_type to XEN_HVM_DOMAIN and continue initialization. > > > > Map the real shared info page using XENMEM_add_to_

Re: [Xen-devel] [PATCH 02/24] xen/arm: hypercalls

2012-07-27 Thread Stefano Stabellini
On Fri, 27 Jul 2012, Russell King - ARM Linux wrote: > On Fri, Jul 27, 2012 at 02:02:18PM +0100, Stefano Stabellini wrote: > > > > > +/** > > > > > + * hypercall.h > > > > > + * > > > > > + * Linux-specific hypervisor handl

Re: [PATCH 13/24] xen/arm: get privilege status

2012-07-27 Thread Stefano Stabellini
On Fri, 27 Jul 2012, Ian Campbell wrote: > On Thu, 2012-07-26 at 16:33 +0100, Stefano Stabellini wrote: > > Use Xen features to figure out if we are privileged. > > > > XENFEAT_dom0 was introduced by 23735 in xen-unstable.hg. > > > > Signed-off-by: Stefano Stabellini > > --- > > arch/arm/xen/en

Re: [Xen-devel] [PATCH 02/24] xen/arm: hypercalls

2012-07-27 Thread Russell King - ARM Linux
On Fri, Jul 27, 2012 at 02:02:18PM +0100, Stefano Stabellini wrote: > > > > +/** > > > > + * hypercall.h > > > > + * > > > > + * Linux-specific hypervisor handling. > > > > + * > > > > + * Stefano Stabellini , Citrix, 2012

Re: [Xen-devel] [PATCH 17/24] xen: allow privcmd for HVM guests

2012-07-27 Thread Stefano Stabellini
On Fri, 27 Jul 2012, Jan Beulich wrote: > >>> On 26.07.12 at 17:33, Stefano Stabellini > >>> wrote: > > In order for privcmd mmap to work correctly, xen_remap_domain_mfn_range > > needs to be implemented for HVM guests. > > If it is not, mmap is going to fail later on. > > Somehow, for me at lea

Re: [PATCH 02/24] xen/arm: hypercalls

2012-07-27 Thread Stefano Stabellini
On Fri, 27 Jul 2012, Christopher Covington wrote: > On 07/27/2012 05:19 AM, Ian Campbell wrote: > > On Thu, 2012-07-26 at 20:19 +0100, Christopher Covington wrote: > >> Hi Stefano, > >> > >> On 07/26/2012 11:33 AM, Stefano Stabellini wrote: > >>> Use r12 to pass the hypercall number to the hypervis

Re: [Xen-devel] [PATCH 03/24] xen/arm: page.h definitions

2012-07-27 Thread Stefano Stabellini
On Thu, 26 Jul 2012, Konrad Rzeszutek Wilk wrote: > On Thu, Jul 26, 2012 at 04:33:45PM +0100, Stefano Stabellini wrote: > > ARM Xen guests always use paging in hardware, like PV on HVM guests in > > the X86 world. > > Nice, so no dealing with the P2M at all in the guest? Nope ;-) > > Signed-off

Re: [Xen-devel] [PATCH 02/24] xen/arm: hypercalls

2012-07-27 Thread Stefano Stabellini
On Fri, 27 Jul 2012, Ian Campbell wrote: > > > > Should this comment be by 'privcmd_call'? > > > > > > When we add a 5 argument hypercall I suppose we'll see the required > > > push/pop of r4 added to this macro too. > > > > For performance and simplicity I would add a second macro that push/pop

Re: [Xen-devel] [PATCH 02/24] xen/arm: hypercalls

2012-07-27 Thread Stefano Stabellini
On Fri, 27 Jul 2012, Ian Campbell wrote: > On Thu, 2012-07-26 at 17:33 +0100, Konrad Rzeszutek Wilk wrote: > > On Thu, Jul 26, 2012 at 04:33:44PM +0100, Stefano Stabellini wrote: > > > Use r12 to pass the hypercall number to the hypervisor. > > > > > > We need a register to pass the hypercall numb

Re: [PATCH 02/24] xen/arm: hypercalls

2012-07-27 Thread Christopher Covington
On 07/27/2012 05:19 AM, Ian Campbell wrote: > On Thu, 2012-07-26 at 20:19 +0100, Christopher Covington wrote: >> Hi Stefano, >> >> On 07/26/2012 11:33 AM, Stefano Stabellini wrote: >>> Use r12 to pass the hypercall number to the hypervisor. >>> >>> We need a register to pass the hypercall number be

Re: [PATCH 0/5][RFC] Use per cpuidle_device states

2012-07-27 Thread Peter De Schrijver
On Wed, Jul 25, 2012 at 12:45:57PM +0200, Daniel Lezcano wrote: > Since commit 46bcfad7a819bd17ac4e831b04405152d59784ab, > cpuidle: Single/Global registration of idle states > > we have a single registration for the cpuidle states which makes > sense. But now two new architectures are comi

Re: [Xen-devel] [PATCH 01/24] arm: initial Xen support

2012-07-27 Thread Stefano Stabellini
On Thu, 26 Jul 2012, Konrad Rzeszutek Wilk wrote: > On Thu, Jul 26, 2012 at 04:33:43PM +0100, Stefano Stabellini wrote: > > - Basic hypervisor.h and interface.h definitions. > > - Skelethon enlighten.c, set xen_start_info to an empty struct. > > Skeleton > > > - Do not limit xen_initial_domain to

Re: [Xen-devel] [PATCH 02/24] xen/arm: hypercalls

2012-07-27 Thread David Vrabel
On 26/07/12 16:33, Stefano Stabellini wrote: > > + * The hvc ISS is required to be 0xEA1, that is the Xen specific ARM > + * hypercall tag. Is this number, 0xea1, assigned to Xen by some external body? David ___ linaro-dev mailing list linaro-dev@list

Re: [Xen-devel] [PATCH 02/24] xen/arm: hypercalls

2012-07-27 Thread Konrad Rzeszutek Wilk
On Thu, Jul 26, 2012 at 04:33:44PM +0100, Stefano Stabellini wrote: > Use r12 to pass the hypercall number to the hypervisor. > > We need a register to pass the hypercall number because we might not > know it at compile time and HVC only takes an immediate argument. > > Among the available regist

Re: [Xen-devel] [PATCH 01/24] arm: initial Xen support

2012-07-27 Thread Konrad Rzeszutek Wilk
On Thu, Jul 26, 2012 at 04:33:43PM +0100, Stefano Stabellini wrote: > - Basic hypervisor.h and interface.h definitions. > - Skelethon enlighten.c, set xen_start_info to an empty struct. Skeleton > - Do not limit xen_initial_domain to PV guests. Better wording: Make xen_initial_domain dependent o

Re: [Xen-devel] [PATCH 04/24] xen/arm: sync_bitops

2012-07-27 Thread Konrad Rzeszutek Wilk
On Thu, Jul 26, 2012 at 04:33:46PM +0100, Stefano Stabellini wrote: > sync_bitops functions are equivalent to the SMP implementation of the > original functions, independently from CONFIG_SMP being defined. So why can't the code be changed to use that? Is it that the _set_bit, _clear_bit, etc are

Re: [Xen-devel] [PATCH 02/24] xen/arm: hypercalls

2012-07-27 Thread Ian Campbell
On Thu, 2012-07-26 at 17:33 +0100, Konrad Rzeszutek Wilk wrote: > On Thu, Jul 26, 2012 at 04:33:44PM +0100, Stefano Stabellini wrote: > > Use r12 to pass the hypercall number to the hypervisor. > > > > We need a register to pass the hypercall number because we might not > > know it at compile time

Re: [Xen-devel] [PATCH 03/24] xen/arm: page.h definitions

2012-07-27 Thread Konrad Rzeszutek Wilk
On Thu, Jul 26, 2012 at 04:33:45PM +0100, Stefano Stabellini wrote: > ARM Xen guests always use paging in hardware, like PV on HVM guests in > the X86 world. Nice, so no dealing with the P2M at all in the guest? > > Signed-off-by: Stefano Stabellini > --- > arch/arm/include/asm/xen/page.h |

Re: [Xen-devel] [PATCH 02/24] xen/arm: hypercalls

2012-07-27 Thread Ian Campbell
On Thu, 2012-07-26 at 17:56 +0100, David Vrabel wrote: > On 26/07/12 16:33, Stefano Stabellini wrote: > > > > + * The hvc ISS is required to be 0xEA1, that is the Xen specific ARM > > + * hypercall tag. > > Is this number, 0xea1, assigned to Xen by some external body? The value and semantics of

Re: [PATCH 02/24] xen/arm: hypercalls

2012-07-27 Thread Ian Campbell
On Thu, 2012-07-26 at 20:19 +0100, Christopher Covington wrote: > Hi Stefano, > > On 07/26/2012 11:33 AM, Stefano Stabellini wrote: > > Use r12 to pass the hypercall number to the hypervisor. > > > > We need a register to pass the hypercall number because we might not > > know it at compile time

Re: [PATCH 13/24] xen/arm: get privilege status

2012-07-27 Thread Ian Campbell
On Thu, 2012-07-26 at 16:33 +0100, Stefano Stabellini wrote: > Use Xen features to figure out if we are privileged. > > XENFEAT_dom0 was introduced by 23735 in xen-unstable.hg. > > Signed-off-by: Stefano Stabellini > --- > arch/arm/xen/enlighten.c |7 +++ > include/xen/interface

Re: [Xen-devel] [PATCH 06/24] xen: missing includes

2012-07-27 Thread Jan Beulich
>>> On 26.07.12 at 17:33, Stefano Stabellini >>> wrote: > --- a/include/xen/interface/xen.h > +++ b/include/xen/interface/xen.h > @@ -10,7 +10,10 @@ > #define __XEN_PUBLIC_XEN_H__ > > #include > +#include > +#ifdef CONFIG_X86 > #include > +#endif Rather than hacking around this, why not

Re: [PATCH 07/24] xen/arm: Xen detection and shared_info page mapping

2012-07-27 Thread Ian Campbell
On Thu, 2012-07-26 at 16:33 +0100, Stefano Stabellini wrote: > Check for a "/xen" node in the device tree, if it is present set > xen_domain_type to XEN_HVM_DOMAIN and continue initialization. > > Map the real shared info page using XENMEM_add_to_physmap with > XENMAPSPACE_shared_info. > > Signed

Re: [Xen-devel] [PATCH 04/24] xen/arm: sync_bitops

2012-07-27 Thread Ian Campbell
On Thu, 2012-07-26 at 17:37 +0100, Konrad Rzeszutek Wilk wrote: > On Thu, Jul 26, 2012 at 04:33:46PM +0100, Stefano Stabellini wrote: > > sync_bitops functions are equivalent to the SMP implementation of the > > original functions, independently from CONFIG_SMP being defined. > > So why can't the

Re: [Xen-devel] [PATCH 10/24] xen: do not compile manage, balloon, pci, acpi and cpu_hotplug on ARM

2012-07-27 Thread Jan Beulich
>>> On 26.07.12 at 17:33, Stefano Stabellini >>> wrote: > --- a/drivers/xen/Makefile > +++ b/drivers/xen/Makefile > @@ -1,11 +1,15 @@ > -obj-y+= grant-table.o features.o events.o manage.o balloon.o > +ifneq ($(CONFIG_ARM),y) > +obj-y+= manage.o balloon.o While I assume that this

Re: [PATCH 12/24] xen/arm: Introduce xen_guest_init

2012-07-27 Thread Ian Campbell
On Thu, 2012-07-26 at 16:33 +0100, Stefano Stabellini wrote: > We used to rely on a core_initcall to initialize Xen on ARM, however > core_initcalls are actually called after early consoles are initialized. > That means that hvc_xen.c is going to be initialized before Xen. > > Given the lack of a

Re: [Xen-devel] [PATCH 17/24] xen: allow privcmd for HVM guests

2012-07-27 Thread Jan Beulich
>>> On 26.07.12 at 17:33, Stefano Stabellini >>> wrote: > In order for privcmd mmap to work correctly, xen_remap_domain_mfn_range > needs to be implemented for HVM guests. > If it is not, mmap is going to fail later on. Somehow, for me at least, this description doesn't connect to the actual cha

Re: [PATCH 18/24] xen/arm: compile blkfront and blkback

2012-07-27 Thread Ian Campbell
On Thu, 2012-07-26 at 16:34 +0100, Stefano Stabellini wrote: > > +#define XEN_IO_PROTO_ABI_ARM"arm-abi" I wonder if we ought to call this arm-aarch32-abi or something? I wonder if we can also take the opportunity to fix the ABI cockup for disks on ARM and make the structs the same for b

Re: [PATCH 1/5] acpi : move the acpi_idle_driver variable declaration

2012-07-27 Thread Daniel Lezcano
On 07/27/2012 07:46 AM, Deepthi Dharwar wrote: > Hi Daniel, > > > On 07/25/2012 04:15 PM, Daniel Lezcano wrote: > >> This variable is only used in the in processor_driver.c. >> This patch reduces the scope of the variable by moving it >> to this file. >> > > > This is true after applying your