Re: [PATCH V5 4/7] cpufreq: add clk-reg cpufreq driver

2011-12-27 Thread Richard Zhao
On Wed, Dec 28, 2011 at 11:14:10AM +0800, Richard Zhao wrote: > Hi Mark, > > [...] > > + if (cpu_reg) { > > + ret = regulator_is_supported_voltage(cpu_reg, > > + cpu_volts[i * 2], cpu_volts[i * 2 + 1]); > Is there any reason you didn't

Re: [PATCH V5 4/7] cpufreq: add clk-reg cpufreq driver

2011-12-27 Thread Shawn Guo
On Wed, Dec 28, 2011 at 10:01:13AM +0800, Shawn Guo wrote: > Here is my tag on this patch. > > Acked-by: Shawn Guo > For record, this tag is only valid with the following conditions. * Fix the failure of pm-qa case cpufreq_01 * Fix the failure of module build * Remove the dependency on REGUL

Re: [PATCH V5 4/7] cpufreq: add clk-reg cpufreq driver

2011-12-27 Thread Richard Zhao
Hi Mark, [...] > + if (cpu_reg) { > + ret = regulator_is_supported_voltage(cpu_reg, > + cpu_volts[i * 2], cpu_volts[i * 2 + 1]); Is there any reason you didn't export symbol regulator_is_supported_voltage? and also it don't have !

Re: [PATCH V5 4/7] cpufreq: add clk-reg cpufreq driver

2011-12-27 Thread Shawn Guo
On Wed, Dec 28, 2011 at 09:24:05AM +0800, Richard Zhao wrote: > > Have you tried to pass this param from kernel cmdline? What's the > > syntax if we want to pass a 800 MHz max_freq? > clk-reg-cpufreq.max_freq=80 Thanks. I was mistaken on the module name. > > ### cpufreq_05: > > ### test 'on

Re: [PATCH V5 4/7] cpufreq: add clk-reg cpufreq driver

2011-12-27 Thread Richard Zhao
On Tue, Dec 27, 2011 at 11:05:41PM +0800, Shawn Guo wrote: > Hi Richard, > > On Tue, Dec 27, 2011 at 04:24:19PM +0800, Richard Zhao wrote: > > The driver get cpu operation point table from device tree cpu0 node, > > and adjusts operating points using clk and regulator APIs. > > > > It support sin

Re: [PATCH] mmc: use usleep_range() in mmc_delay()

2011-12-27 Thread Sujit Reddy Thumma
Hi Antipov, Sorry for the delayed response. Please find some comments below: On 12/21/2011 6:35 PM, Dmitry Antipov wrote: On 12/21/2011 03:25 PM, Sujit Reddy Thumma wrote: I have posted similar patch some time back. http://comments.gmane.org/gmane.linux.ports.arm.msm/2119. Would you like to

Re: [PATCH V5 4/7] cpufreq: add clk-reg cpufreq driver

2011-12-27 Thread Shawn Guo
Hi Richard, On Tue, Dec 27, 2011 at 04:24:19PM +0800, Richard Zhao wrote: > The driver get cpu operation point table from device tree cpu0 node, > and adjusts operating points using clk and regulator APIs. > > It support single core and multi-core ARM SoCs. But currently it assume > all cores sha

Re: [PATCH v3] Regulator: Add Anatop regulator driver

2011-12-27 Thread Shawn Guo
On Tue, Dec 27, 2011 at 06:16:34PM +0800, Ying-Chun Liu (PaulLiu) wrote: > From: "Ying-Chun Liu (PaulLiu)" > > Anatop is an integrated regulator inside i.MX6 SoC. > There are 3 digital regulators which controls PU, CORE (ARM), and SOC. > And 3 analog regulators which controls 1P1, 2P5, 3P0 (USB).

Re: [PATCH v4 4/7] cpufreq: add clk-reg cpufreq driver

2011-12-27 Thread Mark Brown
On Tue, Dec 27, 2011 at 09:51:10AM +0800, Richard Zhao wrote: > On Mon, Dec 26, 2011 at 02:22:34PM +, Mark Brown wrote: > > Fix your mailer to word wrap properly please. > If you mean last mail I sent, I didn't see anything wrong. I use > mutt. It's wrapping at a bit more than 80 columns a l

Re: [PATCH v3] Regulator: Add Anatop regulator driver

2011-12-27 Thread Mark Brown
On Tue, Dec 27, 2011 at 06:16:34PM +0800, Ying-Chun Liu (PaulLiu) wrote: > + initdata = pdev->dev.platform_data; > + sreg = initdata->driver_data; > + > + spin_lock_init(&sreg->lock); You don't actually appear to use this, though it looks like you need to do something to protect again

Re: [PATCHv2] Regulator: Add Anatop regulator driver

2011-12-27 Thread Mark Brown
On Tue, Dec 27, 2011 at 06:06:27PM +0800, Ying-Chun Liu (PaulLiu) wrote: > (2011年12月22日 19:33), Mark Brown wrote: > >> +#include > >> +#include > > Why does your regulator driver need this? That suggests a layering > > violation. > Sorry, I'm not sure what does this mean. > But if I want to a

[PATCH v3] Regulator: Add Anatop regulator driver

2011-12-27 Thread Ying-Chun Liu (PaulLiu)
From: "Ying-Chun Liu (PaulLiu)" Anatop is an integrated regulator inside i.MX6 SoC. There are 3 digital regulators which controls PU, CORE (ARM), and SOC. And 3 analog regulators which controls 1P1, 2P5, 3P0 (USB). This patch adds the Anatop regulator driver. Signed-off-by: Nancy Chen Signed-of

Re: [PATCHv2] Regulator: Add Anatop regulator driver

2011-12-27 Thread Ying-Chun Liu (PaulLiu)
(2011年12月22日 19:33), Mark Brown wrote: > >> +#include >> +#include > > Why does your regulator driver need this? That suggests a layering > violation. > Sorry, I'm not sure what does this mean. But if I want to access regulator_constraints, shouldn't I include this header file? Yours Sincer

Re: [U-Boot] [PATCH 4/6] EEYNOS: Add SMDK5250 board support

2011-12-27 Thread Chander Kashyap
Dear minkyu Kang On 23 December 2011 11:21, Chander Kashyap wrote: > Dear Minkyu Kang, > > On 23 December 2011 09:51, Minkyu Kang wrote: >> >> Dear Chander Kashyap, >> >> On 22 December 2011 19:52, Chander Kashyap >> wrote: >> > SMDK5250 board is based on Samsungs EXYNOS5250 SoC. >> > >> > Sig

[PATCH V5 7/7] arm/imx6q: select ARCH_HAS_CPUFREQ

2011-12-27 Thread Richard Zhao
Signed-off-by: Richard Zhao --- arch/arm/mach-imx/Kconfig |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig index c44aa97..39cf00a 100644 --- a/arch/arm/mach-imx/Kconfig +++ b/arch/arm/mach-imx/Kconfig @@ -595,6 +595,7 @

[PATCH V5 4/7] cpufreq: add clk-reg cpufreq driver

2011-12-27 Thread Richard Zhao
The driver get cpu operation point table from device tree cpu0 node, and adjusts operating points using clk and regulator APIs. It support single core and multi-core ARM SoCs. But currently it assume all cores share the same frequency and voltage. Signed-off-by: Richard Zhao Reviewed-by: Jamie I

[PATCH V5 1/7] ARM: add cpufreq transiton notifier to adjust loops_per_jiffy for smp

2011-12-27 Thread Richard Zhao
If CONFIG_SMP, cpufreq skips loops_per_jiffy update, because different arch has different per-cpu loops_per_jiffy definition. Signed-off-by: Richard Zhao --- arch/arm/kernel/smp.c | 54 + 1 files changed, 54 insertions(+), 0 deletions(-) diff --

[PATCH V5 3/7] cpufreq: OMAP: remove loops_per_jiffy recalculate for smp

2011-12-27 Thread Richard Zhao
arm registered cpufreq transition notifier to recalculate it. Signed-off-by: Richard Zhao --- drivers/cpufreq/omap-cpufreq.c | 36 1 files changed, 0 insertions(+), 36 deletions(-) diff --git a/drivers/cpufreq/omap-cpufreq.c b/drivers/cpufreq/omap-cpufreq.

[PATCH V5 2/7] arm/imx: cpufreq: remove loops_per_jiffy recalculate for smp

2011-12-27 Thread Richard Zhao
arm registered cpufreq transition notifier to recalculate it. Signed-off-by: Richard Zhao --- arch/arm/plat-mxc/cpufreq.c | 10 -- 1 files changed, 0 insertions(+), 10 deletions(-) diff --git a/arch/arm/plat-mxc/cpufreq.c b/arch/arm/plat-mxc/cpufreq.c index c937e75..364793a 100644 ---

[PATCH V5 0/7] add a generic cpufreq driver

2011-12-27 Thread Richard Zhao
The driver is based on clock and regulator APIs and support single core and multi core ARM SoCs. For multi core, it assume all cores share the same clock and voltage. Thanks Arnd, Mark, Jamie, Rob, for your review. Changes in V5: - add more comments - rename trans-latency to clk-trans-latency,

[PATCH V5 6/7] arm/imx6q: register arm_clk as cpu to clkdev

2011-12-27 Thread Richard Zhao
cpufreq needs cpu clock to change frequency. Signed-off-by: Richard Zhao --- arch/arm/mach-imx/clock-imx6q.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-imx/clock-imx6q.c b/arch/arm/mach-imx/clock-imx6q.c index 039a7ab..72acbc2 100644 --- a/arch/arm/mac

[PATCH V5 5/7] dts/imx6q: add cpufreq property

2011-12-27 Thread Richard Zhao
Signed-off-by: Richard Zhao --- arch/arm/boot/dts/imx6q.dtsi |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/imx6q.dtsi b/arch/arm/boot/dts/imx6q.dtsi index 263e8f3..d89b42d 100644 --- a/arch/arm/boot/dts/imx6q.dtsi +++ b/arch/arm/boot/dts/imx6q.dt