Re: [PATCH v4 4/7] cpufreq: add clk-reg cpufreq driver

2011-12-24 Thread Jamie Iles
Hi Richard, This is looking really nice. A couple of really minor nits inline, otherwise: Reviewed-by: Jamie Iles On Thu, Dec 22, 2011 at 03:09:10PM +0800, Richard Zhao wrote: > The driver get cpu operation point table from device tree cpu0 node, > and adjusts operating points using clk and r

Re: [PATCH v4 4/7] cpufreq: add clk-reg cpufreq driver

2011-12-24 Thread Richard Zhao
On Sat, Dec 24, 2011 at 01:42:29PM +, Mark Brown wrote: > On Sat, Dec 24, 2011 at 09:28:33PM +0800, Richard Zhao wrote: > > On Sat, Dec 24, 2011 at 12:24:11PM +, Mark Brown wrote: > > > - trans-latency : transition latency of cpu freq and related regulator, > >in unit of ns. > > > D

Re: [PATCH v4 4/7] cpufreq: add clk-reg cpufreq driver

2011-12-24 Thread Mark Brown
On Sat, Dec 24, 2011 at 09:28:33PM +0800, Richard Zhao wrote: > On Sat, Dec 24, 2011 at 12:24:11PM +, Mark Brown wrote: > - trans-latency : transition latency of cpu freq and related regulator, >in unit of ns. > Does it look better? I think it shouldn't include the regulator part of th

Re: [PATCH v4 4/7] cpufreq: add clk-reg cpufreq driver

2011-12-24 Thread Richard Zhao
On Sat, Dec 24, 2011 at 12:24:11PM +, Mark Brown wrote: > On Sat, Dec 24, 2011 at 04:55:42PM +0800, Richard Zhao wrote: > > On Fri, Dec 23, 2011 at 01:18:51PM +, Mark Brown wrote: > > > > > +- trans-latency : transition_latency, in unit of ns. > > > > trans-latency should really say what

Re: [PATCH v4 4/7] cpufreq: add clk-reg cpufreq driver

2011-12-24 Thread Richard Zhao
On Sat, Dec 24, 2011 at 01:10:40PM +, Jamie Iles wrote: > Hi Richard, > > This is looking really nice. A couple of really minor nits inline, > otherwise: > > Reviewed-by: Jamie Iles Thanks. > > On Thu, Dec 22, 2011 at 03:09:10PM +0800, Richard Zhao wrote: > > The driver get cpu operation

Re: [PATCHv2] Regulator: Add Anatop regulator driver

2011-12-24 Thread Mark Brown
On Thu, Dec 22, 2011 at 11:33:38AM +, Mark Brown wrote: > On Wed, Dec 21, 2011 at 05:03:31PM +0800, Ying-Chun Liu (PaulLiu) wrote: > > + if (anatop_reg->rdata->control_reg) { > > + val = anatop_reg->rdata->min_bit_val + > > + (uv - reg->constraints->min_uV) / 2500

Re: [PATCH v4 4/7] cpufreq: add clk-reg cpufreq driver

2011-12-24 Thread Mark Brown
On Sat, Dec 24, 2011 at 04:55:42PM +0800, Richard Zhao wrote: > On Fri, Dec 23, 2011 at 01:18:51PM +, Mark Brown wrote: > > > +- trans-latency : transition_latency, in unit of ns. > > trans-latency should really say what latency is being measured (the CPU > > core only or the whole operation

Re: Call for testing: Updated OpenJDK 6.0 ARM port (for Ubuntu)

2011-12-24 Thread nivelin
Christian Robottom Reis writes: > > Hi there, > > Matthias has just landed in the Precise repositories an updated > version of OpenJDK that comes with a newly updated Zero-based ARM > optimized backend. Since many people have inquired about the general > state of Java on ARM, I'd like it if

Re: [PATCH v4 4/7] cpufreq: add clk-reg cpufreq driver

2011-12-24 Thread Richard Zhao
On Fri, Dec 23, 2011 at 01:18:51PM +, Mark Brown wrote: > On Thu, Dec 22, 2011 at 03:09:10PM +0800, Richard Zhao wrote: > > The driver get cpu operation point table from device tree cpu0 node, > > and adjusts operating points using clk and regulator APIs. > > Reviewed-by: Mark Brown > Thanks