[PATCH] ARM: S5P: Fix end address in memory resource information for UART devices

2011-02-08 Thread Thomas Abraham
For S5P platforms, the end address in memory resource information for UART devices is one byte more than the intended value. Fix this by reducing the end address by one byte. Signed-off-by: Thomas Abraham --- arch/arm/plat-s5p/dev-uart.c | 12 ++-- 1 files changed, 6 insertions(+), 6 d

Re: Compiling linaro filesystems

2011-02-08 Thread Amit Mahajan
t; For instance the last snapshot of headless has > > > http://snapshots.linaro.org/11.05-daily/linaro-headless/latest/0/images/tar/linaro-natty-headless-tar-20110208-0.packages > > > Also, I see that some folks are able to run linaro filesystems on > > PandaBoard. When wi

Re: v4l2 vs omx for camera

2011-02-08 Thread Sachin Gupta
Looking at ppt from Robert , it seems v4l2 subdevices is the way to support different devices that may be involved in imaging processing chain, also from the ppt it seems a userside library for Media controller is needed particular to each platform which controls these subdevices.I have not been ab

Re: Linaro-Natty images on the PandaBoard

2011-02-08 Thread Sachin Gupta
Hi All, Is there any fix to these issues with Panda. Thanks Sachin On Thu, Feb 3, 2011 at 8:46 PM, Kurt Taylor wrote: > On Tue, Feb 1, 2011 at 7:27 AM, Ken Werner > wrote: > > On Monday, January 31, 2011 11:17:35 pm Michael Hudson-Doyle wrote: > >> On Mon, 31 Jan 2011 19:28:35 +0100, Ken

Re: v4l2 vs omx for camera

2011-02-08 Thread Subash Patel
In the reference architecture in ppt, we can directly wait for the RSZ interrupt, if we configure the hardware pipe. It was my mis-understanding as each of those hardware blocks can deliver interrupts too. In that way ARM needs to just work at finished frame, like forward it to the display or co

Re: [PATCH] ARM: S5P: Fix length of memory resource definition for UART devices

2011-02-08 Thread Thomas Abraham
On 8 February 2011 09:30, Nicolas Pitre wrote: > On Tue, 8 Feb 2011, thomas.abra...@linaro.org wrote: > >> From: Thomas Abraham >> >> The length of memory resource definition for UART devices in all the >> s5p platforms is one byte more than the intended value. This patch >> fixes the UART memory

Re: Availability of kernel .config, Module.symvers and vmlinux in a package ?

2011-02-08 Thread Steve Langasek
Hi Frederic, On Wed, Feb 09, 2011 at 12:40:16AM +0100, Frederic Turgis wrote: > I don't remember how I wrongly installed it but msot of the files I am > looking for are obviously in kernel headers package (as they are > needed for kernel module recompilation). So these are solved. > vmlinux is no

Re: Availability of kernel .config, Module.symvers and vmlinux in a package ?

2011-02-08 Thread Frederic Turgis
Hi all, I don't remember how I wrongly installed it but msot of the files I am looking for are obviously in kernel headers package (as they are needed for kernel module recompilation). So these are solved. vmlinux is not, as expected. It has been made available on a server internally in TI, so it

Minutes from the Infrastructure team meeting - 2011-02-08

2011-02-08 Thread James Westby
Hi, You can read the full transcript on https://wiki.linaro.org/Platform/Infrastructure/Meetings/2011-02-08 === Attendees === * James Westby * Michael Hudson * Mattias Backman * Guilherme Salgado === Agenda === * Team status reports * Action items from last meeting. * status.linaro.org

Re: /latest link now active on snapshots.linaro.org

2011-02-08 Thread Steve Langasek
Hi Jamie, On Tue, Feb 08, 2011 at 01:10:46PM +, Jamie Bennett wrote: > There is now a much easier way to download the daily Linaro images and > hardware packs, the /latest link. Inside each build directory a /latest > link will always point to the latest successful build. The following > url

Re: problem with linaro-media-create

2011-02-08 Thread Steve Langasek
Hi Aneesh, On Tue, Feb 08, 2011 at 05:43:39PM +0530, Aneesh V wrote: > On Monday 07 February 2011 11:07 PM, Steve Langasek wrote: > >On Mon, Feb 07, 2011 at 03:59:06PM +0100, Alexander Sack wrote: > >>Since we only really support developer platform hosts with the tools > >>ppa enabled, could we i

Re: [PATCH 2/2] ARM: iMX5 BBG: add cpuidle driver parameters

2011-02-08 Thread Rtp
Amit Kucheria writes: > On 11 Feb 08, Yong Shen wrote: >> Hi Arnaud, >> >> I also took a while to think about this before posting patches. I prefer to >> put it in board related code since the various PMIC used on each boards may >> have influence on cpuidle latency or other charactors, although

Re: [PATCH 2/2] ARM: iMX5 BBG: add cpuidle driver parameters

2011-02-08 Thread Rob Herring
On 02/08/2011 09:51 AM, Yong Shen wrote: Hi Arnaud, I also took a while to think about this before posting patches. I prefer to put it in board related code since the various PMIC used on each boards may have influence on cpuidle latency or other charactors, although it could be minor. But yo

Re: [PATCH 2/2] ARM: iMX5 BBG: add cpuidle driver parameters

2011-02-08 Thread Amit Kucheria
On 11 Feb 08, Arnaud Patard wrote: > Amit Kucheria writes: > > > On 11 Feb 08, Yong Shen wrote: > >> Hi Arnaud, > >> > >> I also took a while to think about this before posting patches. I prefer to > >> put it in board related code since the various PMIC used on each boards may > >> have influen

Re: cpu supported

2011-02-08 Thread Christian Robottom Reis
On Sun, Jan 30, 2011 at 09:50:10AM +, Andy Green wrote: > Offlist so as not to make myself unpopular ^^ > > You might want to look at Fedora ARM, it target armv5te. > > http://fedoraproject.org/wiki/Architectures/ARM Well, point taken though -- is anyboy talking to Fedora to see if they'd be

Re: [PATCH 2/2] ARM: iMX5 BBG: add cpuidle driver parameters

2011-02-08 Thread Amit Kucheria
On 11 Feb 08, Yong Shen wrote: > Hi Arnaud, > > I also took a while to think about this before posting patches. I prefer to > put it in board related code since the various PMIC used on each boards may > have influence on cpuidle latency or other charactors, although it could be > minor. > Then

Re: Compiling linaro filesystems

2011-02-08 Thread James Westby
can see the package list alongside the image in the packages file. For instance the last snapshot of headless has http://snapshots.linaro.org/11.05-daily/linaro-headless/latest/0/images/tar/linaro-natty-headless-tar-20110208-0.packages > Also, I see that some folks are able to run linaro filesy

Re: Lava: Scope

2011-02-08 Thread Zygmunt Krynicki
W dniu 08.02.2011 17:48, Paul Miles pisze: Greetings Linaro-dev, I have joined the mailing list today and as a newbie Codethink(er) I am looking at contributing around the Linaro Validation area, especially Lava. My background is as a programme manager, generally around embedded mobile and have

Lava: Scope

2011-02-08 Thread Paul Miles
Greetings Linaro-dev, I have joined the mailing list today and as a newbie Codethink(er) I am looking at contributing around the Linaro Validation area, especially Lava. My background is as a programme manager, generally around embedded mobile and have just completed a significant webkit based dev

Re: Compiling linaro filesystems

2011-02-08 Thread Peter Pearse
On Tue, Feb 8, 2011 at 2:18 PM, Amit Mahajan wrote: > Hi, > > I want to compile linaro filesystems from sources with debug info. I > tried using XDeb but it seems like it is just a cross compiling > environment and not a complete root filesystem builder. > > Can anyone point me to a tutorial for t

Re: [PATCH 2/2] ARM: iMX5 BBG: add cpuidle driver parameters

2011-02-08 Thread Rtp
yong.s...@linaro.org writes: Hi, > From: Yong Shen > > Add cpuidle parameters to make cpuidle driver workable, but these > parameters need further tuning > > Signed-off-by: Yong Shen > --- > arch/arm/mach-mx5/board-mx51_babbage.c | 114 > > arch/arm/mach-mx5/

Re: [PATCH 2/3] xloader-panda-fix-rom-otg-boot-path.patch

2011-02-08 Thread Nishanth Menon
Aneesh, looping in x-loader list as well (apologies if cross posting is discouraged in linaro list).. x-loader list - fyi.. Aneesh V wrote, on 02/08/2011 06:53 PM: Hi Andy, On Tuesday 08 February 2011 03:11 PM, Andy Green wrote: From: Andy Green When the OMAP 4 on Panda sees that USB OTG ex

Re: [PATCH 2/2] ARM: iMX5 BBG: add cpuidle driver parameters

2011-02-08 Thread Yong Shen
Hi Arnaud, I also took a while to think about this before posting patches. I prefer to put it in board related code since the various PMIC used on each boards may have influence on cpuidle latency or other charactors, although it could be minor. Yong On Tue, Feb 8, 2011 at 4:29 PM, Arnaud Patard

[PATCH 2/2] ARM: iMX5 BBG: add cpuidle driver parameters

2011-02-08 Thread yong . shen
From: Yong Shen Add cpuidle parameters to make cpuidle driver workable, but these parameters need further tuning Signed-off-by: Yong Shen --- arch/arm/mach-mx5/board-mx51_babbage.c | 114 arch/arm/mach-mx5/devices.c|4 + arch/arm/mach-mx5/devic

[PATCH 1/2] ARM: iMX: cpuidle driver

2011-02-08 Thread yong . shen
From: Yong Shen implement cpu idle driver which allow different imx SOCs and boards to register their own cpuidle parameters Signed-off-by: Yong Shen --- arch/arm/plat-mxc/Makefile |1 + arch/arm/plat-mxc/cpuidle.c | 74 ++ arch/arm/

[PATCH 0/2] cpuidle driver on iMX platform

2011-02-08 Thread yong . shen
Also to freescale list, since there is no such driver in freescale bsp so far. Yong ___ linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev

Re: [PATCH 1/3] xloader-panda-add-0map4-gpio-base.patch

2011-02-08 Thread Andy Green
On 02/08/11 14:06, Somebody in the thread at some point said: Hi - omap3430/3530 seem to be the only supported ARMv7 CPUs in an omap3530 branch, and it seems the only supported board is beagle. It didn't build for me since my cross toolchain has FORTIFY_SOURCE and defaults to Thumb and

Compiling linaro filesystems

2011-02-08 Thread Amit Mahajan
Hi, I want to compile linaro filesystems from sources with debug info. I tried using XDeb but it seems like it is just a cross compiling environment and not a complete root filesystem builder. Can anyone point me to a tutorial for this, or atleast share some info on what configurations i.e packag

Re: Re: v4l2 vs omx for camera

2011-02-08 Thread Hans Verkuil
> Hi, > > Thanks for your ideas. > > If I am not mistaken all subdevices in the ISP media pipe could be > interconnected without the need from ARM intervention. But I could be > wrong. You are completely right. V4L2 sets up the internal hardware pipeline. Once you start streaming it is all done in

Re: /latest link now active on snapshots.linaro.org

2011-02-08 Thread Loïc Minier
On Tue, Feb 08, 2011, Jamie Bennett wrote: > There is now a much easier way to download the daily Linaro images and > hardware packs, the /latest link. Inside each build directory a /latest > link will always point to the latest successful build. \o/ Except it seems to point to the last day whe

Re: [PATCH 1/3] xloader-panda-add-0map4-gpio-base.patch

2011-02-08 Thread Loïc Minier
On Tue, Feb 08, 2011, Andy Green wrote: > http://git.warmcat.com/cgi-bin/cgit/qi/ > Currently the lpc branch is most up to date but Matt also proposed > merging all the support back into our master when he has done Panda, > so I will wait to move it on until that is done. omap3430/3530 seem to be

Re: [PATCH 2/3] xloader-panda-fix-rom-otg-boot-path.patch

2011-02-08 Thread Aneesh V
Hi Andy, On Tuesday 08 February 2011 07:12 PM, Andy Green wrote: On 02/08/11 13:23, Somebody in the thread at some point said: Hi - Would you please take a look at this patch in our internal tree. It seems to be fixing the same issue. I faced exactly same problem on Blaze. http://dev.omapzoo

Re: [PATCH 1/3] xloader-panda-add-0map4-gpio-base.patch

2011-02-08 Thread Aneesh V
Hi Anand, On Tuesday 08 February 2011 05:20 PM, Anand Gadiyar wrote: [snip..] The roadmap for x-loader is this: - There is ongoing work (from Aneesh and others) to build an x-loader equivalent out of u-boot. --- This is currently done for OMAP4 alone, but OMAP3 and others will take quit

Re: [PATCH 2/3] xloader-panda-fix-rom-otg-boot-path.patch

2011-02-08 Thread Andy Green
On 02/08/11 13:23, Somebody in the thread at some point said: Hi - Would you please take a look at this patch in our internal tree. It seems to be fixing the same issue. I faced exactly same problem on Blaze. http://dev.omapzoom.org/?p=bootloader/x-loader.git;a=commit;h=7ecbec096c300c7e71b663e

Re: [PATCH 2/3] xloader-panda-fix-rom-otg-boot-path.patch

2011-02-08 Thread Aneesh V
Hi Andy, On Tuesday 08 February 2011 03:11 PM, Andy Green wrote: From: Andy Green When the OMAP 4 on Panda sees that USB OTG external power is present, it changes the boot flow in the ROM to try to boot via that before trying MMC1. If it isn't satisfied, it falls through to try MMC1. Without

/latest link now active on snapshots.linaro.org

2011-02-08 Thread Jamie Bennett
Hi, There is now a much easier way to download the daily Linaro images and hardware packs, the /latest link. Inside each build directory a /latest link will always point to the latest successful build. The following urls are currently setup: http://snapshots.linaro.org/11.05-daily/linaro-alip/la

Re: Proposal for a MIPI System Trace Module driver

2011-02-08 Thread Philippe Langlais
Thanks Pawel, now I understand better the Coresight architecture, but STM has its own hardware architecture independent to Coresight not connected to Debug Bus nor Funnel Trace bus. STM exposes a set of registers to our main CPU for its control, it is connected to our ST-BUS through interconnect. I

Re: [PATCH 1/3] xloader-panda-add-0map4-gpio-base.patch

2011-02-08 Thread Andy Green
On 02/08/11 12:48, Somebody in the thread at some point said: Hi - This is certainly an interesting perspective for production images; for Linaro, I think we're exclusively using u-boot for now, which allows for some simplifications and gives developers a rather featureful bootloader wh

Re: [PATCH 1/3] xloader-panda-add-0map4-gpio-base.patch

2011-02-08 Thread Loïc Minier
On Tue, Feb 08, 2011, Andy Green wrote: > Actually FWIW I was talking to my friend Matt Hsu at 0xlabs > yesterday, he did an Omap 3 port of Qi bootloader and told he is > working on a Pandaboard / OMAP 4 port this week. cool! > To the extent that the bootloader is just there to load and boot > L

Re: [PATCH 1/3] xloader-panda-add-0map4-gpio-base.patch

2011-02-08 Thread Andy Green
On 02/08/11 11:46, Somebody in the thread at some point said: Hey Nicolas already pointed the recently created x-loader mailing-list and the common x-loader repository, but I was wondering whether we could just use jcrigby's u-boot SPL work on Panda and just avoid x-loader altog

Re: [PATCH 1/3] xloader-panda-add-0map4-gpio-base.patch

2011-02-08 Thread Andy Green
On 02/08/11 11:50, Somebody in the thread at some point said: Hi - I'm sorry about the mess - I tried to unify all of this and started yet another fork that I'm hoping gets to be called as the mainline x-loader. ;) This is the one - I've just received your patc

Re: v4l2 vs omx for camera

2011-02-08 Thread Loïc Minier
On Tue, Feb 08, 2011, Arnd Bergmann wrote: > while gst-openmax > is currently not even packaged for ubuntu. I think this is because gst-openmax needs to be built against BSP-specific omx headers, and this means we need some of these headers

Re: problem with linaro-media-create

2011-02-08 Thread Aneesh V
Hi Steve, On Monday 07 February 2011 11:07 PM, Steve Langasek wrote: On Mon, Feb 07, 2011 at 03:59:06PM +0100, Alexander Sack wrote: Since we only really support developer platform hosts with the tools ppa enabled, could we improve l-m-c to print a warning if that ppa isn't enabled? The othe

Re: problem with linaro-media-create

2011-02-08 Thread Aneesh V
Hi All, Thanks for the quick help. qemu update helped me. Maybe, I should have read the README more carefully. Thanks, Aneesh On Monday 07 February 2011 08:54 PM, Matt Waddel wrote: Hi Aneesh On 02/07/2011 07:25 AM, Aneesh V wrote: Hi, I am trying to prepare an MMC card to boot up Panda wi

RE: [PATCH 1/3] xloader-panda-add-0map4-gpio-base.patch

2011-02-08 Thread Anand Gadiyar
Loďc Minier wrote: > On Tue, Feb 08, 2011, Anand Gadiyar wrote: > > - Currently supported boards are: > > - OMAP3 EVM > > - Beagle and BeagleXM > > - Overo (35xx and 37xx) > > - Pandaboard > > - OMAP4 Blaze (currently, Pandaboard MLO works, but I need > > to push explicit support for

Re: [PATCH 1/3] xloader-panda-add-0map4-gpio-base.patch

2011-02-08 Thread Loïc Minier
On Tue, Feb 08, 2011, Anand Gadiyar wrote: > - Currently supported boards are: > - OMAP3 EVM > - Beagle and BeagleXM > - Overo (35xx and 37xx) > - Pandaboard > - OMAP4 Blaze (currently, Pandaboard MLO works, but I need > to push explicit support for Blaze out) IGEP? I thought this

Re: v4l2 vs omx for camera

2011-02-08 Thread Arnd Bergmann
On Tuesday 08 February 2011, SUBASH PATEL wrote: > Sent: Sachin Gupta > >you are correct that omx and v4l2 sit at different levels one > >being userside API and other being kernel API.But from the point > >of view of integrating these API's in OS frameworks like > >gstreamer,Andro

Re: Device Tree on ARM status report

2011-02-08 Thread Lorenzo Pieralisi
On Mon, 2011-02-07 at 14:28 -0700, Grant Likely wrote: > On Mon, Feb 7, 2011 at 1:46 AM, Amit Kucheria > wrote: > > On 11 Feb 05, Grant Likely wrote: > >> 2 - Task status > >> --- > >> Core infrastructure: > >> [glikely] basic infrastructure to enable dt: DONE > >> [r-herring] Allow d

RE: [PATCH 1/3] xloader-panda-add-0map4-gpio-base.patch

2011-02-08 Thread Anand Gadiyar
Andy Green wrote: > > On 02/08/11 10:25, Somebody in the thread at some point said: > > andy, why don't you send this series to the xloader ML instead? is that > > supposed to be taken upstream or in a linaro version of xloader? > > Hi Nicolas - > > Well, from an outside perspective xloader is a bi

Re: [PATCH 1/3] xloader-panda-add-0map4-gpio-base.patch

2011-02-08 Thread Loïc Minier
Hey Nicolas already pointed the recently created x-loader mailing-list and the common x-loader repository, but I was wondering whether we could just use jcrigby's u-boot SPL work on Panda and just avoid x-loader altogether @John: do you think this would be possible/hard on panda? @

Re: [PATCH 1/3] xloader-panda-add-0map4-gpio-base.patch

2011-02-08 Thread Andy Green
On 02/08/11 10:59, Somebody in the thread at some point said: Hi - yep I agree this is messy... but that's also why Anand G. from TI started an initiative to create a 'real' xloader mainline. see http://groups.google.com/group/beagleboard/browse_thread/thread/ced687ea9f1d072a?pli=1. In t

Re: [PATCH 1/3] xloader-panda-add-0map4-gpio-base.patch

2011-02-08 Thread Dechesne, Nicolas
Hi Andy, On Tue, Feb 8, 2011 at 11:37 AM, Andy Green wrote: > On 02/08/11 10:25, Somebody in the thread at some point said: > >> andy, why don't you send this series to the xloader ML instead? is that >> supposed to be taken upstream or in a linaro version of xloader? >> > > Hi Nicolas - > > Wel

Re: [PATCH 1/3] xloader-panda-add-0map4-gpio-base.patch

2011-02-08 Thread Andy Green
On 02/08/11 10:25, Somebody in the thread at some point said: andy, why don't you send this series to the xloader ML instead? is that supposed to be taken upstream or in a linaro version of xloader? Hi Nicolas - Well, from an outside perspective xloader is a bit difficult to find out how to i

Re: v4l2 vs omx for camera

2011-02-08 Thread SUBASH PATEL
Hi Sachin, I think when we speak of OMX, we are referring to the OMX-IL layer. This layer is supported as middleware component. I am putting down my experiences as below: - Generally Camera gives two streams. One is preview which can be YUV/RGB and another is capture (YUV/RGB/JPEG). Preview f

Re: [PATCH 1/3] xloader-panda-add-0map4-gpio-base.patch

2011-02-08 Thread Dechesne, Nicolas
andy, why don't you send this series to the xloader ML instead? is that supposed to be taken upstream or in a linaro version of xloader? On Tue, Feb 8, 2011 at 10:41 AM, Andy Green wrote: > From: Andy Green > > Signed-off-by: Andy Green > --- > > include/asm/arch-omap4/cpu.h |3 +++ > 1 f

Re: Proposal for a MIPI System Trace Module driver

2011-02-08 Thread Pawel Moll
Morning, > y, STM is not in the same family that xTM which trace execution & data > flow of an ARM core (non intrusive). > STM is more at applicative trace level like printf (output console > only). Well, what I mean is that xTMs - ETM/PTM tracing execution flow, ITM behaving like mentioned prin

[PATCH 2/3] xloader-panda-fix-rom-otg-boot-path.patch

2011-02-08 Thread Andy Green
From: Andy Green When the OMAP 4 on Panda sees that USB OTG external power is present, it changes the boot flow in the ROM to try to boot via that before trying MMC1. If it isn't satisfied, it falls through to try MMC1. Without this patch, under those conditions X-Loader is unable to update the

[PATCH 1/3] xloader-panda-add-0map4-gpio-base.patch

2011-02-08 Thread Andy Green
From: Andy Green Signed-off-by: Andy Green --- include/asm/arch-omap4/cpu.h |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/include/asm/arch-omap4/cpu.h b/include/asm/arch-omap4/cpu.h index 4971ba4..b273356 100644 --- a/include/asm/arch-omap4/cpu.h +++ b/include/asm/

[PATCH 3/3] xloader-panda-add-led-flashing-debug-code.patch

2011-02-08 Thread Andy Green
From: Andy Green I found this useful during debugging failure of xloader before serial had come up on Panda. Cc: Menon Nishanth Signed-off-by: Andy Green --- board/omap4430panda/omap4430panda.c | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/boar

Re: Proposal for a MIPI System Trace Module driver

2011-02-08 Thread Philippe Langlais
On 7 February 2011 13:16, Pawel Moll wrote: > > This module external interface is a pad on the chip > > which complies to the MIPI System Trace Protocol v1.0, > > and the actual trace output can be read by an > > electronic probe, not by software so it cannot be intercepted by > > the C

Re: Efikamx bootloader help

2011-02-08 Thread Loïc Minier
hey adding my bits where I can On Tue, Feb 08, 2011, Eric Miao wrote: > 2. The three possible boot up methods: a) Internal SPI NOR flash, b) the >MicroSD card behind the battery and c) the normal SD card at the left >side, not really sure about the situation on Efika MX (smart to

Re: v4l2 vs omx for camera

2011-02-08 Thread Sachin Gupta
Arnd, you are correct that omx and v4l2 sit at different levels one being userside API and other being kernel API.But from the point of view of integrating these API's in OS frameworks like gstreamer,Android camera service they are at the same level.I mean one will have to implement gstreamer s

Re: Efikamx bootloader help

2011-02-08 Thread Eric Miao
On Thu, Feb 3, 2011 at 6:44 AM, Loïc Minier wrote: > On Wed, Feb 02, 2011, Per Förlin wrote: >> I made a new attempt bringing up my imx today, this time I reconnected >> the keyboard and then I could recover u-boot without any trouble. I >> disconnected the keyboard when changing the DIP switches.

Re: v4l2 vs omx for camera

2011-02-08 Thread Lee Jones
Bringing in my boys. Robert, Linus, what say you? On 07/02/11 12:33, Arnd Bergmann wrote: > On Monday 07 February 2011, Sachin Gupta wrote: >> In Multimedia WG we have been posed with a question regarding best way >> to expose low level API for camera.so this a questions mainly about pros and