Re: Uke tab questions

2021-08-13 Thread Paulo Matos
Ah, disregard my question about opening an MR for this. Only just noticed this as well. :) Jean Abou Samra writes: > Le 13/08/2021 à 10:07, Jean Abou Samra a écrit : >> Le 13/08/2021 à 01:25, Valentin Petzel a écrit : >>> I’ve included a quick and moderately unefficient (but then, how >>> man

Re: Uke tab questions

2021-08-13 Thread Paulo Matos
Hi Valentin, You are correct. I compiled lilypond with and without your patch and your patch fixes it. :) I was wondering, if you want to prepare it to be merged, or if you want me to do it? It would be great to have this upstream. In any case, there's something that doesn't seem yet quite rig

Re: Uke tab questions

2021-08-13 Thread Jean Abou Samra
Le 13/08/2021 à 10:07, Jean Abou Samra a écrit : Le 13/08/2021 à 01:25, Valentin Petzel a écrit : I’ve included a quick and moderately unefficient (but then, how many strings might we get?) patch for scm/translation-functions.scm which solves this issue. Hi Valentin, Thanks for chiming in! C

Re: Uke tab questions

2021-08-13 Thread Jean Abou Samra
Le 13/08/2021 à 01:25, Valentin Petzel a écrit : I’ve included a quick and moderately unefficient (but then, how many strings might we get?) patch for scm/translation-functions.scm which solves this issue. Hi Valentin, Thanks for chiming in! Could you put up your patch in a merge request, plea

Re: Uke tab questions

2021-08-12 Thread Valentin Petzel
Hello Paolo, hello Carl, This is actually very easy to fix. By default the algorithm works like this: We try to put each note to the lowest possible fret. To do this we assume the strings are in falling pitch and then we just walk through all strings and stop once we get one that works. To get

Re: Uke tab questions

2021-08-12 Thread Carl Sorensen
Dear Paulo, The automatic fret generation code only works for instruments with monotonic (steadily increasing or decreasing) string pitches. Since the ukulele has non-monotonic string pitches, the algorithms do not work. See Known issues and warnings under https://lilypond.org/doc/v2.22/Docu

Uke tab questions

2021-08-12 Thread Paulo Matos
Hi, I have just started using lilypond to transcribe some music and automatically get an ukulele tablature for it. I am a bit surprised by some fingering choices. For example, a simple scale starting in middle-c: \version "2.22.0" global = { \key c \major \time 4/4 } ukulele = \relati