Re: Run regression tests for lilypond-book (issue 2223). (issue 5569045)

https://codereview.appspot.com/5569045/diff/3001/input/regression/lilypond-book/GNUmakefile File input/regression/lilypond-book/GNUmakefile (right): https://codereview.appspot.com/5569045/diff/3001/input/regression/lilypond-book/GNUmakefile#newcode36 input/regression/lilypond-book/GNUmakefile:36

Re: lilypond-book safe mode

On 12/10/2010 11:59 PM, Carl Sorensen wrote: This patch *looks* appropriate to me, but I haven't tested it, and I'm not sure exactly how I would test it. Pavel, do you have a test file that can work with the patch so we can demonstrate it works properly? Here's one, try running it through lily

Re: LSR updates and translations

On 25/06/2012 1:53 PM, John Mandereau wrote: Il giorno lun, 25/06/2012 alle 18.50 +0100, Phil Holmes ha scritto: And John M could no doubt help. It's a question of how much time they have to contribute. If what we want to achieve is well enough specified, then I can offer to go for it. Cheers

Re: Fix for several musicxml2ly bugs. (issue 5697059)

Hi Patrick, A cleaned up version of this patch has been committed (and credited to you), so you may close this Rietveld issue. You will see the fix in version 2.15.41, the next development release. Cheers, Julien http://codereview.appspot.com/5697059/ __

Re: Patchy switches for forcing make doc don't seem to work

On 20/08/2012 8:53 AM, James wrote: John, On 20 August 2012 13:09, John Mandereau wrote: Hi James, Il giorno lun, 20/08/2012 alle 10.40 +0100, James ha scritto: I am not able to work out how to force patchy during a test-patches.py to also make doc as well as the test and test-baseline. I do

Re: make test

On 08/08/2012 4:59 AM, Phil Holmes wrote: I've been looking at how the regression test comparison works. The first thing I find is that we have 2 effectively duplicate, but different, pages on running regtest comparisons: http://lilypond.org/doc/v2.15/Documentation/contributor/verify-regression

convert-ly (issue 2670) (issue 6610058)

Reviewers: , Message: For review: Description: convert-ly: - Exit with error status when errors occur. - Use unicode strings for file names printing. - Don't update \version when no rule is applied. This fixes issue 2670. Please review this at http://codereview.appspot.com/6610058/ Affecte

Re: lilypond-book: treat iffalse sections in latex as block comments (issue 6584073)

Try to add a regression test example with a valid lilypond block inbetween two multiline comments. http://codereview.appspot.com/6584073/diff/1/python/book_latex.py File python/book_latex.py (right): http://codereview.appspot.com/6584073/diff/1/python/book_latex.py#newcode88 python/book_latex.p

Re: convert-ly (issue 2670) (issue 6610058)

On Sat, Oct 6, 2012 at 1:06 AM, wrote: > Are you going to report the number of errors using the `errors' > variable? In case this is true, I would consider this a bad idea, since > you abuse the functionality of the exit status. > > How large can `errors' become? The value returned by `exit' mu

Re: [talk] why it'd be great to have web interface for submittingsimple doc patches

On 07/10/2012 5:33 AM, Phil Holmes wrote: - Original Message - From: "Joseph Rushton Wakeling" To: "Phil Holmes" Cc: "James" ; Sent: Saturday, October 06, 2012 5:26 PM Subject: Re: [talk] why it'd be great to have web interface for submittingsimple doc patches On 10/06/2012 05:46 PM

Re: convert-ly (issue 2670) (issue 6610058)

On Mon, Oct 8, 2012 at 4:08 PM, wrote: > The changelog says > > "Don't update \version when no rule is applied." > > That's what the existing -d --diff-version-update command does. If this > is intended to be the default behaviour now, then the command-line > option should be removed. No, -d do

Re: Translations for create-weblinks-itexi.py (issue 6681045)

On Mon, Oct 15, 2012 at 7:40 AM, wrote: > this looks strange: when i go to side-by-side diffs, i don't see any > changes, just "error: old chunk mismatch". I don't know what caused that, but you can rely on the raw patch set. Since this patch only adds lines and does not remove any lines, the re

Re: Update contributors. (issue 6689045)

On Mon, Oct 15, 2012 at 5:18 PM, wrote: > Sorry, there's a bit of confusion here. The past policy was: Thanks, I've updated the file to clarify the policy and made sure that I do not move contributors from past to current but simply add them to current. Cheers, Julien

Re: problem uploading a patch

On 16/10/2012 4:36 PM, David Nalesnik wrote: david@david-desktop ~/lilypond-git (dev/measure_counter)$ git cl issue 2445 Issue number: 2445 (http://codereview.appspot.com/2445) This should be the issue number from the Rietveld page, not the one from google code page. -- Julien _

Re: problem uploading a patch

On 10/17/2012 02:55 PM, David Nalesnik wrote: Julien, On Wed, Oct 17, 2012 at 1:33 AM, Julien Rioux wrote: On 16/10/2012 4:36 PM, David Nalesnik wrote: david@david-desktop ~/lilypond-git (dev/measure_counter)$ git cl issue 2445 Issue number: 2445 (http://codereview.appspot.com/2445

Re: Update contributors. (issue 6689045)

I missed that Bertrand Bordage, Joe Neeman, and Carl D. Sorensen are listed both under "developers" and "contributors". According to the policy they should be removed from "contributors". Also Colin Hall is listed under "developers" so probably should not be added under "contributors: bug squad" l

Re: Update contributors. (issue 6689045)

On Fri, Oct 19, 2012 at 8:47 AM, Janek Warchoł wrote: > On Fri, Oct 19, 2012 at 10:36 AM, wrote: >> I missed that Bertrand Bordage, Joe Neeman, and Carl D. Sorensen are >> listed both under "developers" and "contributors". According to the >> policy they should be removed from "contributors". Al

Fix KeyError in website_post.py from Issue 847 (issue 7021043)

LGTM https://codereview.appspot.com/7021043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: CG: explicitly detail the correct values for git cl config (issue 7096052)

At this point, the git-cl used by the project has been sufficiently geared towards lilypond development that I somewhat doubt anybody is using it for work outside of lilypond. It might not make sense at all for "our" git-cl to keep asking these superfluous questions; should they be remove entirely

Re: DOC: Update CG 8.7 Patch Handling (issue 7101048)

Reitveld -> Rietveld https://codereview.appspot.com/7101048/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: build: missing explicit dependency?

On 05/03/2013 11:07 AM, Francisco Vila wrote: 2013/3/3 James : On 2 March 2013 16:54, Francisco Vila wrote: Hello. When trying to build lilypond, I had to install the texlive-metapost package which the autogen.sh did not ask for. Is this a flaw of the config process? Well when I follow the

Re: Alternative pixel-based regtest checker

On 01/03/2013 2:15 PM, Phil Holmes wrote: 4 files attached. To try this out: create a new directory and place NoTagline.ly in it. Create a subdirectory called input and put some regtest files in there. Run MakeOldPix.sh. Make a change to lilypond. Run MakeNewPix.sh. Run ComparePix.sh. Om my

Re: build: missing explicit dependency?

On 02/03/2013 11:54 AM, Francisco Vila wrote: Hello. When trying to build lilypond, I had to install the texlive-metapost package which the autogen.sh did not ask for. Is this a flaw of the config process? Actually, ./configure is checking for both mf and mpost. Do you still have a config.log

Re: build: missing explicit dependency?

On Tue, Mar 12, 2013 at 2:05 PM, Francisco Vila wrote: > 2013/3/12 Julien Rioux : >> On 02/03/2013 11:54 AM, Francisco Vila wrote: >>> >>> Hello. When trying to build lilypond, I had to install the >>> texlive-metapost package which the autogen.sh did not ask f

Re: build: missing explicit dependency?

On Thu, Mar 14, 2013 at 5:39 AM, Francisco Vila wrote: > 2013/3/12 Julien Rioux : >> OK I see, so testing for the binaries is not enough. We`ll need to >> find out what else is required and add a test for it. Does anybody >> know? If you or anyone else do uninstall texlive

Re: make doc fails

On 16/03/2013 6:27 PM, David Nalesnik wrote: /usr/bin/python -tt /home/david/lilypond-git/scripts/build/create-weblinks-itexi.py > out-www/weblinks.itexi make[3]: *** No rule to make target `/home/david/lilypond-git/Documentation/cs/web/news-front.itexi', needed by `out-www/web.texi'. Stop. Tr

Re: Does lilypond 2.15.x support guile 2.0 yet?

On 26/09/2011 2:18 PM, Dave Plater wrote: On 09/26/2011 10:31 AM, Graham Percival wrote: On Mon, Sep 26, 2011 at 09:54:18AM +0200, Dave Plater wrote: Lilypond won't even be able to be installed via tarball on openSUSE 12.1 without the user removing guile 2.0 completely and installing guile 1.8

Re: replacement git-cl

On 26/09/2011 4:36 AM, Graham Percival wrote: Please use https://github.com/gperciva/git-cl instead of the current git-cl. To configure, add a file called google.login to your lilypond srcdir, in the format username password This updated git-cl will: - create an issue with Patch-new to co

Re: replacement git-cl

On 26/09/2011 11:13 PM, Janek Warchoł wrote: 2011/9/26 Julien Rioux: I tried this. Rietveld issue was created, but google page issue gave me an error. Attaching Do i guess correctly that it's because your e-mail address is not authorized in our tracker? Graham? cheers,

Re: Build dependencies for .texi files (issue 1852). (issue 5131045)

Last try. http://codereview.appspot.com/5131045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Build dependencies for .texi files (issue 1852). (issue 5131045)

Reviewers: , Message: Apparently we have to publish this. Description: Build dependencies for .texi files (issue 1852). Write .dep files containing make dependency rules for .texi files. These .dep files are generated by scanning for lines starting with @include in the .texi files. They are inc

Re: Build dependencies for .texi files (issue 1852). (issue 5169041)

Publish comments. http://codereview.appspot.com/5169041/diff/1/Documentation/topdocs/AUTHORS.texi File Documentation/topdocs/AUTHORS.texi (right): http://codereview.appspot.com/5169041/diff/1/Documentation/topdocs/AUTHORS.texi#newcode13 Documentation/topdocs/AUTHORS.texi:13: @include ../macros.

Re: Build dependencies for .texi files (issue 1852). (issue 5131045)

On 2011/09/27 09:12:44, Graham Percival wrote: the email came through without trouble; the problem is the uploading. Wait for Janek to do it. I've made issue 1491 release-critical. I can't edit the code review created by Janek since I am not the owner. I have been successful (to some extend

Re: Build dependencies for .texi files (issue 1852). (issue 5131045)

This should address the comments posted at http://codereview.appspot.com/5169041/ http://codereview.appspot.com/5131045/diff/5001/Documentation/GNUmakefile File Documentation/GNUmakefile (left): http://codereview.appspot.com/5131045/diff/5001/Documentation/GNUmakefile#oldcode250 Documentation/G

Re: git-cl upload mimetypes fixed (issue 1491)

On 30/09/2011 1:59 PM, Graham Percival wrote: Following Nicholas' suggestion from last February, I've fixed the git-cl upload: https://github.com/gperciva/git-cl/commit/86d891d0817b0d4946fd22bd03554ea2685337b9 I suggest that everybody using git-cl upgrade to this. Also note that I've added a

Re: website.make (was: Moving away from make)

ons, parallel builds, all are thrown out the door. You of course have loops in make, attached you find a short rewrite of that particular snippet. I can probably reduce it to even fewer targets and make it simpler. If you want me to, I can look at the whole file to makeify it. --

Re: git-cl upload mimetypes fixed (issue 1491)

On 03/10/2011 12:33 AM, Trevor Daniels wrote: Hhm. This doesn't work either: $ git clone https://github.com/gperciva/git-cl.git The above line works fine here. Cheers, Julien ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu

Re: Build dependencies for .texi files (issue 1852). (issue 5131045)

stepmake/stepmake/texinfo-vars.make (right): http://codereview.appspot.com/5131045/diff/5001/stepmake/stepmake/texinfo-vars.make#newcode11 stepmake/stepmake/texinfo-vars.make:11: find-texi = \ On 2011/10/04 11:57:19, Graham Percival wrote: On 2011/10/02 00:05:41, Julien Rioux wrote: > Find

Re: Build dependencies for .texi files (issue 1852). (issue 5131045)

AFAIK, texi2* simply include the first file found in the include pathes. So if Documentation/ is given first, then Documentation/macros.itexi is used, if Documentation/de/ is given before Documentation/, then Documentation/de/macros.itexi is used... Thanks. If I tracked it right then Documen

Re: New git cl :: rebase patches

On 04/10/2011 3:04 PM, Colin Campbell wrote: On 11-10-04 02:48 AM, m...@apollinemike.com wrote: Hey all, I uploaded a couple patches to Rietveld this morning just to have clean diffs with current master (my bazillion commits on my local branch won't apply to current master anymore). I then down

Re: Fix a few lilypond-book bugs on windows (Issue 1815). (issue 5183042)

Reviewers: Reinhold, Message: Of course you know the code better, so please investigate. I did not understand why we keep two points to the same file, but if it is needed, support for windows will require copying the files. There are no hard links that I am aware of. http://codereview.appspot.c

Re: website.make

On 05/10/2011 2:31 PM, Graham Percival wrote: On Sun, Oct 02, 2011 at 02:50:12PM +0200, Julien Rioux wrote: I had a look at website.make, and it strikes me as a shell script written in make. That's quite a fair assesement. You of course have loops in make, attached you find a short re

Re: Fix a few lilypond-book bugs on windows (Issue 1815). (issue 5183042)

On Wed, Oct 5, 2011 at 5:17 AM, Alex Austin wrote: > On Tue, Oct 4, 2011 at 3:22 PM, wrote: >> >> ... There are no hard links that I am aware of. > > http://msdn.microsoft.com/en-us/library/windows/desktop/aa365006(v=vs.85).aspx It is not a restriction of NTFS but of the windows C api and thus i

Re: website.make

I now have a roughly final version of website.make which implements the same functionality but using make rules instead of shell for loops. As a result you can parallelize the build and rebuild only what is needed. I tested and there is absolutely no diff between the out-website generated with

Re: Fix the links to music samples in web-big-page (issue 1663). (issue 5276054)

Reviewers: J_lowe, Message: On 2011/10/18 05:48:08, J_lowe wrote: Graham, This fails at the basic make stage ../configure ; make -j7 I also re-ran make multiple times to see if it was 'one of those things' but it fails the same. --snip-- make[2]: Leaving directory `/home/jlowe/l

Re: Fix the links to music samples in web-big-page (issue 1663). (issue 5276054)

Hi again, How did you apply the patch? Here I use git cl patch 5276054 and I get this commit (notice the renames): # On branch rietvield-issue-5276054 # Changes to be committed: # (use "git reset HEAD^1 ..." to unstage) # # modified: Documentation/GNUmakefile # renamed:Document

Re: Fix the links to music samples in web-big-page (issue 1663). (issue 5276054)

On Tue, Oct 18, 2011 at 3:01 PM, Julien Rioux wrote: > Here I use > git cl patch 5276054 Just a warning that this might not be the suggested procedure: if you do this in master it might break things, I have no idea. So if you know how to use branches, you could try that command in a branc

Re: Fix the links to music samples in web-big-page (issue 1663). (issue 5276054)

On Tue, Oct 18, 2011 at 6:21 PM, Peekay Ex wrote: > Julien, > > On Tue, Oct 18, 2011 at 2:01 PM, Julien Rioux wrote: >> Hi again, >> How did you apply the patch? Here I use >> git cl patch 5276054 >> and I get this commit (notice the renames): > > I rig

Re: Fix the links to music samples in web-big-page (issue 1663). (issue 5276054)

On Tue, Oct 18, 2011 at 3:07 PM, Julien Rioux wrote: > On Tue, Oct 18, 2011 at 3:01 PM, Julien Rioux wrote: >> Here I use >> git cl patch 5276054 > > Just a warning that this might not be the suggested procedure: if you > do this in master it might break things, I have n

Re: patches to apply

On 02/11/2011 2:22 PM, Peekay Ex wrote: Thanks to you both, that helped a lot. I'm able to push to dev/staging now. Regards Thank you all. -- Julien ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/l

Re: Improve HTML output of regression tests (issue 5342042)

Only stylistic comments: http://codereview.appspot.com/5342042/diff/1/scripts/build/output-distance.py File scripts/build/output-distance.py (right): http://codereview.appspot.com/5342042/diff/1/scripts/build/output-distance.py#newcode8 scripts/build/output-distance.py:8: from cgi import escape

recent make doc failure

Hi all, In a fresh checkout I run ./autogen.sh --noconfigure mkdir build0 cd build0 ../configure --disable-optimising make && make doc This is a sequential make and make doc. The latter stops with the error message given below. Extract_texi_filename is the last thing that runs correctly and th

Re: recent make doc failure

On 29/11/2011 6:15 PM, Graham Percival wrote: On Tue, Nov 29, 2011 at 05:28:37PM -0500, Julien Rioux wrote: This is a sequential make and make doc. The latter stops with the error message given below. Extract_texi_filename is the last thing that runs correctly and then make tries to copy a file

Re: recent make doc failure

On 29/11/2011 6:24 PM, James wrote: Julien On 29 November 2011 22:28, Julien Rioux wrote: Hi all, In a fresh checkout I run ./autogen.sh --noconfigure mkdir build0 cd build0 ../configure --disable-optimising make&& make doc This is a sequential make and make doc. The latter stops

Re: Build fixes for translated manuals: dependencies and a typo (issue 5477088)

f590407 Mon Sep 17 00:00:00 2001 From: Julien Rioux Date: Tue, 29 Nov 2011 05:18:19 -0500 Subject: [PATCH] Build fixes for translated manuals: dependencies and a typo --- Documentation/cs/GNUmakefile|2 +- Documentation/de/GNUmakefile|2 +- Documentation/es/GNUmakefile|2 +-

Re: Release news, development news, state of the world

On 14/12/2011 10:21 AM, Graham Percival wrote: It would be nice if you adding the above to that tracker issue. Done. -- Julien ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Output a newline by default at the end of progress messages. (issue 5485077)

Reviewers: , Message: Note to self: before pushing, rebase on top of master and remove the extra '\n' added in the progress message in http://git.savannah.gnu.org/gitweb/?p=lilypond.git;a=blobdiff;f=python/lilylib.py;h=0f33ed4a2cde2bf5b7e147ae0366afa249bf275c;hp=7a36a8aaace6ab8cce1b09d8044dc61ced

Regtest script improvements: (issue 5493073)

Reviewers: , Message: Some general improvements in the way the regtest comparison page is generated, including displaying the path of the input file relative to the top source directory. Description: Regtest script improvements: - Allow to customize the length of shortened strings. - When filte

Build translated manuals: Don't rebuild everything each time unless necessary. (issue 5494069)

Reviewers: , Message: Moving towards a build system which tracks dependencies for every file, update timestamps correctly and so on. These are all the fixes for the translated manuals. Description: Build: Don't rebuild everything each time unless necessary. - Fix a typo. - Update timestamp when

Re: CG: Typos in "Programming work" and "Regression tests" sections. (issue 5490064)

On Sun, Dec 18, 2011 at 2:08 PM, wrote: > LGTM, please send final patch for pushing directly to staging. > > http://codereview.appspot.com/5490064/ Here here, Thanks, Julien 0001-CG-Typos-in-Regression-tests-section.patch Description: Binary data 0002-CG-Typos-in-Programming-work-section.pat

Build: Dependencies for make website (issue 2027). (issue 5493074)

Reviewers: , Description: Build: Dependencies for make website (issue 2027). Please review this at http://codereview.appspot.com/5493074/ Affected files: M make/website.make Index: make/website.make diff --git a/make/website.make b/make/website.make index d6d9ef7a12a09b921b922214370820e51

Re: Directs output of texi2html to log files (GOP 9) (issue 5495092)

On 2011/12/19 16:37:10, PhilEHolmes wrote: Please review Hi Phil, I was just looking at the translated manuals recently, please see http://code.google.com/p/lilypond/issues/detail?id=2125 Among the suggested changes in issue 2125 is to remove all the TEXI2HTML calls in make/doc-i18n-root-rule

Re: Directs output of texi2html to log files (GOP 9) (issue 5495092)

On 2011/12/19 20:34:31, mail_philholmes.net wrote: - Original Message - From: To: ; Cc: ; Sent: Monday, December 19, 2011 8:23 PM Subject: Re: Directs output of texi2html to log files (GOP

Build: Try to convince `make' to keep intermediate files. (issue 5490077)

Reviewers: , Message: This could possibly fix the recurring issues with parallel make. However if `make -jX' does not obey the .SECONDARY: construct then we are not any better off. Description: Build: Try to convince `make' to keep intermediate files. Possible fix to issue 1906. Please review

Re: Don't blindly issue the warning (issue 5477087)

Final patch ready to push. http://code.google.com/p/lilypond/issues/detail?id=2105 From cc8e92ac950f03e052d5c1e07ab053959a7d6359 Mon Sep 17 00:00:00 2001 From: Julien Rioux Date: Tue, 29 Nov 2011 05:30:41 -0500 Subject: [PATCH] Remove inacurate warning and .aux file left over by lilypond-book

Re: Output a newline by default at the end of progress messages. (issue 5485077)

Final patch ready to push. http://code.google.com/p/lilypond/issues/detail?id=2103 From 05509f133d55d0084ec54f2c28675c8b4e29532c Mon Sep 17 00:00:00 2001 From: Julien Rioux Date: Wed, 14 Dec 2011 08:40:02 -0500 Subject: [PATCH] Output a newline by default at the end of progress messages

lilylib.py : Wrap arguments with double quotes and clarify a comment. (issue 5483073)

Reviewers: , Message: Final patch ready to push. http://code.google.com/p/lilypond/issues/detail?id=2107 Description: lilylib.py : Wrap arguments with double quotes and clarify a comment. I misunderstood what this function does before. On Windows we can skip the escaping of \, $, ", and ` but

Re: lilylib.py : Wrap arguments with double quotes and clarify a comment. (issue 5483073)

Oops here's the patch. http://code.google.com/p/lilypond/issues/detail?id=2107 From dbd9b50d1b9bc7f1bda5dbfdacb9163731afb489 Mon Sep 17 00:00:00 2001 From: Julien Rioux Date: Tue, 13 Dec 2011 07:43:30 -0500 Subject: [PATCH] lilylib.py : Wrap arguments with double quotes and clarify a co

Re: Don't blindly issue the warning (issue 5477087)

On Tue, Dec 20, 2011 at 4:49 PM, Graham Percival wrote: > Thanks, pushed.  You're responsible for closing the issue. The google issue or the rietveld issue or both? Thanks, Julien ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu

Build: Version dependency for python modules (issue 1726). (issue 5490067)

Reviewers: , Message: Pretty self-explanatory but I forgot to publish. Description: Build: Version dependency for python modules (issue 1726). Please review this at http://codereview.appspot.com/5490067/ Affected files: M stepmake/stepmake/python-module-rules.make Index: stepmake/stepmake/

Re: Build: Dependencies for make website (issue 2027). (issue 5493074)

Documentation writers: Is it correct to say as a general rule that if a file has a .itexi extension, it does not contain @nodes? http://codereview.appspot.com/5493074/diff/1/make/website.make File make/website.make (right): http://codereview.appspot.com/5493074/diff/1/make/website.make#newcode1

Re: Directs output of texi2html to log files (GOP 9) (issue 5495092)

On 2011/12/20 19:19:51, Graham Percival wrote: Does stepmake/stepmake/texinfo-rules.make apply to translations? I thought translations only used make/doc-whatever-i18n. Since very recently, yes. I added texinfo in 9ac7a5aaff66f2bd19184c9a23bccd195323e193. Anyway, I'm slightly hesitant to i

Re: Build: Dependencies for make website (issue 2027). (issue 5493074)

On 2011/12/20 19:25:20, Julien Rioux wrote: Documentation writers: Is it correct to say as a general rule that if a file has a .itexi extension, it does not contain @nodes? OK, that's not a general rule, but it happens to be true for itexi files generated from bib files.

Re: Directs output of texi2html to log files (GOP 9) (issue 5495092)

On Tue, Dec 20, 2011 at 8:39 PM, Graham Percival wrote: > oh, *that's* what the STEPMAKE_TEMPLATES line does! > > Cheers, > - Graham Yes, and things started to make a lot more sense once I made that connection. At some point in the new year I'll try to document what I learned about stepmake. Che

Re: Directs output of texi2html to log files (GOP 9) (issue 5495092)

On Tue, Dec 20, 2011 at 8:46 PM, Graham Percival wrote: > On Tue, Dec 20, 2011 at 08:41:10PM +0100, Julien Rioux wrote: >> Yes, and things started to make a lot more sense once I made that connection. >> At some point in the new year I'll try to document what I learned >

Re: Build: Try to convince `make' to keep intermediate files. (issue 5490077)

On Wed, Dec 21, 2011 at 2:42 AM, wrote: > Works with no problem on my (single-processor) Fedora system, for what > little that is worth. > > Could you point out which files are affected by .SECONDARY, Julien, so > users of the affected systems might test specifically to see if this > addresses th

Re: Build: Try to convince `make' to keep intermediate files. (issue 5490077)

David Kastrup gnu.org> writes: > > Julien Rioux gmail.com> writes: > > > On Wed, Dec 21, 2011 at 2:42 AM, oco.net> wrote: > > > >> The machine-generated parser.cc, for example, is not deleted by make > >> either with or without your patch. &g

Re: Build commits

On Sun, Jan 1, 2012 at 8:14 AM, Phil Holmes wrote: > Julien, > > If you look at http://code.google.com/p/lilypond/issues/detail?id=2156 > you'll see there were problems with some commits leading up to December > 23rd.  As a result, a number weren't forwarded to master and staging was > recreated.

Re: Sketch of not remaking html files (issue 5498093)

Checking the file timestamps will be a good thing. It might be better to just replace the whole www_post script by make rules, but in the current implementation this is a good improvement. Just a style thing, in general I notice that you use "function(arg)" while the rest of python source code in

Fix .dep file from lilypond-book when include paths are involved. (issue 5486064)

Reviewers: , Message: Remove the use of absolute paths in lilypond-book. Please review. Description: Fix .dep file from lilypond-book when include paths are involved. Don't rewrite include paths; use relative paths whenever possible. Similar to http://code.google.com/p/lilypond/issues/detail?id

Use forward slashes as path separators in latex (issue 2209). (issue 5530069)

Reviewers: , Message: Please review. Description: Use forward slashes as path separators in latex (issue 2209). Please review this at http://codereview.appspot.com/5530069/ Affected files: M python/book_latex.py Index: python/book_latex.py diff --git a/python/book_latex.py b/python/book_la

Build: Top-level GNUmakefile (issue 5535047)

Reviewers: , Message: Please review. Description: Build: Top-level GNUmakefile This file is chmoded to 444 so it cannot be overwritten by cat << EOF > GNUmakefile alone; it needs to be removed first. It also has some missing dependencies as evidenced by running `make' twice: on the second run i

Re: Use forward slashes as path separators in latex (issue 2209). (issue 5530069)

On Tue, Jan 10, 2012 at 11:42 PM, wrote: > > http://codereview.appspot.com/5530069/diff/1/python/book_latex.py > File python/book_latex.py (right): > > http://codereview.appspot.com/5530069/diff/1/python/book_latex.py#newcode274 > python/book_latex.py:274: rep['base'] = basename.replace ('\\', '/

Re: lilypond-book on windows

On 11/01/2012 6:17 AM, Trevor Daniels wrote: Graham, you wrote Wednesday, January 11, 2012 10:43 AM Just as a quick check of the ridiculous: could you open up lilypond-book.py and confirm that line 213 is: stdout=subprocess.PIPE, stderr=subprocess.PIPE) there might be an off-by-one thing happe

Re: Build translated manuals: Don't rebuild everything each time unless necessary. (issue 5494069)

Please review. I tested make, make check, make doc, and do not get any problem. However, with the previous versions I also did not get any problem, yet I broke staging. I would be grateful if someone with a fast machine could test a parallel make doc. I would not be comfortable pushing to staging

Re: lilypond-book on windows

On 11/01/2012 9:42 AM, Trevor Daniels wrote: Julien Rioux I would try removing one-by-one the arguments from the subprocess.Popen call, e.g., remove universal_newlines=True, remove shell=True, remove stderr=subprocess.PIPE, etc. one-by-one. See if you get further. Yes, I tried this earlier

Re: Sketch of not remaking html files (issue 5498093)

On Wed, Jan 11, 2012 at 12:38 PM, Phil Holmes wrote: > - Original Message - From: > To: ; ; > ; > Cc: ; > Sent: Tuesday, January 10, 2012 1:34 PM > Subject: Re: Sketch of not remaking html files (issue 5498093) > > > >> Checking the file timestamps will be a good thing. It might be bett

Re: Build translated manuals: Don't rebuild everything each timeunless necessary. (issue 5494069)

On Wed, Jan 11, 2012 at 1:50 PM, Phil Holmes wrote: > - Original Message - From: > To: > Cc: ; > Sent: Wednesday, January 11, 2012 2:39 PM > Subject: Re: Build translated manuals: Don't rebuild everything each > timeunless necessary. (issue 5494069) > > >> Please review. I tested make,

Re: lilypond-book on windows

On 11/01/2012 7:46 PM, Reinhold Kainhofer wrote: On 2012-01-11 15:12, Julien Rioux wrote: One problem that exists here for sure for windows is the definition of cmd which include "LC_ALL=C texi2pdf ...". LC_ALL is an environment variable that sets the locale. I think this is here to e

Add a node prefix to snippets, preventing duplicate node errors (issue 2221). (issue 5541050)

Reviewers: , Message: Open for review. Description: Add a node prefix to snippets, preventing duplicate node errors (issue 2221). Please review this at http://codereview.appspot.com/5541050/ Affected files: M Documentation/snippets.tely M Documentation/snippets/ancient-notation-intro.itely

Undefined references in translated manuals (issue 2220). (issue 5539052)

Reviewers: , Message: Open for review. Description: Undefined references in translated manuals (issue 2220). Please review this at http://codereview.appspot.com/5539052/ Affected files: M Documentation/cs/learning/common-notation.itely M Documentation/cs/learning/fundamental.itely M Docu

Build: Strict error checking from makeinfo and texi2html (issue 2219). (issue 5554043)

Reviewers: , Description: Build: Strict error checking from makeinfo and texi2html (issue 2219). Run makeinfo and texi2html with --error-limit=0. Please review this at http://codereview.appspot.com/5554043/ Affected files: M make/doc-i18n-root-vars.make M stepmake/stepmake/texinfo-vars.mak

Re: Build: Strict error checking from makeinfo and texi2html (issue 2219). (issue 5554043)

Have you run make doc with these changes? -- Phil Holmes I did but forgot make check, so that will delay the review some more until errors are fixed there. Thanks, Julien http://codereview.appspot.com/5554043/ ___ lilypond-devel mailing list li

lilypond-book: Group line-width settings together (issue 2222). (issue 5553056)

Reviewers: Reinhold, Message: Please review. Description: lilypond-book: Group line-width settings together (issue ). Also, specify filename and ext for all snippets. Please review this at http://codereview.appspot.com/5553056/ Affected files: M python/book_snippets.py Index: python/b

lilypond-book: Fix links in texinfo output (issue 2224). (issue 5557056)

Reviewers: Reinhold, Message: Please review. Description: lilypond-book: Fix links in texinfo output (issue 2224). Also, specify filename and ext for all snippets. Please review this at http://codereview.appspot.com/5557056/ Affected files: M python/book_snippets.py M python/book_texinfo.

Re: lilypond-book: Group line-width settings together (issue 2222). (issue 5553056)

There were actually two issues. The second was discovered after fixing the first. I intend to push as two separate commits explaining each. http://codereview.appspot.com/5553056/diff/1/python/book_snippets.py File python/book_snippets.py (left): http://codereview.appspot.com/5553056/diff/1/pyth

Re: 2.16 release candidate 3 imminent

On 21/01/2012 11:19 AM, Graham Percival wrote: Unless any problem are found with the current countdown'ing patches, 2.15.27 release candidate 3 will probably come out on Monday. Once the fix for (lilypond-book fails with html input) is in, I'll fix 2223 (Regtests for lilypond-book are not

Re: lilypond-book: Group line-width settings together (issue 2222). (issue 5553056)

On Sat, Jan 21, 2012 at 4:18 PM, wrote: > On 2012/01/21 19:14:15, Julien Rioux wrote: >> >> Here was the first problem: line-width is being adjusted. This is written to >> the >> .ly file generated by lilypond-book, but it is not clear whether >> %(paper_string)

convert-ly: Better formatted error messages (issue 803). (issue 5564043)

Reviewers: , Message: Simpler formatting of convert-ly error messages, with improved partitioning of translatable parts. Description: convert-ly: Better formatted error messages (issue 803). Please review this at http://codereview.appspot.com/5564043/ Affected files: M python/convertrules.py

convert-ly: Handle malformed \version string (issue 2044). (issue 5563047)

Reviewers: , Message: Simple patch to issue a warning when the \version string is malformed. Description: convert-ly: Handle malformed \version string (issue 2044). Please review this at http://codereview.appspot.com/5563047/ Affected files: M scripts/convert-ly.py Index: scripts/convert-l

  1   2   3   >