Re: Renaming baseMoment

2024-10-04 Thread Dan Eble
On 2024-10-04 03:59, David Kastrup wrote: Saul Tobin writes: I can see duration vs. moment becoming a source of confusion, since these are not the same type. I would expect a property named baseDuration to take a value of type ly:duration?. Yup, but a duration has structural properties (ther

Re: Renaming baseMoment

2024-10-04 Thread Dan Eble
On 2024-10-04 19:30, David Kastrup wrote Since the compatibility properties are just for compatibility and would not be used by LilyPond itself, access to them can be checked in the failure paths since performance is of secondary consideration. ...> I'd probably bring them into existence with so

Re: Renaming baseMoment

2024-10-04 Thread Dan Eble
On 2024-10-02 19:48, Dan Eble wrote: To follow up the replacement of make-moment by \musicLength [1], I think it would make sense to rename baseMoment to beatBaseLength.  Are there any concerns or other suggestions? Taking all the feedback into account, I plan to prepare a patch renaming base

Re: Renaming baseMoment

2024-10-04 Thread Carl Sorensen
I love the idea of beatBase Carl On Fri, Oct 4, 2024, 4:28 PM Dan Eble wrote: > On 2024-10-02 19:48, Dan Eble wrote: > > To follow up the replacement of make-moment by \musicLength [1], I think > > it would make sense to rename baseMoment to beatBaseLength. Are there > > any concerns or other

Re: Renaming baseMoment

2024-10-04 Thread David Kastrup
Dan Eble writes: > On 2024-10-04 17:58, David Kastrup wrote: >> Dan Eble writes: >> >>> Taking all the feedback into account, I plan to prepare a patch >>> renaming baseMoment to beatBase. >> How about doing both rename and retyping to rational and keeping the >> old >> property as a Moment-typ

Re: Renaming baseMoment

2024-10-04 Thread David Kastrup
Saul Tobin writes: > I can see duration vs. moment becoming a source of confusion, since these > are not the same type. I would expect a property named baseDuration to take > a value of type ly:duration?. Yup, but a duration has structural properties (there are different durations with the same

Re: Renaming baseMoment

2024-10-04 Thread David Kastrup
Dan Eble writes: > On 2024-10-04 03:59, David Kastrup wrote: > >> This isn't one. What is more of an issue that a lot of properties >> taking a ly:moment? should rather be taking an exact rational >> (because they will never have grace parts), and the reason that they >> don't is that early vers

Re: Renaming baseMoment

2024-10-04 Thread David Kastrup
Dan Eble writes: > On 2024-10-02 19:48, Dan Eble wrote: >> To follow up the replacement of make-moment by \musicLength [1], I >> think it would make sense to rename baseMoment to beatBaseLength.  >> Are there any concerns or other suggestions? > > Taking all the feedback into account, I plan to p

PATCHES - Countdown to October 7th

2024-10-04 Thread Colin Campbell
Here is the current countdown report. The next countdown will begin on 2024-10-07 A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !2446 Use beat structure in \partial regression tests - Dan Eble     https://gitla

Re: Renaming baseMoment

2024-10-04 Thread Dan Eble
On 2024-10-04 17:58, David Kastrup wrote: Dan Eble writes: Taking all the feedback into account, I plan to prepare a patch renaming baseMoment to beatBase. How about doing both rename and retyping to rational and keeping the old property as a Moment-typed compatibility read/write accessor?