Hello,
On Sun, 1 Jul 2018 07:43:29 +0100, "David Kastrup" wrote:
> Paul Morris writes:
>
> > On 06/28/2018 03:35 AM, pkx166h wrote:
> >
> >> * *Patch*: countdown --> push
> >> * *Comment*:
> >>
> >> Patch counted down - please push
> >>
> >
> > I tried pushing my patch to staging and got t
Am 01.07.2018 um 09:55 schrieb James Lowe:
I don't know what the difference is between pull and fetch in terms of 'rights'
but I'd have thought it would be the same right?
Yes, the difference comes only on your own computer.
___
lilypond-devel m
Hello
On Sun, 1 Jul 2018 09:59:11 +0200, Urs Liska wrote:
>
>
> Am 01.07.2018 um 09:55 schrieb James Lowe:
> > I don't know what the difference is between pull and fetch in terms of
> > 'rights' but I'd have thought it would be the same right?
> >
>
> Yes, the difference comes only on your o
"James Lowe" writes:
> Hello
>
> On Sun, 1 Jul 2018 09:59:11 +0200, Urs Liska wrote:
>
>>
>>
>> Am 01.07.2018 um 09:55 schrieb James Lowe:
>> > I don't know what the difference is between pull and fetch in
>> > terms of 'rights' but I'd have thought it would be the same right?
>> >
>>
>> Yes,
Hello,
Here is the current patch countdown list. The next countdown will be on 4th
July.
A quick synopsis of all patches currently in the review process can be found
here:
http://philholmes.net/lilypond/allura/
Push:
5355 Doc: document grob metadata in SVG output in Notation Reference
Well, you basically anticipated all considerations I could have brought
up and dealt with them exhaustively.
LGTM
https://codereview.appspot.com/365730043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/l
In summary: at the current point of time the added complexity because of
the employed constructs does not make the impression of being a good
tradeoff for understanding and maintaining the code.
I think you need to define the goals you want to achieve, then focus on
the simplest way of implementi
On 2018/07/01 13:21:45, dak wrote:
NLGTM
Man, I use this stuff too rarely. Maybe
PTAL
https://codereview.appspot.com/344050043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
(initial feedback—more later)
https://codereview.appspot.com/344050043/diff/1/lily/global-context.cc
File lily/global-context.cc (right):
https://codereview.appspot.com/344050043/diff/1/lily/global-context.cc#newcode143
lily/global-context.cc:143: return score;
On 2018/07/01 13:21:42, dak wrote
https://codereview.appspot.com/344050043/diff/20001/lily/change-iterator.cc
File lily/change-iterator.cc (right):
https://codereview.appspot.com/344050043/diff/20001/lily/change-iterator.cc#newcode67
lily/change-iterator.cc:67: Context::warning_cannot_find (origin,
to_type, to_id);
On 2018/07/0
On 2018/07/01 16:48:09, Dan Eble wrote:
https://codereview.appspot.com/344050043/diff/20001/lily/change-iterator.cc
File lily/change-iterator.cc (right):
https://codereview.appspot.com/344050043/diff/20001/lily/change-iterator.cc#newcode67
lily/change-iterator.cc:67: Context::warning_cannot_
> On Jul 1, 2018, at 13:14, d...@gnu.org wrote:
>
> Something like
> origin->warning (_f ("Cannot find or create context: %s",
> ctx->identification ()))
Meh. Multiple callers would repeat the message “cannot find or create context”
which is part of what I was trying to avoid. I wouldn’t stake
On 2018/07/01 18:17:16, dan_faithful.be wrote:
> On Jul 1, 2018, at 13:14, mailto:d...@gnu.org wrote:
>
> Something like
> origin->warning (_f ("Cannot find or create context: %s",
> ctx->identification ()))
Meh. Multiple callers would repeat the message “cannot find or create
context”
whic
On Jul 1, 2018, at 15:08, d...@gnu.org wrote:
>
> We currently have
>
> dak@lola:/usr/local/tmp/lilypond$ git grep "find or create" lily
> lily/context.cc: warning (_f ("cannot find or create new `%s'",
> lily/context.cc: warning (_f ("cannot find or create `%s' called `%s'",
> dak@lola:/us
On 2018/07/01 14:09:28, Dan Eble wrote:
(initial feedback—more later)
https://codereview.appspot.com/344050043/diff/1/lily/global-context.cc
File lily/global-context.cc (right):
https://codereview.appspot.com/344050043/diff/1/lily/global-context.cc#newcode143
lily/global-context.cc:143: re
Dan Eble writes:
> On Jul 1, 2018, at 15:08, d...@gnu.org wrote:
>>
>> We currently have
>>
>> dak@lola:/usr/local/tmp/lilypond$ git grep "find or create" lily
>> lily/context.cc: warning (_f ("cannot find or create new `%s'",
>> lily/context.cc: warning (_f ("cannot find or create `%s' c
On 07/01/2018 02:43 AM, David Kastrup wrote:
Edit your .git/config file and change the repository address according
to the Git repository clone command given for developers on LilyPond's
Savannah page.
Thanks. It turned out I had a new SSH key that I hadn't added to
Savannah yet. So I got i
On Jul 1, 2018, at 16:40, d...@gnu.org wrote:
>
> Premature optimization is the root of all evil. I'm going to
> pontificate now in the hope that you'll have some opportunity in your
> work life to take karmatic revenge by passing this kind of "wisdom"
> on.
I sense some frustration. First, ple
18 matches
Mail list logo
