Re: music function to be included somewhere in scm/*

2016-12-20 Thread Knut Petersen
I'd advocate to keep minimum-length. I second the vote for collapse-length. Ok, next try: s/minimum-length/length-limit-or-forced-length/g (length-limit-or-forced-length ,ly:dimension? "An automatically generated lyric extender is suppressed if it would be shorter than this length. A

Re: music function to be included somewhere in scm/*

2016-12-20 Thread Werner LEMBERG
>> I second the vote for collapse-length. > > Ok, next try: > > s/minimum-length/length-limit-or-forced-length/g > > (length-limit-or-forced-length ,ly:dimension? "An automatically > generated lyric extender is suppressed if it would be shorter than > this length. A forced lyric extender is

Re: music function to be included somewhere in scm/*

2016-12-20 Thread Knut Petersen
Hi Werner! (length-limit-or-forced-length ,ly:dimension? "An automatically generated lyric extender is suppressed if it would be shorter than this length. A forced lyric extender is given this length if possible.") Sorry, but I strongly dislike collapsing two properties into one, even if t

Re: music function to be included somewhere in scm/*

2016-12-20 Thread Werner LEMBERG
> Nevertheless: two parameters would obfuscate the fact that the > internal logic would always decide to use only one of those lengths > and to ignore the other. You could add something like This parameter is mutually exclusive with @code{forced-length}. to make this more visible. > For the

Re: music function to be included somewhere in scm/*

2016-12-20 Thread Dan Eble
On Dec 20, 2016, at 08:23 , Werner LEMBERG wrote: > Sorry, but I strongly dislike collapsing two properties into one, even > if the values for the two properties are always the same. So please > use `collapse-length' (`suppress-threshold', etc.) and > `forced-length'. This is wise. — Dan

Re: music function to be included somewhere in scm/*

2016-12-20 Thread Paul
Hi Knut, Werner, Alexander, and everyone, On 12/20/2016 08:47 AM, Knut Petersen wrote: Hi Werner! (length-limit-or-forced-length ,ly:dimension? "An automatically generated lyric extender is suppressed if it would be shorter than this length. A forced lyric extender is given this length if

[PATCH] remove www from lilypond.org URL

2016-12-20 Thread Federico Bruni
Hi all I think that this is trivial enough that can skip the usual review. I was fixing the italian translation of macros.itexi when I noticed that we forgot to remove a www.lilypond.org link from the documentation (see commit 9580a231b3d3f912f46066009114a2929ecbb16a). The attached patch is b

Re: [PATCH] remove www from lilypond.org URL

2016-12-20 Thread Phil Holmes
Suggest you start a review as normal, so that patchy can test that there's nothing broken. Providing that passes OK, push straight to staging. -- Phil Holmes - Original Message - From: "Federico Bruni" To: Sent: Tuesday, December 20, 2016 3:48 PM Subject: [PATCH] remove www from l

Doc: remove www from lilypond.org URL (issue 312190043 by fedel...@gmail.com)

2016-12-20 Thread fedelogy
Reviewers: , Message: I've not included the italian file, because it's already fixed in the translation branch. Description: Doc: remove www from lilypond.org URL I've used this command: git grep -l "@uref{http://@/www@/.lilypond@/.org/}"; | xargs sed -i "s|http://@/www@/.lilypond@/.org/|http:

Re: music function to be included somewhere in scm/*

2016-12-20 Thread Abraham Lee
On Tue, Dec 20, 2016 at 7:41 AM, Paul wrote: > Hi Knut, Werner, Alexander, and everyone, > > On 12/20/2016 08:47 AM, Knut Petersen wrote: > >> Hi Werner! >> >>> (length-limit-or-forced-length ,ly:dimension? "An automatically generated lyric extender is suppressed if it would be shorter

Re: Point to \resetRelativeOctave in NR 1.1.1.b (issue 312210043 by simon.albre...@mail.de)

2016-12-20 Thread thomasmorley65
Some nitpicks, otherwise LGTM https://codereview.appspot.com/312210043/diff/20001/Documentation/notation/pitches.itely File Documentation/notation/pitches.itely (right): https://codereview.appspot.com/312210043/diff/20001/Documentation/notation/pitches.itely#newcode302 Documentation/notation/pi