Re: [PATCH] musicxml2ly: Avoid duplicate "tr" if both and, are present

2015-12-15 Thread James
Hello, On 13/12/15 21:48, Thomas Weber wrote: > In situations like this: > > > > > this will be created: > > \trill \startTrillSpan > > It should only be \startTrillSpan Ticket created at: https://sourceforge.net/rest/p/testlilyissues/issues/4698/ Thanks James

Re: [PATCH] musicxml2ly: Avoid duplicate "tr" if both and, are present

2015-12-15 Thread Urs Liska
Am 15.12.2015 um 09:06 schrieb James: > Ticket created at: > https://sourceforge.net/rest/p/testlilyissues/issues/4698/ http://sourceforge.net/p/testlilyissues/issues/4698/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/ma

Re: [PATCH] musicxml2ly: Make sure movement_title exists before using it

2015-12-15 Thread James
Hello, On 13/12/15 21:32, Thomas Weber wrote: > fixed problem and was generated by Sibelius' internal MusicXML export > functionality (not Dolet). Ticket created at: https://sourceforge.net/rest/p/testlilyissues/issues/4699/ Thanks James ___ lilypond

Re: context id

2015-12-15 Thread David Kastrup
Milan van der Meer writes: > the code (frescobaldi): > > #(define (format-note engraver event) > (let* ( > (context (ly:translator-context engraver)) > (ID (ly:context-id context)) > (parent (ly:context-parent context)) > (name (ly:context-name context) )

Re: [PATCH] musicxml2ly: Avoid duplicate "tr" if both and, are present

2015-12-15 Thread James
Thomas, On 13/12/15 21:48, Thomas Weber wrote: > Another patch for musicxml2ly: In situations like this: > > > > > this will be created: > > \trill \startTrillSpan > > It should only be \startTrillSpan. > > (My changes can also be found on Github: https://github.com/th-we/lilypond.)

Re: context id

2015-12-15 Thread Milan van der Meer
the code (frescobaldi): #(define (format-note engraver event) (let* ( (context (ly:translator-context engraver)) (ID (ly:context-id context)) (parent (ly:context-parent context)) (name (ly:context-name context) ) ) (display ID) (make-e

Add scheme procedure that gets paper column rank (issue 281020043 by paulwmor...@gmail.com)

2015-12-15 Thread paulwmorris
Reviewers: , Message: Please review. There is already a Paper_column::get_rank for C++ use, so I created a Scheme version alongside it, but I'm not sure if this is the best approach. I named the Scheme one "get_rank_number" to differentiate the two. Any suggestions are welcome. Background: I

Re: Add scheme procedure that gets paper column rank (issue 281020043 by paulwmor...@gmail.com)

2015-12-15 Thread dak
Not sure what you need it for. Would it be more generic to provide spanned_rank_interval ()? That should be defined for every grob. Probably also for paper columns? https://codereview.appspot.com/281020043/ ___ lilypond-devel mailing list lilypond-de

Re: Add scheme procedure that gets paper column rank (issue 281020043 by paulwmor...@gmail.com)

2015-12-15 Thread paulwmorris
On 2015/12/15 22:26:01, dak wrote: Not sure what you need it for. I was working on a Scheme rewrite of ly:ledger-line-spanner::print, to allow for some local customizations. It uses the rank of paper columns, namely, around line 210 in ledger-line-spanner.cc Direction vdir = Directi

Re: Add scheme procedure that gets paper column rank (issue 281020043 by paulwmor...@gmail.com)

2015-12-15 Thread paulwmorris
Some digging turned up: Grob::spanned_rank_interval in grob.cc Spanner::spanned_rank_interval in spanner.cc Item::spanned_rank_interval in item.cc with the latter two being more illuminating. So this would indeed work and be much more generic. Now to figure out how and where to implement a

PATCHES: Countdown for December the 19th

2015-12-15 Thread James
Hello, Here is the current patch countdown list. The next countdown will be on December the 19th. A quick synopsis of all patches currently in the review process can be found here: http://philholmes.net/lilypond/allura/ __ Push: 4688 Fix documentation of \once \partcombine* - dakas