Re: Anything wrong with patchy-staging?

2015-07-12 Thread David Kastrup
James Lowe writes: > On 11/07/15 17:07, David Kastrup wrote: >> >> Issue 4475 has been pushed about 3.5h ago to staging. I thought we >> had a Patchy-staging run about every 2 hours? Does this mean that >> there has been a failure? > > Yes or my Internet connection is broken! - although I thin

Patchy email

2015-07-12 Thread patchy
16:32:43 (UTC) Begin LilyPond compile, previous commit at ccad67c0a33e9b5d6e63ec8072f229026c777490 16:33:01 Merged staging, now at:ccad67c0a33e9b5d6e63ec8072f229026c777490 16:33:02Success:./autogen.sh --noconfigure 16:33:21Success:/tmp/

Re: Anything wrong with patchy-staging?

2015-07-12 Thread David Kastrup
James Lowe writes: > On 11/07/15 17:07, David Kastrup wrote: >> >> Issue 4475 has been pushed about 3.5h ago to staging. I thought we >> had a Patchy-staging run about every 2 hours? Does this mean that >> there has been a failure? >> >> Problem is that I'm likely off in about an hour, and if

Re: Doc: NR - 1.2.5 - Bar Numbers - added snippet (issue 106320046 by pkx1...@gmail.com)

2015-07-12 Thread pkx166h
https://codereview.appspot.com/106320046/diff/1/Documentation/snippets/new/printing-bar-numbers-with-changing-regular-intervals.ly File Documentation/snippets/new/printing-bar-numbers-with-changing-regular-intervals.ly (right): https://codereview.appspot.com/106320046/diff/1/Documentation/snippe

Re: Issue 4478: Disentangle some Tie and Semi_tie code. (issue 251840044 by nine.fierce.ball...@gmail.com)

2015-07-12 Thread nine . fierce . ballads
On 2015/07/12 00:27:14, Dan Eble wrote: lily/tie.cc:128: one_head = Semi_tie::head (item); Whoops. This should have been Semi_tie::head (item, d). I am almost sure this code is reachable only under conditions that are detected as programming errors elsewhere. Therefore I am not going to worry

GUB fail in mingw build - Issue 4462

2015-07-12 Thread Phil Holmes
I'm getting a failure to build GUB, as shown below: /home/gub/NewGub/gub/target/mingw/src/lilypond-git.sv.gnu.org--lilypond.git- release-unstable/lily/lily-modules.cc: In member function 'void Scm_module::import()': /home/gub/NewGub/gub/target/mingw/src/lilypond-git.sv.gnu.org--lilypond.git- rele

Re: GUB fail in mingw build - Issue 4462

2015-07-12 Thread David Kastrup
Phil Holmes writes: > I'm getting a failure to build GUB, as shown below: > > /home/gub/NewGub/gub/target/mingw/src/lilypond-git.sv.gnu.org--lilypond.git- > release-unstable/lily/lily-modules.cc: In member function 'void > Scm_module::import()': > /home/gub/NewGub/gub/target/mingw/src/lilypond-g

Table Of Contents crash with negative first-page-number (issue 258740043 by thomasmorle...@gmail.com)

2015-07-12 Thread thomasmorley65
Reviewers: , Description: Table Of Contents crash with negative first-page-number Issue 4494 Let \with-link point to the physical page-number Please review this at https://codereview.appspot.com/258740043/ Affected files (+20, -11 lines): M scm/define-markup-commands.scm Index: scm/define

Re: Table Of Contents crash with negative first-page-number (issue 258740043 by thomasmorle...@gmail.com)

2015-07-12 Thread dak
https://codereview.appspot.com/258740043/diff/1/scm/define-markup-commands.scm File scm/define-markup-commands.scm (right): https://codereview.appspot.com/258740043/diff/1/scm/define-markup-commands.scm#newcode542 scm/define-markup-commands.scm:542: (+ table-page-number (+ 1 (* -1 first-page-num

Issue 4496: RepeatTieColumn shouldn't call a Tie callback (issue 255110043 by nine.fierce.ball...@gmail.com)

2015-07-12 Thread nine . fierce . ballads
Reviewers: , Description: If anyone can explain that the lines I removed actually made sense, please do. Please review this at https://codereview.appspot.com/255110043/ Affected files (+0, -2 lines): M lily/semi-tie-column.cc M scm/define-grobs.scm Index: lily/semi-tie-column.cc diff --gi

Re: Table Of Contents crash with negative first-page-number (issue 258740043 by thomasmorle...@gmail.com)

2015-07-12 Thread thomasmorley65
On 2015/07/12 17:01:06, dak wrote: https://codereview.appspot.com/258740043/diff/1/scm/define-markup-commands.scm File scm/define-markup-commands.scm (right): https://codereview.appspot.com/258740043/diff/1/scm/define-markup-commands.scm#newcode542 scm/define-markup-commands.scm:542: (+ tabl

Re: Table Of Contents crash with negative first-page-number (issue 258740043 by thomasmorle...@gmail.com)

2015-07-12 Thread dak
On 2015/07/12 17:49:44, thomasmorley651 wrote: > Do the links actually work when first-page-number is, say, 10? yes > If so, did they > not work before? No, it was broken. Well, then we probably have to thank Ghostscript for bringing this long-standing problem to our attention. It ma

Re: Table Of Contents crash with negative first-page-number (issue 258740043 by thomasmorle...@gmail.com)

2015-07-12 Thread thomasmorley65
On 2015/07/12 18:09:03, dak wrote: On 2015/07/12 17:49:44, thomasmorley651 wrote: > > Do the links actually work when first-page-number is, say, 10? > > yes > > > If so, did they > > not work before? > > No, it was broken. Well, then we probably have to thank Ghostscript for bringing this

Re: Table Of Contents crash with negative first-page-number (issue 258740043 by thomasmorle...@gmail.com)

2015-07-12 Thread thomasmorley65
On 2015/07/12 20:58:41, thomasmorley651 wrote: On 2015/07/12 18:09:03, dak wrote: > It may be worth trying if this makes the rather awkward fix for issue 3388 > unnecessary, but I would guess that the problem is likely sufficiently different > that that fix is still needed. As far as I

Provide music functions property-{override,revert,set,unset} (issue 251130043 by d...@gnu.org)

2015-07-12 Thread dak
Reviewers: , Message: Well, the consideration for choosing a hyphenated name here instead of camel case (namely property-override instead of propertyOverride) was that the main usage was from Scheme anyway. But since it is a proper music function nevertheless, I now tend to think that I should n

Re: Table Of Contents crash with negative first-page-number (issue 258740043 by thomasmorle...@gmail.com)

2015-07-12 Thread dak
On 2015/07/12 17:49:44, thomasmorley651 wrote: On 2015/07/12 17:01:06, dak wrote: > https://codereview.appspot.com/258740043/diff/1/scm/define-markup-commands.scm > File scm/define-markup-commands.scm (right): > > https://codereview.appspot.com/258740043/diff/1/scm/define-markup-commands.scm#

Re: Table Of Contents crash with negative first-page-number (issue 258740043 by thomasmorle...@gmail.com)

2015-07-12 Thread thomasmorley65
On 2015/07/12 23:39:52, dak wrote: On 2015/07/12 17:49:44, thomasmorley651 wrote: > On 2015/07/12 17:01:06, dak wrote: > > https://codereview.appspot.com/258740043/diff/1/scm/define-markup-commands.scm > > File scm/define-markup-commands.scm (right): > > > > > https://codereview.appspot.com/

Re: Provide music functions property-{override,revert,set,unset} (issue 251130043 by d...@gnu.org)

2015-07-12 Thread benko . pal
that's fabulous, thanks! https://codereview.appspot.com/251130043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel