Add Scheme function to return column associated with Item. (issue 203910043 by david.nales...@gmail.com)

Reviewers: , Message: Please review. Description: Add Scheme function to return column associated with Item. The C++ function PaperColumn::get_column is used frequently, and it makes sense to have a Scheme function which performs the same task. An example of a practical application is the requ

Re: Add Scheme function to return column associated with Item. (issue 203910043 by david.nales...@gmail.com)

Can't judge the code but the idea looks great :-) Urs Am 15. Februar 2015 08:27:20 EST, schrieb david.nales...@gmail.com: >Reviewers: , > >Message: >Please review. > >Description: >Add Scheme function to return column associated with Item. > >The C++ function PaperColumn::get_column is used frequ

Re: Making flat flags available (issue 14303044)

'using-alternative-flag-styles.ly' is not in Documentation/snippets/new/ any more. I changed it directly in LSR. The changed snippet will show up after next LSR-import. Looks I can't post to the tracker-issue for 3591 any more, because it's closed. https://codereview.appspot.com/14303044/ _

Re: Add Scheme function to return column associated with Item. (issue 203910043 by david.nales...@gmail.com)

On Sun, Feb 15, 2015 at 7:58 AM, Urs Liska wrote: > Can't judge the code but the idea looks great :-) > > Thanks--I'm noticing that bits of code get reused on the lists, so there's a need. This will help tuck away some of the code gobbledygook that is so off-putting.. It occurs to me that it s

Re: Add Scheme function to return column associated with Item. (issue 203910043 by david.nales...@gmail.com)

2015-02-15 18:50 GMT+01:00 David Nalesnik : > On Sun, Feb 15, 2015 at 7:58 AM, Urs Liska wrote: > >> Can't judge the code but the idea looks great :-) >> >> > Thanks--I'm noticing that bits of code get reused on the lists, so there's > a need. This will help tuck away some of the code gobbledygo

Re: Add Scheme function to return column associated with Item. (issue 203910043 by david.nales...@gmail.com)

2015-02-15 19:28 GMT+01:00 Thomas Morley : > 2015-02-15 18:50 GMT+01:00 David Nalesnik : >> On Sun, Feb 15, 2015 at 7:58 AM, Urs Liska wrote: >> >>> Can't judge the code but the idea looks great :-) >>> >>> >> Thanks--I'm noticing that bits of code get reused on the lists, so there's >> a need.

Re: Add Scheme function to return column associated with Item. (issue 203910043 by david.nales...@gmail.com)

Hi Harm, On Sun, Feb 15, 2015 at 12:28 PM, Thomas Morley wrote: > > > Some time ago I wrote a more generic code: > > #(define (look-up-for-parent name-symbol axis grob) > " > Return the parent of @var{grob}, specified by it's @var{name-symbol} in > axis @var{axis}. > If not found, look up for

Re: Add Scheme function to return column associated with Item. (issue 203910043 by david.nales...@gmail.com)

On Sun, Feb 15, 2015 at 12:34 PM, Thomas Morley wrote: > 2015-02-15 19:28 GMT+01:00 Thomas Morley : > > > Oops, definition for 'grob-name' is missing: > > #(define grob-name > (lambda (x) > (if (ly:grob? x) > (assq-ref (ly:grob-property x 'meta) 'name) > (ly:error "~a is n

Make Grob::name accessible to Scheme (issue 203090043 by david.nales...@gmail.com)

Reviewers: , Message: Please review. Thanks! Description: Make Grob::name accessible to Scheme Needing to determine the name of a grob is extremely common to users of Scheme. Please review this at https://codereview.appspot.com/203090043/ Affected files (+11, -0 lines): M lily/grob-scheme.

Re: Add Scheme function to return column associated with Item. (issue 203910043 by david.nales...@gmail.com)

On Sun, Feb 15, 2015 at 1:14 PM, David Nalesnik wrote: > > > Now, a function to get a grob's name would certainly be useful. I'm sick > to death of constantly recreating it or looking it up (as I bet you are)! > If there's a question of usefulness, I think we've established the need... > > The be

Re: Add Scheme function to return column associated with Item. (issue 203910043 by david.nales...@gmail.com)

2015-02-15 20:14 GMT+01:00 David Nalesnik : > > > On Sun, Feb 15, 2015 at 12:34 PM, Thomas Morley > wrote: >> >> 2015-02-15 19:28 GMT+01:00 Thomas Morley : > > >> >> >> Oops, definition for 'grob-name' is missing: >> >> #(define grob-name >> (lambda (x) >> (if (ly:grob? x) >> (assq-r

Re: Add Scheme function to return column associated with Item. (issue 203910043 by david.nales...@gmail.com)

2015-02-15 20:56 GMT+01:00 David Nalesnik : > > On Sun, Feb 15, 2015 at 1:14 PM, David Nalesnik > wrote: >> >> >> Now, a function to get a grob's name would certainly be useful. I'm sick >> to death of constantly recreating it or looking it up (as I bet you are)! >> If there's a question of usefu

Re: Add Scheme function to return column associated with Item. (issue 203910043 by david.nales...@gmail.com)

Harm, On Sun, Feb 15, 2015 at 2:42 PM, Thomas Morley wrote: > > Can't review C++, so I'll not post there. > There IS something you can help with, though. In the patch as it stands, I'm simply making Grob::name available through Scheme. It thus returns a string. (Grob::name actually converts

Re: Make Grob::name accessible to Scheme (issue 203090043 by david.nales...@gmail.com)

On 2015/02/15 19:54:19, david.nalesnik wrote: Please review. Thanks! "Needing to determine the name of a grob" should actually rarely be necessary: the pervasive information connected to the functionality of a grob is rather its interfaces. That's the usual criterion for deciding whether to d