Re: Uses single algorithm for side-position spacing. (issue 6827072)

2012-11-18 Thread m...@mikesolomon.org
On 18 nov. 2012, at 00:19, k-ohara5...@oco.net wrote: > On 2012/11/14 07:12:46, mike7 wrote: >> > lily/axis-group-interface.cc:403: Axis_group_interface::cross_staff > (SCM >> > smob) >> > For what situation? Which object that supports > axis-group-interface >> > (PianoPedalSpanner, DynamicLine

Re: Uses single algorithm for side-position spacing. (issue 6827072)

2012-11-18 Thread m...@mikesolomon.org
On 18 nov. 2012, at 00:55, k-ohara5...@oco.net wrote: > I haven't gotten so far to see the main point, yet. > The main point is: 1) Unify all side spacing into one algorithm (this patch). In addition to fixing several fingering bugs, this helps... 2) Eventually eliminate the translate axis ca

Re: Uses single algorithm for side-position spacing. (issue 6827072)

2012-11-18 Thread Keith OHara
On Sun, 18 Nov 2012 08:10:49 -0800, m...@mikesolomon.org wrote: On 18 nov. 2012, at 00:55, k-ohara5...@oco.net wrote: http://codereview.appspot.com/6827072/diff/11002/lily/box-quarantine.cc#newcode70 lily/box-quarantine.cc:70: return fabs (ii0.index_ - mid) < fabs (ii1.index_ - mid); This

Re: Uses single algorithm for side-position spacing. (issue 6827072)

2012-11-18 Thread m...@mikesolomon.org
On 18 nov. 2012, at 21:06, Keith OHara wrote: >>> >> >> Try running beam-cross-staff-script.ly with my patch and setting >> NoteColumn.cross-staff to ##f. You'll see that it triggers beam slope >> calculations before vertical spacing is done on the staves because >> NoteColumn, which is a

markup-commands rest-by-number and rest (issue 6850073)

2012-11-18 Thread thomasmorley65
Reviewers: , Message: Please review Description: markup-commands rest-by-number and rest Introduces two new markup-commands: rest-by-number and rest similiar to the existing note-by-number and note. Two regression-tests for them are added. Please review this at http://codereview.appspot.com/68

Re: markup-commands rest-by-number and rest (issue 6850073)

2012-11-18 Thread Thomas Morley
2012/11/19 : > Reviewers: , > > Message: > Please review > > Description: > markup-commands rest-by-number and rest > > Introduces two new markup-commands: > rest-by-number and rest > similiar to the existing note-by-number and note. > Two regression-tests for them are added. > > Please review thi

Re: markup-commands rest-by-number and rest (issue 6850073)

2012-11-18 Thread Colin Campbell
On 11/18/2012 04:54 PM,c wrote: Reviewers: , Message: Please review To help this get formal attention, Harm, I've created an issue on our tracker, with reference to your Rietveld item. We strongly encorage developers to use the git-cl tool for uploading patches, as it takes care of the con

Re: markup-commands rest-by-number and rest (issue 6850073)

2012-11-18 Thread Thomas Morley
2012/11/19 Colin Campbell : > On 11/18/2012 04:54 PM,c wrote: [...] > To help this get formal attention, Harm, I've created an issue on our > tracker, with reference to your Rietveld item. Thanks for doing this. > We strongly encorage > developers to use the git-cl tool for uploading patches, as

Re: Uses single algorithm for side-position spacing. (issue 6827072)

2012-11-18 Thread Keith OHara
On Sun, 18 Nov 2012 12:21:51 -0800, m...@mikesolomon.org wrote: if (to_boolean (me->get_property ("add-stem-support")) && Stem::has_interface (e)) skyline.set_min_height (e->extent (common_y, _Y_AXIS)[dir]); That's pseudo-code, but do you get the idea? Does that seem reasonable? Depend

PATCH: Countdown to 20121120

2012-11-18 Thread Colin Campbell
In fact, there seem to be no patches ready for countdown. In fact, as one of my choirs starts a performance schedule of 47 hospitals, extended care facilities, and elderly persons homes from next weekend until the 16th of December, I will find it a bit of a challenge keeping up the Sunday patc

Re: markup-commands rest-by-number and rest (issue 6850073)

2012-11-18 Thread lemzwerg
http://codereview.appspot.com/6850073/diff/1/scm/define-markup-commands.scm File scm/define-markup-commands.scm (right): http://codereview.appspot.com/6850073/diff/1/scm/define-markup-commands.scm#newcode3341 scm/define-markup-commands.scm:3341: breve, longa and maxima are valid input-strings Th