LGTM
Trevor
http://codereview.appspot.com/6813079/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
http://codereview.appspot.com/6584045/diff/1/lily/beam.cc
File lily/beam.cc (right):
http://codereview.appspot.com/6584045/diff/1/lily/beam.cc#newcode197
lily/beam.cc:197: Grob *me = unsmob_grob (smob);
Looking at the combination of this and is_kievan, it would appear that
the expected response
On 3 nov. 2012, at 12:26, d...@gnu.org wrote:
>
> http://codereview.appspot.com/6584045/diff/1/lily/beam.cc
> File lily/beam.cc (right):
>
> http://codereview.appspot.com/6584045/diff/1/lily/beam.cc#newcode197
> lily/beam.cc:197: Grob *me = unsmob_grob (smob);
> Looking at the combination of thi
On 2012/11/03 11:37:08, mike7 wrote:
On 3 nov. 2012, at 12:26, mailto:d...@gnu.org wrote:
>
> http://codereview.appspot.com/6584045/diff/1/lily/beam.cc
> File lily/beam.cc (right):
>
> http://codereview.appspot.com/6584045/diff/1/lily/beam.cc#newcode197
> lily/beam.cc:197: Grob *me = unsmob_gr
Hi Harm,
On Thu, Nov 1, 2012 at 9:57 AM, Thomas Morley
wrote:
> Hi David (N),
>
> attached my first try.
>
> If the markup-property full-length is set #t, some calculations ensure
> that no space occurs at line-end/begin. Some dashes will only be
> partly visible, but I think its ok.
> In additi
Hi,
I have just been merging translation into stable (after checking
compilation, tests, and documentation). I am not totally happy with
2.16.1: we still have non-convergence on the line-count stuff (which I
will leave in its current state), and it is conceivable that there is
some regression co
- Original Message -
From: "David Kastrup"
To:
Sent: Saturday, November 03, 2012 4:07 PM
Subject: Releases 2.17.6 and 2.16.1
Hi,
I have just been merging translation into stable (after checking
compilation, tests, and documentation). I am not totally happy with
2.16.1: we still ha
Hi John and all,
I just noticed that, because the out of tree build, lilypond.pot gets
polluted by personal path, what does not happen with an "in tree" build.
e.g. we get, when "out of tree" :
#: parser.yy:174 parser.yy:188 /home/jcharles/GIT/Mentor/lily/parser.yy:174
#: /home/jcharles/GIT/Men
On 3 nov. 2012, at 12:26, d...@gnu.org wrote:
> http://codereview.appspot.com/6584045/diff/12001/lily/stem.cc#newcode812
> lily/stem.cc:812: Real beg = robust_scm2double (me->get_pure_property
> ("stem-begin-position", 0, INT_MAX), 0.0);
> Using robust_scm2double does not help when me is 0. This
On 3 nov. 2012, at 12:26, d...@gnu.org wrote:
> http://codereview.appspot.com/6584045/diff/1/scm/output-lib.scm#newcode85
> scm/output-lib.scm:85: (left-height (if (= direction DOWN)
> Is direction sure to be non-null?
>
Thanks again for the review. Aleksandr can respond to this better than I
> janek.lilyp...@gmail.com:
>
> Ah, so \language "español" will do the same as \language "espanol"?
> That's nice.
>
> http://codereview.appspot.com/__6811060/
As far as I see, there is no language "french" or "français".
Would it be an idea to add "french", "francais" and "français" as
aliases
On Sat, Nov 03, 2012 at 04:29:53PM -, Phil Holmes wrote:
> I finished building 2.17.6 about 30 minutes ago. Gub failed again,
> but I know how to fix this manually and have done so, so it's ready
> for upload.
I suggest a moratorium on releases until GUB works. Too many
things can go wrong w
On Fri, Nov 2, 2012 at 10:20 PM, Marc Hohl wrote:
> Am 02.11.2012 09:58, schrieb janek.lilyp...@gmail.com:
>> http://codereview.appspot.com/6813044/diff/6001/lily/clef-engraver.cc#newcode125
>> lily/clef-engraver.cc:125: if (ly_is_procedure (formatter))
>> it seems that octavation won't work at al
> janek.lilyp...@gmail.com:
>
> Ah, so \language "español" will do the same as \language "espanol"?
> That's nice.
>
> http://codereview.appspot.com/__6811060/
As far as I see, there is no language "french" or "français".
Would it be an idea to add "french", "francais" and "français" as
aliases
Joram Berger writes:
>> janek.lilyp...@gmail.com:
>>
>> Ah, so \language "español" will do the same as \language "espanol"?
>> That's nice.
>>
>> http://codereview.appspot.com/__6811060/
>
> As far as I see, there is no language "french" or "français".
> Would it be an idea to add "french", "f
Joram Berger wrote
> As far as I see, there is no language "french" or "français".
> Would it be an idea to add "french", "francais" and "français" as
> aliases to "italiano" (like "español" above)?
do you really want to add /francais/?
Eluze
--
View this message in context:
http://lilypond.10
Eluze writes:
> Joram Berger wrote
>> As far as I see, there is no language "french" or "français".
>> Would it be an idea to add "french", "francais" and "français" as
>> aliases to "italiano" (like "español" above)?
>
> do you really want to add /francais/?
It's not likely more scary to the Fr
Am 04.11.2012 01:36, schrieb David Kastrup:
> Eluze writes:
>> do you really want to add /francais/?
>
> It's not likely more scary to the French than "espanol" is to the
> Spanish. Basically there are two options making sense to me: native
> language name in utf-8, or English language name ("fr
Am 04.11.2012 00:17, schrieb David Kastrup:
> Joram Berger writes:
>> Would it be an idea to add … "français" as aliases to "italiano"?
>>
>> According to my knowledge in French, the note names are the same and
>> bémol/dièse also fits with the Italian abbreviations -b/-d.
>
> I think they may
19 matches
Mail list logo
