Re: casual contributors

On Fri, Mar 23, 2012 at 07:44:45AM +0100, David Kastrup wrote: > Graham Percival writes: > > > We need a *secretary*. We need a *paper pusher*. We need a > > trained monkey. I could even teach a first-year university > > student how to be a perfect Frog meister, and having taught for a > > few

Re: Corrected style of comments (issue 5862052)

This patch adds helpful comments. http://codereview.appspot.com/5862052/diff/1/flower/include/direction.hh File flower/include/direction.hh (right): http://codereview.appspot.com/5862052/diff/1/flower/include/direction.hh#newcode77 flower/include/direction.hh:77: * Thanks to a #define below, in

Re: Issue 1320: Rewriting bar-line::print

Am 21.03.2012 21:39, schrieb Nicolas Sceaux: Le 20 mars 2012 à 09:39, Marc Hohl a écrit : Hello list, I want to rewrite most if not all definitions currently settled in lily/bar-line.cc in scheme. Please see the attached file for my progress so far; I don't get any error messages, but no bar

Re: casual contributors

Graham Percival writes: > On Fri, Mar 23, 2012 at 07:44:45AM +0100, David Kastrup wrote: >> Graham Percival writes: >> >> > We need a *secretary*. We need a *paper pusher*. We need a >> > trained monkey. I could even teach a first-year university >> > student how to be a perfect Frog meister

Re: casual contributors

Graham Percival writes: > On Fri, Mar 23, 2012 at 07:44:45AM +0100, David Kastrup wrote: >> Graham Percival writes: >> >> > We need a *secretary*. We need a *paper pusher*. We need a >> > trained monkey. I could even teach a first-year university >> > student how to be a perfect Frog meister

Re: Corrected style of comments (issue 5862052)

On 22 March 2012 15:43, wrote: > Are the changes to .gitignore intentional? > > http://codereview.appspot.com/**5862052/ > Ooops, changes - yes, placing them in the patch - of course no. Łukasz ___ lilypond-deve

Re: lilypond-book: Set include path for --output option (issue 2423). (issue 5846075)

On Fri, Mar 23, 2012 at 4:33 AM, wrote: > I'm seeing "old chunk mismatch" for this patch.  Could you try uploading > it again to a new rietveld issue? > > http://codereview.appspot.com/5846075/ Fixed, it was a bad upload (no need for a new issue number).

Re: Tracks old announcements, news and changelogs. (issue 5843069)

On Fri, Mar 23, 2012 at 5:12 AM, wrote: > Awesome work as always.  There's some unintended (and bad) changes to > GNUmakefile.in. > That's a mistake when I uploaded (pointing to the wrong commit in git-cl upload). Just trust me that I won't commit this, but I am not uploading again in order to g

Re: Don't reload initialization files when processing multiple files (issue 5874044)

LGTM http://codereview.appspot.com/5874044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: casual contributors

On 12-03-23 12:28 AM, Graham Percival wrote: We need a *secretary*. We need a *paper pusher*. We need a trained monkey. I could even teach a first-year university student how to be a perfect Frog meister, and having taught for a few years you have no idea how low my opinion of those creatur

Re: casual contributors

Colin Campbell writes: > On 12-03-23 12:28 AM, Graham Percival wrote: > >> I cannot emphasize how little I want from the frog meister, other >> than keeping up with email on a daily basis and looking at the >> countdown when it finishes three times a week. > > I could take it on, Graham, especial

Add an example implementation of cross-staff stems (issue 5882053)

Reviewers: , Message: This is also the first use of a scheme engraver in input/regression. Description: Add an example implementation of cross-staff stems Please review this at http://codereview.appspot.com/5882053/ Affected files: A input/regression/stem-cross-staff-engraver.ly _

Re: casual contributors

On 12-03-23 06:42 AM, David Kastrup wrote: Colin Campbell writes: On 12-03-23 12:28 AM, Graham Percival wrote: I cannot emphasize how little I want from the frog meister, other than keeping up with email on a daily basis and looking at the countdown when it finishes three times a week. I co

Re: Add an example implementation of cross-staff stems (issue 5882053)

http://codereview.appspot.com/5882053/diff/2001/input/regression/stem-cross-staff-engraver.ly File input/regression/stem-cross-staff-engraver.ly (right): http://codereview.appspot.com/5882053/diff/2001/input/regression/stem-cross-staff-engraver.ly#newcode100 input/regression/stem-cross-staff-eng

Re: Add an example implementation of cross-staff stems (issue 5882053)

On 2012/03/23 13:04:19, Pavel Roskin wrote: This is also the first use of a scheme engraver in input/regression. Apart from scheme-engraver.ly, scheme-engraver-instance.ly, and scheme-text-spanner.ly. http://codereview.appspot.com/5882053/ ___ lilyp

Re: Tracks old announcements, news and changelogs. (issue 5843069)

On Fri, Mar 23, 2012 at 12:22:59PM +0100, Julien Rioux wrote: > On Fri, Mar 23, 2012 at 5:12 AM, wrote: > > Awesome work as always.  There's some unintended (and bad) changes to > > GNUmakefile.in. > > That's a mistake when I uploaded (pointing to the wrong commit in > git-cl upload). Just trust

Re: casual contributors

On Fri, Mar 23, 2012 at 11:11:21AM +0100, David Kastrup wrote: > Graham Percival writes: > > > But hey, it's my job to teach them > > at whatever level they're at, right? > > Nope. It is your job to teach them from the level they should have left > high school with. After two terms of electric

Re: casual contributors

On Fri, Mar 23, 2012 at 06:36:43AM -0600, Colin Campbell wrote: > On 12-03-23 12:28 AM, Graham Percival wrote: > > >We need a *secretary*. We need a *paper pusher*. We need a trained > >monkey. > > I could take it on, Graham, especially if the countdown process gets > automated. I read -user, -d

Re: casual contributors

Graham Percival writes: > On Fri, Mar 23, 2012 at 11:11:21AM +0100, David Kastrup wrote: >> Graham Percival writes: >> >> > But hey, it's my job to teach them >> > at whatever level they're at, right? >> >> Nope. It is your job to teach them from the level they should have left >> high school

Re: casual contributors

On Fri, Mar 23, 2012 at 05:26:11PM +0100, David Kastrup wrote: > Graham Percival writes: > > That was about the failure rate in the Theoretical Electrotechnics and > the Electronic Parts exams. ... > Parts of the process > were ridiculous, and sort of a competition in ugliness among professors >

Re: casual contributors

Graham Percival writes: > On Fri, Mar 23, 2012 at 05:26:11PM +0100, David Kastrup wrote: > >> The definition of a customer for me is a person receiving something >> valuable. A person merely believing to receive something valuable is >> a sucker instead. > > Oh, they *are* receiving something va

Re: casual contributors

On Fri, Mar 23, 2012 at 8:06 PM, David Kastrup wrote: > "What impressed you most about the LilyPond code base?"  "No comment." > "But I really want to know!" "I just told you." LOL!! That's a quote-of-the-month! Janek :D ___ lilypond-devel mailing lis

Re: casual contributors

On Fri, Mar 23, 2012 at 08:06:23PM +0100, David Kastrup wrote: > > Engineering student numbers have dropped significantly > at my former university, and it is to be expected that standards were > adjusted downwards in order to get enough students back (we have state > education almost exclusively,

Re: volunteer for patchy new-patches

I've succeeded in building lilypond. :) test-patches.py says: No new patches to test. What are my next steps? Marek ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: volunteer for patchy new-patches

On Fri, Mar 23, 2012 at 10:31:20PM +0100, Marek Klein wrote: >I've succeeded in building lilypond. :) >test-patches.py says: No new patches to test. >What are my next steps? I've just set issue 2216 to Patch-new, so try running it again. - Graham _

Re: volunteer for patchy new-patches

2012/3/23 Graham Percival > On Fri, Mar 23, 2012 at 10:31:20PM +0100, Marek Klein wrote: > >I've succeeded in building lilypond. :) > >test-patches.py says: No new patches to test. > >What are my next steps? > > I've just set issue 2216 to Patch-new, so try running it again. > > Tryin

Re: Add an example implementation of cross-staff stems (issue 5882053)

OK, I'll use make-engraver in the next revision. I guess I'll need to strip all Lilypond 2.14 compatibility stuff if this snippet is to be a part of the Lilypond documentation. I missed scheme engravers because I was looking for "\consists #" on one line, my bad. http://codereview.appspot.com/5

Re: volunteer for patchy new-patches

On Fri, Mar 23, 2012 at 10:42:54PM +0100, Marek Klein wrote: >Exception: Command 'git fetch' returned non-zero exit status 128 >error: insufficient permission for adding an object to repository >database .git/objects >fatal: failed to write object >fatal: unpack-objects failed

Re: patch going unpushed

Hi Graham, > "Graham" == Graham Percival writes: Graham> We don't really have a frog meister, so nobody is taking Graham> responsibility for pushing I have another patch waiting, that depends on the first. Is there supposed to be a procedure for casual contributers to follow? The other o

Change all occurences of "echo -n" to "printf" for portability (issue 5903046)

http://codereview.appspot.com/5903046/diff/1/scripts/build/install-info-html.sh File scripts/build/install-info-html.sh (right): http://codereview.appspot.com/5903046/diff/1/scripts/build/install-info-html.sh#newcode129 scripts/build/install-info-html.sh:129: printf "$name: Writing index: $index

Re: Change all occurences of "echo -n" to "printf" for portability (issue 5903046)

http://codereview.appspot.com/5903046/diff/1/smart-autogen.sh File smart-autogen.sh (right): http://codereview.appspot.com/5903046/diff/1/smart-autogen.sh#newcode16 smart-autogen.sh:16: printf $AUTOGEN_INPUT_CHECKSUM > $CHECKSUM_FILE On 2012/03/24 06:00:52, dak wrote: I'd prefer "%s" "$AUTOGEN_