Re: Glyphs for Kievan Notation (issue 4951062)

2012-01-23 Thread Neil Puttock
On 23 January 2012 01:02, wrote: > Regarding comments by Neil and Bertrand: > > I rewrote Stem::is_normal_stem the way Neil suggested. Looking at the > code in Stem.cc, it appears that both ways are being used to check the > style property. I don't know which is the more correct. Strictly speak

Re: Implements DOM-id property for grobs. (issue 5504106)

2012-01-23 Thread mtsolo
Reviewers: Patrick McCarty, dak, mike_apollinemike.com, janek, http://codereview.appspot.com/5504106/diff/11013/lily/grob.cc File lily/grob.cc (right): http://codereview.appspot.com/5504106/diff/11013/lily/grob.cc#newcode177 lily/grob.cc:177: SCM expr = scm_list_3 (ly_symbol2scm ("id"), On 2012

Run regression tests for lilypond-book (issue 2223). (issue 5569045)

2012-01-23 Thread julien . rioux
Reviewers: , Message: Please review. Description: Run regression tests for lilypond-book (issue 2223). Re-enable running the regtests in input/regression/lilypond-book. Fix various typos, clarify what each input file tests for and how the output should look, and fix the following problems: col

Re: Spelling fixes in comments and documentation (issue 5562043)

2012-01-23 Thread janek . lilypond
LGTM http://codereview.appspot.com/5562043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: User vs Developer: Round 2 (and half-time?) (was: Re: music font)

2012-01-23 Thread Janek WarchoĊ‚
Dear Xavier, hereby i'd like to thank you for your time spent on helping LilyPond! It's true that user's work often is not appreciated enough. 2012/1/23 Xavier Scheuer : > Dear Graham, dear Developers, > why I never *demand* > developers to fix an issue, even if it is one that is really annoying

Doc: NR 5.5.5 Adv tweaks - Unpure-pure containers (issue 5569050)

2012-01-23 Thread mtsolo
Looks good! Much more user-understandable than anything I could have ever come up with :) http://codereview.appspot.com/5569050/diff/1/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): http://codereview.appspot.com/5569050/diff/1/Docume

Re: Doc: NR 5.5.5 Adv tweaks - Unpure-pure containers (issue 5569050)

2012-01-23 Thread pkx166h
Reviewers: MikeSol, http://codereview.appspot.com/5569050/diff/1/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): http://codereview.appspot.com/5569050/diff/1/Documentation/notation/changing-defaults.itely#newcode3714 Documentation/nota