Re: Adds padding between Hairpins and SpanBars. (issue 5438060)

On Mon, 28 Nov 2011 23:38:28 -0800, m...@apollinemike.com wrote: Could you post some PDFs of the patch in action? There's an example at Just reading the code, with respect to: if (bound->is_non_musical (bound) || bound->break_statu

Re: Adds padding between Hairpins and SpanBars. (issue 5438060)

passes make and make check james http://codereview.appspot.com/5438060/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

plan for Dec: automation

Ok, I'm back in civilization, I've spent the weekend doing renovation both in terms of furniture, computer hardware, and computer software. Two hard drives (850 megs and 5 gigs) have been demolished in my quest for powerful household magnets, and I have a new mac mini with ubuntu, which puts me in

hairpin.cc: space at end-of-line same as at bar lines (issue 5373048)

passes make and make check james http://codereview.appspot.com/5373048/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Adds padding between Hairpins and SpanBars. (issue 5438060)

On Mon, 28 Nov 2011 23:38:28 -0800, m...@apollinemike.com wrote: In the original report, my eyes zoomed directly to the second system, last measure (which my patch fixes). Just to be clear, the one-line fix linked to issue 2060 fixes that original report as well. I see what you mean tha

Re: rebasing inside staging

ARGH. My bad :-( Really sorry guys. It's very simple what happened, and in fact you already know most of it: - There was a long period of time in between the completion of the review and pushing to staging, due to my misunderstanding of the development process (which I will partially

Re: Allows for automatic renumbering of measure numbers at volta repeats. (issue 5440049)

I'll just say to all you haters of `renvoi' that: --) There is no English term that I know of that succinctly expresses the idea of "being sent back to something." And, as new terms are invented out of necessity, I took the liberty to invent one here with `renvoi,' which Jankélévitch (musicologi

Re: Allows for automatic renumbering of measure numbers at volta repeats. (issue 5440049)

mts...@gmail.com writes: > I'll just say to all you haters of `renvoi' that: > > --) There is no English term that I know of that succinctly expresses > the idea of "being sent back to something." "returned" -- David Kastrup ___ lilypond-devel maili

Re: Allows for automatic renumbering of measure numbers at volta repeats. (issue 5440049)

On Nov 29, 2011, at 1:13 PM, David Kastrup wrote: > mts...@gmail.com writes: > >> I'll just say to all you haters of `renvoi' that: >> >> --) There is no English term that I know of that succinctly expresses >> the idea of "being sent back to something." > > "returned" > I meant noun. And ev

Re: Allows for automatic renumbering of measure numbers at volta repeats. (issue 5440049)

On Nov 29, 2011, at 1:08 PM, mts...@gmail.com wrote: > > The only problem that remains is that the display-lily-tests shows a > one-space increase in the new output. I've made the string rendered for > AlternativeEvent "", but is there any way just to get the display method > to ignore it (meani

Re: Allows for automatic renumbering of measure numbers at volta repeats. (issue 5440049)

"m...@apollinemike.com" writes: > On Nov 29, 2011, at 1:13 PM, David Kastrup wrote: > >> mts...@gmail.com writes: >> >>> I'll just say to all you haters of `renvoi' that: >>> >>> --) There is no English term that I know of that succinctly expresses >>> the idea of "being sent back to something.

Re: Allows for automatic renumbering of measure numbers at volta repeats. (issue 5440049)

David Kastrup writes: > "m...@apollinemike.com" writes: > >> On Nov 29, 2011, at 1:13 PM, David Kastrup wrote: >> >>> mts...@gmail.com writes: >>> I'll just say to all you haters of `renvoi' that: --) There is no English term that I know of that succinctly expresses the ide

Re: Doc: NR Added new node for Custom Footnotes (issue 5433064)

Thanks Mike. Changes made. james http://codereview.appspot.com/5433064/diff/1/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/5433064/diff/1/Documentation/notation/input.itely#newcode1038 Documentation/notation/input.itely:1038:

Re: Adds padding between Hairpins and SpanBars. (issue 5438060)

On Nov 29, 2011, at 10:22 AM, Keith OHara wrote: > On Mon, 28 Nov 2011 23:38:28 -0800, m...@apollinemike.com > wrote: > >> In the original report, my eyes zoomed directly to the second system, last >> measure (which my patch fixes). > > Just to be clear, the one-line fix linked to issue 2060

Re: Allows for automatic renumbering of measure numbers at volta repeats. (issue 5440049)

On Nov 29, 2011, at 1:20 PM, m...@apollinemike.com wrote: > On Nov 29, 2011, at 1:08 PM, mts...@gmail.com wrote: > >> >> The only problem that remains is that the display-lily-tests shows a >> one-space increase in the new output. I've made the string rendered for >> AlternativeEvent "", but i

Re: rebasing inside staging

On Tue, Nov 29, 2011 at 11:10 AM, Adam Spiers wrote: > I'm building a fixed version > of the patch series as I type this, and will push as soon as I'm > convinced it's good, in order to minimise the risk of someone else > accidentally pushing the old series back in. Fixed patch series is now in s

Adds make-connected-path-stencil-with-initial-offset (issue 5434080)

I have my problems imagining why you don't just use ly:stencil-translate on the result. If you really want to have a separately specifiable origin, I would not make a separate function but rather add it as an optional argument at the end of the argument list. http://codereview.appspot.com/543408

Re: Adds make-connected-path-stencil-with-initial-offset (issue 5434080)

On Nov 29, 2011, at 6:33 PM, d...@gnu.org wrote: > I have my problems imagining why you don't just use ly:stencil-translate > on the result. > > If you really want to have a separately specifiable origin, I would not > make a separate function but rather add it as an optional argument at > the en

Re: Allows for automatic renumbering of measure numbers at volta repeats. (issue 5440049)

On Tue, 29 Nov 2011 04:08:52 -0800, wrote: I'll just say to all you haters of `renvoi' No no. I love "renvoi". You were just using it wrongly, to refer to the action of entering an alternative ending. ___ lilypond-devel mailing list lilypond-devel

Re: Allows for automatic renumbering of measure numbers at volta repeats. (issue 5440049)

On 29/11/11 18:26, Keith OHara wrote: > On Tue, 29 Nov 2011 04:08:52 -0800, wrote: > >> I'll just say to all you haters of `renvoi' > No no. I love "renvoi". You were just using it wrongly, to refer > to the action of entering an alternative ending. How about "diversion" (in the sense of traffic

Adds Span_bar_stub_engraver to StaffGroup (issue 5449043)

Passes Make and Make check James http://codereview.appspot.com/5449043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Adds padding between Hairpins and SpanBars. (issue 5438060)

passes make - reg tests attached http://code.google.com/p/lilypond/issues/detail?id=2057#c18 James http://codereview.appspot.com/5438060/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Work around compiler bug, Issue 1997: segfault in tablature-negative-fret.ly (issue 5431088)

passes make, make check. Also did a new build using ./autogen --noconfigure then cd build ./configure etc. and re-ran a full make and make test-baseline. Hope that was enough :) Passes all. James http://codereview.appspot.com/5431088/ ___ lilypond-d

Makes two functions in bezier-tools.scm public. (issue 5450046)

Passes make and make check James http://codereview.appspot.com/5450046/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Allows for automatic renumbering of measure numbers at volta repeats. (issue 5440049)

Passes Make and Make check James http://codereview.appspot.com/5440049/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

recent make doc failure

Hi all, In a fresh checkout I run ./autogen.sh --noconfigure mkdir build0 cd build0 ../configure --disable-optimising make && make doc This is a sequential make and make doc. The latter stops with the error message given below. Extract_texi_filename is the last thing that runs correctly and th

Re: Makes two functions in bezier-tools.scm public. (issue 5450046)

I don't think we should be defining the bezier routines as public. Users shouldn't call them directly, IMO. We should be operating on grobs. And there is no bezier grob (at least as far as I can determine). Encouraging users to goe below the published interfaces is bad behavior. What is the re

center NoteColumn

Hi, the attached code is my attempt to center a NoteColumn in a measure (like MultiMeasureRest). It's based upon http://old.nabble.com/centering-text-on-a-measure-td32377202.html (thanks to David Nalesnik) While it works fine in most cases, there is one major problem: Having a key-change to a\min

Re: Makes two functions in bezier-tools.scm public. (issue 5450046)

On Nov 29, 2011, at 11:39 PM, carl.d.soren...@gmail.com wrote: > I don't think we should be defining the bezier routines as public. > Users shouldn't call them directly, IMO. We should be operating on > grobs. And there is no bezier grob (at least as far as I can > determine). > > Encouraging u

Re: recent make doc failure

Julien On 29 November 2011 22:28, Julien Rioux wrote: > Hi all, > > In a fresh checkout I run > ./autogen.sh --noconfigure > mkdir build0 > cd build0 > ../configure --disable-optimising > make && make doc > > This is a sequential make and make doc. The latter stops with the error > message given

Re: recent make doc failure

On Tue, Nov 29, 2011 at 05:28:37PM -0500, Julien Rioux wrote: > This is a sequential make and make doc. The latter stops with the > error message given below. Extract_texi_filename is the last thing > that runs correctly and then make tries to copy a file from the > build dir instead of the source

PATCH: Countdown to 20111201

For 20:00 MST Thursday December 1 Critical: Issue 2061 : Lyrics collide with bar lines - R 5449043 Issue 1997 : segfault in tablat

Re: Allows for automatic renumbering of measure numbers at volta repeats. (issue 5440049)

Now it looks quite good, and still works great. C'est si bon. Is maith é sin. Smashing, old chap. http://codereview.appspot.com/5440049/diff/11010/lily/bar-number-engraver.cc File lily/bar-number-engraver.cc (right): http://codereview.appspot.com/5440049/diff/11010/lily/bar-number-engraver.cc#

Re: rebasing inside staging

Adam Spiers adamspiers.org> writes: > Fixed patch series is now in staging. > I am now seeing trouble with 'chord-name-exceptions.ly' and similar. The slash missing in the markup for the \chordmode { c:7sus4 }. ___ lilypond-devel mailing list lilypo