2 pushes to dev/staging

Hey all, I think I pushed two commits to staging today but I am not certain that my changes actually got pushed (I got a different message when pushing than usual - "Everything up-to-date"). Could someone please verify that they are indeed in staging (111f4707f90a4512f2c945ee5a47510c210b45f9 a

Re: 2 pushes to dev/staging

"m...@apollinemike.com" writes: > Hey all, > > I think I pushed two commits to staging today but I am not certain > that my changes actually got pushed (I got a different message when > pushing than usual - "Everything up-to-date"). Could someone please > verify that they are indeed in staging >

Re: 2 pushes to dev/staging

On Nov 24, 2011, at 9:25 AM, David Kastrup wrote: > "m...@apollinemike.com" writes: > >> Hey all, >> >> I think I pushed two commits to staging today but I am not certain >> that my changes actually got pushed (I got a different message when >> pushing than usual - "Everything up-to-date"). Co

Re: 2 pushes to dev/staging

On Nov 24, 2011, at 9:29 AM, m...@apollinemike.com wrote: > On Nov 24, 2011, at 9:25 AM, David Kastrup wrote: > >> "m...@apollinemike.com" writes: >> >>> Hey all, >>> >>> I think I pushed two commits to staging today but I am not certain >>> that my changes actually got pushed (I got a differ

Re: 2 pushes to dev/staging

"m...@apollinemike.com" writes: > On Nov 24, 2011, at 9:29 AM, m...@apollinemike.com wrote: > >> On Nov 24, 2011, at 9:25 AM, David Kastrup wrote: >> >>> "m...@apollinemike.com" writes: >>> Hey all, I think I pushed two commits to staging today but I am not certain that my

Re: 2 pushes to dev/staging

On Nov 24, 2011, at 9:50 AM, David Kastrup wrote: > > So the question stays: what command did you execute on what branch? > I think I may have just fixed the problem - could you please check? My branch was called dev/staging, so I executed git push origin dev/staging. Cheers, MS _

Re: 2 pushes to dev/staging

"m...@apollinemike.com" writes: > On Nov 24, 2011, at 9:50 AM, David Kastrup wrote: > >> >> So the question stays: what command did you execute on what branch? >> > > I think I may have just fixed the problem - could you please check? > My branch was called dev/staging, so I executed git push o

Re: 2 pushes to dev/staging

On Nov 24, 2011, at 10:07 AM, David Kastrup wrote: > "m...@apollinemike.com" writes: > >> On Nov 24, 2011, at 9:50 AM, David Kastrup wrote: >> >>> >>> So the question stays: what command did you execute on what branch? >>> >> >> I think I may have just fixed the problem - could you please c

Re: 2 pushes to dev/staging

"m...@apollinemike.com" writes: > All went well with the rename and I did a git pull -r on the branch to > boot (which didn't pull anything, as staging has had no new additions > within the past hour-ish). Judging from your config file posted previously, your staging branch is not tracking any u

Re: 2 pushes to dev/staging

> git branch --set-upstream staging origin/staging > > will likely make git pull -r work again. > OK - should be good to go now. Thanks! Cheers, MS ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypo

Better pure heights for slurs (issue 5431065)

Reviewers: , Message: Hey all, I'm not sure if this patch will make a big difference, but it should help the pure height problem a little bit. Before, pure heights were calculated using the entire height of the slur. For slurs with a slope, this is an overshoot. I thus use an estimate of the

Re: 2 pushes to dev/staging

"m...@apollinemike.com" writes: >> git branch --set-upstream staging origin/staging >> >> will likely make git pull -r work again. >> > > OK - should be good to go now. I now get * commit c81b2dc6fc2c086386abed7a026508e3af9af5e1 (origin/staging) | Author: Mike Solomon | Date: Thu Nov 24 10

Re: comment in #{ ... #}

Reinhold Kainhofer writes: > Am Freitag, 22. Oktober 2010, um 20:30:29 schrieb Werner LEMBERG: >> Interesting. This >> >> T = #(define-music-function (parser location music) (ly:music?) >> #{ >>\times 2/3 $music % $ >> #} >> ) >> >> does *not* work. Looks

Re: comment in #{ ... #}

>>T = #(define-music-function (parser location music) (ly:music?) >> #{ >> \times 2/3 $music % $m >> #} >>) > > With the patch to > http://code.google.com/p/lilypond/issues/detail?id=1356>, the > latter example will work (it will actually use the Scheme

Re: Fix compile on OSX by including std-vector.hh instead of (issue 5437052)

Reviewers: Graham Percival, Message: On 2011/11/24 01:13:53, Graham Percival wrote: this is the kind of patch that can in theory be pushed directly to staging, although in this case I'm glad there was a review first. This is precisely why I put this up for review instead of pushing it. I kn

Record $ and # expressions inside of #{ #} for better correlation (issue 5437055)

passes make and make check James http://codereview.appspot.com/5437055/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Better pure heights for slurs (issue 5431065)

Passes make and reg test diff here http://lilypond-stuff.1065243.n5.nabble.com/Tracker-issue-2051-24-November-td4986583.html James http://codereview.appspot.com/5431065/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mai

Don't let dots go negative in scaleDurations -- Fix Issue 2048 (issue 5437059)

Looks and works good for me. A nice thing about scheme patches is we can test them anywhere. If we take out the self-doc sentence claiming "scaling" then I think everything is good. \shiftDurations then does what it claims, with less chance of confusion with \scaleDurations. http://codereview

Re: Better pure heights for slurs (issue 5431065)

I like the direction of this change. The code has your trademark incomprehensibility, so I don't know if it does what you want based on your introduction. Maybe just decide that you want what it does. http://codereview.appspot.com/5431065/diff/1/lily/slur.cc File lily/slur.cc (right): http://

Re: Better pure heights for slurs (issue 5431065)

k-ohara5...@oco.net writes: > I like the direction of this change. > > The code has your trademark incomprehensibility, so I don't know if it > does what you want based on your introduction. Maybe just decide that > you want what it does. Makes me wonder what the trademark of "nobody ever commen

Re: Fix compile on OSX by including std-vector.hh instead of (issue 5437052)

Passes make and make check James http://codereview.appspot.com/5437052/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Don't let dots go negative in scaleDurations -- Fix Issue 2048 (issue 5437059)

passes make but fails make check see http://code.google.com/p/lilypond/issues/detail?id=2048#c3 James http://codereview.appspot.com/5437059/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Doc: NR Added new node for Custom Footnotes (issue 5433064)

Reviewers: , Message: Second go at documenting footnotes. I have also included notes about the recent checkin (height ordering of footnotes in a system determining the order they are printed). Description: Doc: NR Added new node for Custom Footnotes This is for Tracker issue 1567 Please review

PATCH: Countdown to 20111127

For 20:00 MST Sunday November 27 Issue 1356 : LilyPond-style comments embedded in a Scheme expression can't include special characters - R 5437055 Issue 1567

Asserts that footnotes are being numbered correctly. (issue 5433065)

Reviewers: , Message: Hey all, This patch helps make sure that the footnote auto-number regtests actually test what they purport to be testing by allowing a callback to check if footnote grobs are receiving the correct automatic number. Cheers, MS Description: Asserts that footnotes are being

Re: Doc: NR Added new node for Custom Footnotes (issue 5433064)

LGTM. http://codereview.appspot.com/5433064/diff/1/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/5433064/diff/1/Documentation/notation/input.itely#newcode1038 Documentation/notation/input.itely:1038: footnotes (plural) http://

Re: Better pure heights for slurs (issue 5431065)

On Thu, 24 Nov 2011 19:16:46 +, k-ohara5...@oco.net wrote: I like the direction of this change. Does it actually work? The code has your trademark incomprehensibility, Thank you, Keith. You know, sometimes, people think that it comes naturally to be so incomprehensible, but it's actua

Uses the pure-from-neighbor-interface for NonMusicalPaperColumn horizontal spacing. (issue 5432070)

Reviewers: , Message: This is the second of the three-part pure-from-neighbor-interface code rewrite. It uses extra-spacing-height for certain important non-musical grobs in order to prevent other grobs for passing over or under them via the pure-from-neighbor-interface. The last step, after th

Re: Uses the pure-from-neighbor-interface for NonMusicalPaperColumn horizontal spacing. (issue 5432070)

Sorry, forgot to mention that for the time being this only applies cleanly to the staging branch. It'll apply cleanly to master once master is fast-forwarded. http://codereview.appspot.com/5432070/ ___ lilypond-devel mailing list lilypond-devel@gnu.or

Re: Better pure heights for slurs (issue 5431065)

I've uploaded a new patch set where I've eliminated the 0.5 * height_limit. This will likely make slur pure heights worse (meaning they'll overshoot more), but I cannot find a good rationale for why the 0.5 was there in the first place so I took it out. http://codereview.appspot.com/5431065/ __

Re: Better pure heights for slurs (issue 5431065)

>> The code has your trademark incomprehensibility, > > Thank you, Keith. You know, sometimes, people think that it comes > naturally to be so incomprehensible, but it's actually hard work. > Usually, before writing LilyPond code, I'll read a passage from > either Finnegans Wake or Waiting for Go