hi Bertrand,
> I am a total ligature newbie. But I see some stemmed notes in
> input/regression/mensural-ligatures.ly .
initial and middle stems are drawn separately (see later if-blocks
of MLP_STEM and add-join), final ones are part of a longa notehead.
> Of course, I agree that there's a bug.
Mostly LGTM, apart from one calculation you do four times. Do it once
once and save as a variable and use that.
Cheers,
Ian
http://codereview.appspot.com/4962072/diff/1/mf/feta-noteheads.mf
File mf/feta-noteheads.mf (right):
http://codereview.appspot.com/4962072/diff/1/mf/feta-noteheads.mf#ne
http://codereview.appspot.com/4950071/diff/1/lily/page-layout-problem-scheme.cc
File lily/page-layout-problem-scheme.cc (right):
http://codereview.appspot.com/4950071/diff/1/lily/page-layout-problem-scheme.cc#newcode26
lily/page-layout-problem-scheme.cc:26: "Return the spacing spec going
between
2011/9/12 Janek Warchoł :
> Hi,
>
> i'm pretty confused about how note columns shift is measured (line 277
> and following in note-collision.cc). I tried modifying the values
> there, but the results were quite unexpected; i tried to trace in what
> unit is shift_amount measured but to no avail.
LGTM, with the same comment.
http://codereview.appspot.com/4962072/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
I decided to bring this proposal forward earlier than initially
planned.
http://lilypond.org/~graham/gop/gop_12.html
** Proposal summary
Let’s keep git master in ready-to-release state all the time. In
particular, assume that git master could become the next major
stable release at any time. If
On 2011/09/12 22:37:05, janek wrote:
i've looked at latest screenshot attached to tracker issue and... wow!
It looks
really great!
Thanks a lot :)
http://codereview.appspot.com/4639065/diff/13002/ly/engraver-init.ly#newcode1063
ly/engraver-init.ly:1063: \override Stem #'thickness = #2
I'd
LGTM. I think this could have been pushed directly.
http://codereview.appspot.com/4991044/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On 2011/09/12 22:37:05, janek wrote:
i've looked at latest screenshot attached to tracker issue and... wow!
It looks
really great!
Thanks a lot :)
http://codereview.appspot.com/4639065/diff/13002/ly/engraver-init.ly#newcode1063
ly/engraver-init.ly:1063: \override Stem #'thickness = #2
I'd
Thought I'd commented on this one but see
http://code.google.com/p/lilypond/issues/detail?id=1839#c13
There are the reg test differences.
http://codereview.appspot.com/4639065/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.
Hello,
On Tue, Sep 13, 2011 at 4:56 AM, Colin Campbell wrote:
> For 22:00 MDT Wednesday, September 14
>
>
> Issue 1873: Added glyphs for Kievan Notation - R 4951062
This has been set back to review after some comments today.
Regards
--
--
James
___
Thought I'd commented on this one but see
http://code.google.com/p/lilypond/issues/detail?id=1839#c13
There are the reg test differences.
http://codereview.appspot.com/4639065/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.
2011/9/13 Peekay Ex :
> Hello,
>
> On Tue, Sep 13, 2011 at 4:56 AM, Colin Campbell wrote:
>> For 22:00 MDT Wednesday, September 14
>>
>>
>> Issue 1873: Added glyphs for Kievan Notation - R 4951062
>
> This has been set back to review
you mean "needs_work"?
> after some comments today.
I don't s
Hello,
2011/9/13 Janek Warchoł :
> 2011/9/13 Peekay Ex :
>> Hello,
>>
>> On Tue, Sep 13, 2011 at 4:56 AM, Colin Campbell wrote:
>>> For 22:00 MDT Wednesday, September 14
>>>
>>>
>>> Issue 1873: Added glyphs for Kievan Notation - R 4951062
>>
>> This has been set back to review
>
> you mean "needs
New patch set uploaded.
http://codereview.appspot.com/4962072/diff/1/mf/feta-noteheads.mf
File mf/feta-noteheads.mf (right):
http://codereview.appspot.com/4962072/diff/1/mf/feta-noteheads.mf#newcode120
mf/feta-noteheads.mf:120:
On 2011/09/13 08:58:57, Ian Hulin (gmail) wrote:
foobar = quanted_
- Original Message -
From:
To: ;
Cc: ;
Sent: Monday, September 05, 2011 7:10 PM
Subject: Re: Uses langdefs.py to create language list for
create-weblinks-itexi.py (issue 4951047)
LTGM, not tested, but I'm willing to put it up and just see if anything
breaks.
My only qualm is that
2011/9/13 :
> http://codereview.appspot.com/4639065/diff/13002/ly/engraver-init.ly#newcode1063
>>
>> ly/engraver-init.ly:1063: \override Stem #'thickness = #2
>> I'd make them just a bit thinner, perhaps 1.8. I think that 2 might
>> get too thick with smaller font-size (as font-size decreases,
>>
LGTM
Ian
http://codereview.appspot.com/4962072/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On Tue, Sep 13, 2011 at 04:42:16PM +0100, Phil Holmes wrote:
> The problem is - how to return WEB_LANGS for the web-build, but
> LANGUAGES for the doc build? My patch does this by using something
> like this in website.make:
>
> WEB_LANGS = python langdefs.py web
Um. I was just expecting you t
On Tue, Sep 13, 2011 at 01:23:19AM +0200, David Kastrup wrote:
>
> It's tutorial-speak at its best. I don't understand either your
> unhappiness nor your displeasure.
The tutorial is not the place for musings or cleverness. The goal
is to get people started writing music with the minimum amount
have you thought of fixing this generically instead?
You could the hare/tortoise algorithm to detect cycles in any markup,
and could run that on the entry point (not the recursive function) for
evaluating markups to stencils.
http://codereview.appspot.com/4951073/
__
2011/9/13 Graham Percival :
> On Tue, Sep 13, 2011 at 01:23:19AM +0200, David Kastrup wrote:
>>
>> It's tutorial-speak at its best. I don't understand either your
>> unhappiness nor your displeasure.
>
> The tutorial is not the place for musings or cleverness. The goal
> is to get people started
http://codereview.appspot.com/4951073/diff/3001/scm/define-markup-commands.scm
File scm/define-markup-commands.scm (right):
http://codereview.appspot.com/4951073/diff/3001/scm/define-markup-commands.scm#newcode1897
scm/define-markup-commands.scm:1897: (interpret-markup layout (cons
(list (list s
2011/9/13 Han-Wen Nienhuys :
> 2011/9/12 Janek Warchoł :
>> i'm pretty confused about how note columns shift is measured (line 277
>> and following in note-collision.cc). I tried modifying the values
>> there, but the results were quite unexpected; i tried to trace in what
>> unit is shift_amount
Graham Percival writes:
> On Tue, Sep 13, 2011 at 01:23:19AM +0200, David Kastrup wrote:
>>
>> It's tutorial-speak at its best. I don't understand either your
>> unhappiness nor your displeasure.
>
> The tutorial is not the place for musings or cleverness. The goal is
> to get people started w
http://codereview.appspot.com/4974075/diff/1/lily/ledger-line-spanner.cc
File lily/ledger-line-spanner.cc (right):
http://codereview.appspot.com/4974075/diff/1/lily/ledger-line-spanner.cc#newcode362
lily/ledger-line-spanner.cc:362: ledgers.add_stencil (ledger_line);
Since you no longer seem to b
Graham Percival wrote Tuesday, September 13, 2011 2:49 PM
Let’s keep git master in ready-to-release state all the time. In
particular, assume that git master could become the next major
stable release at any time. If that makes you pause and wonder if
you should really push a particular patch (
http://codereview.appspot.com/4974075/diff/1/lily/ledger-line-spanner.cc
File lily/ledger-line-spanner.cc (right):
http://codereview.appspot.com/4974075/diff/1/lily/ledger-line-spanner.cc#newcode362
lily/ledger-line-spanner.cc:362: ledgers.add_stencil (ledger_line);
On 2011/09/13 21:28:58, joene
On Wed, Sep 14, 2011 at 12:31:14AM +0100, Trevor Daniels wrote:
>
> Graham Percival wrote Tuesday, September 13, 2011 2:49 PM
>
> >Let’s keep git master in ready-to-release state all the time. In
>
> Hhm. Not sure about ready-to-release-a-stable. I think we need
> warning when a new stable is
Graham Percival percival-music.ca> writes:
> If that makes you pause and wonder if
> you should really push a particular patch (because it would leave
> something hanging or unfinished), then put that on a separate
> branch and/or upload to rietveld instead of pushing to master.
I like the Reit
hi all,
the patch is ok from my point of view. a minor question: the only change
in mensural-ligatures.ly is the version bump - is that needed?
>> Do you know what neomensural and mensural styles are inspired of?
I believe it uses the shapes of noteheads found in manuscript,
but scales them to
31 matches
Mail list logo
