On 23 July 2011 01:53, Graham Percival wrote:
>
> You can't.
>
> I do 10 hours a week. I'm not going to start GLISS until I have
> at least 4 weeks of GOP policy questions prepared for discussion,
> and at least 2 weeks of GLISS material prepared. The more
> "mundane tasks" people do, the more t
2011/7/18 Neil Puttock :
> 2011/7/18 Janek Warchoł :
>
>> i don't see anything called "stencil-width" in grob.cc...
>
> 78 if (get_property_data ("X-extent") == SCM_EOL)
> 79 set_property ("X-extent", Grob::stencil_width_proc);
>
> The C++ name is Grob::stencil_width; the addition of _proc us
On Jul 23, 2011, at 12:19 PM, Janek Warchoł wrote:
> I guess that the problem in general is that sometimes we want to
> include breve's lines in glyph width calculations, and sometimes not.
> Take this example:
>
>
If this is the problem, the best solution is to create a sort of NoteHeadFlank
2011/7/23 m...@apollinemike.com :
> On Jul 23, 2011, at 12:19 PM, Janek Warchoł wrote:
>
>> I guess that the problem in general is that sometimes we want to
>> include breve's lines in glyph width calculations, and sometimes not.
>
> If this is the problem, the best solution is to create a sort of
On Jul 23, 2011, at 12:58 PM, Janek Warchoł wrote:
> 2011/7/23 m...@apollinemike.com :
>> On Jul 23, 2011, at 12:19 PM, Janek Warchoł wrote:
>>
>>> I guess that the problem in general is that sometimes we want to
>>> include breve's lines in glyph width calculations, and sometimes not.
>>
>> If
2011/7/21 Graham Percival :
> Not much response from the previous GOP-PROP 5 (update); I'm not
> certain if "silence is a form of consent" [1] in this context.
In my case it is, i guess :)
cheers,
Janek
___
lilypond-devel mailing list
lilypond-devel@gn
2011/7/21 Trevor Daniels :
> In my case it's because I have difficulty in understanding precisely what
> the effect of this change will be on any work I do.
>
> But I have one comment. By far the commonest use of make
> by developers is to compile the most recent change to C++
> source during the
Jan Warchoł wrote Saturday, July 23, 2011 1:39 PM
2011/7/21 Trevor Daniels :
If the compile and link succeed, you usually ctrl-C out of make
as soon as linking has finished so you can get on with testing.
So you need to see the relevant messages on the console
to determine this.
I'm not su
I guess this fixes the problem with "old" style for non-G clefs.
http://codereview.appspot.com/4664070/diff/8001/lily/clef.cc
File lily/clef.cc (right):
http://codereview.appspot.com/4664070/diff/8001/lily/clef.cc#newcode51
lily/clef.cc:51: str = str + "_" + clef_style;
On 2011/07/17 21:09:45,
Reviewers: ,
Message:
I think that this is sufficient to "fix" issue 36. As Graham points out
in the tracker, it is difficult to imagine what a good solution is, and
I have a feeling that the solution likely depends upon the user's
preferences. In certain situations I can see making the hairpin
David Kastrup writes:
>> The Lilypond codebase does not contain such music function arguments I
>> think. It should actually work to convert them to
>> #(ly:export (ly:make-pitch ...
>> so there is a straightforward (but more likely than not untowardly
>> awkward) migration path.
>>
>> Apart fro
> http://codereview.appspot.com/4670056/
Reinhold,
I think the slashedGrace function needs to be described in
the NR (1.2.6), and also preferably listed in changes.tely.
Thanks.
- Mark
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://li
2011/7/20 Xavier Scheuer :
> Hi Janek,
>
> Sorry for late answer, holiday time!
No problem. I hope you had a great time!
> I'm happy to see that other user, developers and also Jan and Han-Wen
> gave their opinion about this change in the treble clef.
> I think indeed your last proposal is more
On Sat, Jul 23, 2011 at 03:07:22PM +0100, Trevor Daniels wrote:
>
> If you have changed only one or two C++ routines
> the compile and link part of make take only a few seconds.
> There's no point in letting it go on to check all the doc files.
ok, let's publicize the "build on bin/lilypond" targ
On Fri, Jul 22, 2011 at 10:45:30PM +0200, Bertrand Bordage wrote:
> What are we doing then? We only update git-cl's repository in the CG?
I guess so? :(
It would be nice to start a discussion with the rietveld people
about allowing uploads of an actual git patch (regardless of
whether numerous p
2011/7/23 Trevor Daniels :
>
> Jan Warchoł wrote Saturday, July 23, 2011 1:39 PM
>
>> 2011/7/21 Trevor Daniels :
>>>
>>> If the compile and link succeed, you usually ctrl-C out of make
>>> as soon as linking has finished so you can get on with testing.
>>> So you need to see the relevant messages o
On 23 July 2011 04:07, Graham Percival wrote:
> Presumably a different problem this time?
>
> I know that Carl is either flying to Korea, or just about to fly
> to Korea, so could somebody else look into this? You should be
> able to "make doc" on stable/2.14 from scratch. It doesn't work
> in p
New patch set uploaded. Current Lily default behaviour is kept as
default now.
http://codereview.appspot.com/4636081/diff/10001/lily/stem-tremolo.cc
File lily/stem-tremolo.cc (right):
http://codereview.appspot.com/4636081/diff/10001/lily/stem-tremolo.cc#newcode42
lily/stem-tremolo.cc:42: style
2011/7/23 m...@apollinemike.com :
> On Jul 23, 2011, at 12:58 PM, Janek Warchoł wrote:
>
>> 2011/7/23 m...@apollinemike.com :
>>> On Jul 23, 2011, at 12:19 PM, Janek Warchoł wrote:
>>>
I guess that the problem in general is that sometimes we want to
include breve's lines in glyph width ca
+1 everything
+1 Graham in general :)
cheers,
Janek
2011/7/23 Graham Percival :
> On Fri, Jul 22, 2011 at 11:49:40AM +0200, Xavier Scheuer wrote:
>> Is there a roadmap of future releases of LilyPond (2.16, 2.18, 3.0),
>
> That discussion will happen in GOP:
> http://lilypond.org/doc/v2.15/Documen
Reviewers: ,
Message:
Hello,
This patch adds auto-generated documentation for context modifications
(currently, only \RemoveEmptyStaves).
Any context modification identifier defined in ly/context-mods-init.ly
will get an entry in the notation appendices so long as it has a
\description docstrin
http://codereview.appspot.com/4810042/diff/4001/input/regression/set-once.ly
File input/regression/set-once.ly (right):
http://codereview.appspot.com/4810042/diff/4001/input/regression/set-once.ly#newcode6
input/regression/set-once.ly:6: to the previous value rather than the
default."
On 2011/07
Reviewers: ,
Message:
Hey all,
This fixes issue 163. The only downside is that it adds another entry
to an already-crowded details list. I also use a magic number of 2
(you'll see a comment about it) that should likely itself either be a
details entry or be taken from an existing details entry
Reviewers: ,
Message:
Should fix issue 1604.
Description:
Treats multi measure rest staff position like rest staff position.
Please review this at http://codereview.appspot.com/4822046/
Affected files:
M lily/multi-measure-rest.cc
M scm/define-grobs.scm
Index: lily/multi-measure-rest.cc
http://codereview.appspot.com/4814041/diff/6001/scm/define-grob-properties.scm
File scm/define-grob-properties.scm (right):
http://codereview.appspot.com/4814041/diff/6001/scm/define-grob-properties.scm#newcode1000
scm/define-grob-properties.scm:1000: (core-interfaces ,list "Core
interfaces to b
LGTM.
http://codereview.appspot.com/4801045/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On 2011/07/20 12:47:56, MikeSol wrote:
I've needed something like this for a long time - lemme know what you
think!
I don't understand how it works, but from what i suppose it's results
will be very nice!
thanks,
Janek
http://codereview.appspot.com/4801045/
__
2011/7/22 Xavier Scheuer :
> On 21 July 2011 04:24, Colin Campbell wrote:
>>
>> Issue 1735: modifying default behaviour of tremolo slashes - Rietveld Issue
>> 4636081: modifying default behaviour of tremolo slashes
>
> [Not sure how it works, but]
> Please wait for issue 1735.
> Joe reviewed it ye
Hi Reinhold,
This LGTM, but I think it would be better to fold the patch for issue
# into this, otherwise you're going to have to reformulate some of
regression tests so they don't use explicit directions.
Cheers,
Neil
http://codereview.appspot.com/4630070/
Can you give me an idea what his does and how to test this or what I am
going to see as someone who runs a lot of make/reg tests?
http://codereview.appspot.com/4801045/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mail
Hello
From: lilypond-devel-bounces+james.lowe=datacore@gnu.org
[lilypond-devel-bounces+james.lowe=datacore@gnu.org] on behalf of Mark
Polesky [markpole...@yahoo.com]
Sent: 23 July 2011 17:20
To: reinhold.kainho...@gmail.com
Cc: re...@codereview.app
On 23 July 2011 23:05, wrote:
> Can you give me an idea what his does and how to test this or what I am
> going to see as someone who runs a lot of make/reg tests?
If somebody forgets to document a new property (in
scm/define-grob-properties.scm or scm/define-context-properties.scm)
this will en
http://codereview.appspot.com/4801045/diff/1/scm/documentation-lib.scm
File scm/documentation-lib.scm (right):
http://codereview.appspot.com/4801045/diff/1/scm/documentation-lib.scm#newcode184
scm/documentation-lib.scm:184: (ly:error (_ "cannot find description for
property ~S (~S)") sym where))
gmail.com> writes:
>
> This fixes issue 163. The only downside is that it adds another entry
> to an already-crowded details list.
Mike, it seems that the existing properties 'height-limit and 'ratio *should*
control the situations in issue 163.
In fact, making 'height-limit larger (?!) a
On Sat, Jul 23, 2011 at 10:05:34PM +, pkx1...@gmail.com wrote:
> Can you give me an idea what his does and how to test this or what I am
> going to see as someone who runs a lot of make/reg tests?
To initial acceptance of this patch:
- you should see no change in the regtests.
After it's push
I don't mind if we have another obscure entry in the detail list
currently. If your patches fixes the problem reliably, this would be a
great immediate help.
IMHO, at some point in the hopefully not too distant future, the whole
handling of slurs and ties must be re-examined to make it more
user
36 matches
Mail list logo
