k-ohara5...@oco.net wrote Thursday, July 14, 2011 5:33 AM
It seems everyone is happy to use astyle as the indenter
(it sure is faster) so here is one last patch set showing what
this does
to the sample set of C++ files.
Running fixcc(astyle) on the source tree again gives a clean make
chec
The patch at http://codereview.appspot.com/4724041/ fixes the output
of annotate spacing in a few ways:
- Fixes annotate-spacing to use the new spacing names.
- Annotates spacing between staves as well as spacing between systems.
- Fixes some collisions between annotations.
Cheers,
Joe
_
I suggest that invalid bug reports don't receive a `verified' tag.
Otherwise, the invalidity is no longer visible, making it much harder
to check the bug list or search within.
BTW, according to the help string, `verified' means
QA has verified that the fix worked
but an invalid bug report ha
LGTM.
This kind of patch is something I wouldn't discuss on Rietveld but
rather push immediately...
http://codereview.appspot.com/4724041/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Am Donnerstag, 14. Juli 2011, 13:33:31 schrieb Werner LEMBERG:
> I suggest that invalid bug reports don't receive a `verified' tag.
> Otherwise, the invalidity is no longer visible, making it much harder
> to check the bug list or search within.
>
> BTW, according to the help string, `verified' me
> Similarly, I don't like tagging duplicate reports with Verified,
> either...
This deserves a `duplicate-verified' tag... In both cases, it's not
trivial to decide whether a bug report is invalid or a duplicate, so
verification is useful. Or perhaps better: What about using a
completely differ
On Jul 13, 2011, at 10:48 PM, Han-Wen Nienhuys wrote:
> On Wed, Jul 13, 2011 at 5:12 PM, m...@apollinemike.com
> wrote:
>> On Jul 13, 2011, at 4:42 PM, Han-Wen Nienhuys wrote:
>>
>>> On Wed, Jul 13, 2011 at 11:27 AM, m...@apollinemike.com
>>> wrote:
>>>
> Wouldnt it be much easier for the
I like the fact that there's no more "rider" concept.
The only architectural question I have is whether
has_outside_staff_parent should be in Axis_group_interface or Grob.
Otherwise, LGTM.
Thanks,
Carl
http://codereview.appspot.com/4639075/diff/18001/lily/axis-group-interface.cc
File lily/a
On 11-07-14 06:06 AM, Werner LEMBERG wrote:
Similarly, I don't like tagging duplicate reports with Verified,
either...
This deserves a `duplicate-verified' tag... In both cases, it's not
trivial to decide whether a bug report is invalid or a duplicate, so
verification is useful. Or perhaps bet
On Jul 14, 2011, at 2:47 PM, carl.d.soren...@gmail.com wrote:
>
> http://codereview.appspot.com/4639075/diff/18001/lily/axis-group-interface.cc#newcode670
> lily/axis-group-interface.cc:670:
> Axis_group_interface::has_outside_staff_parent (Grob *me)
> Why not make this part of the Grob class ins
On Thu, Jul 14, 2011 at 01:33:31PM +0200, Werner LEMBERG wrote:
>
> I suggest that invalid bug reports don't receive a `verified' tag.
> Otherwise, the invalidity is no longer visible, making it much harder
> to check the bug list or search within.
If we don't give it a "verified" tag, then it st
much better. I bet there will skeletons coming out the regtest closet
now, but let's hope that we can fix things up if necessary
http://codereview.appspot.com/4639075/diff/23001/lily/axis-group-interface.cc
File lily/axis-group-interface.cc (right):
http://codereview.appspot.com/4639075/diff/2
On Wed, Jul 13, 2011 at 07:12:09PM -0600, Carl Sorensen wrote:
>
> Could you prepare a 2.14.2 release?
Nope, sorry. I see 3 open Critical issues. Each one of those
blocks a stable release.
Cheers,
- Graham
___
lilypond-devel mailing list
lilypond-de
On 7/14/11 8:20 AM, "Graham Percival" wrote:
> On Wed, Jul 13, 2011 at 07:12:09PM -0600, Carl Sorensen wrote:
>>
>> Could you prepare a 2.14.2 release?
>
> Nope, sorry. I see 3 open Critical issues. Each one of those
> blocks a stable release.
As I see it, all of those issues are present
LGTM.
With Neil's approval I think we can go ahead and push.
http://codereview.appspot.com/4654090/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
LGTM.
Careful thinking about how to handle this. Great job, Neil!
http://codereview.appspot.com/4683043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Updated proposal:
http://lilypond.org/~graham/gop/gop_3.html
** Proposal summary
Speaking academically, C++ code style is a "solved problem". Let’s
pick one of the existing solutions, and let a computer deal with
this. Humans should not waste their time, energy, and creativity
manually adding ta
On Thu, Jul 14, 2011 at 08:51:18AM -0600, Carl Sorensen wrote:
>
> On 7/14/11 8:20 AM, "Graham Percival" wrote:
>
> > Nope, sorry. I see 3 open Critical issues. Each one of those
> > blocks a stable release.
>
> I don't think that critical issues present in 2.14.1 should prevent a
> release o
Update on this; I'm not ready to call it a "probable decision"
yet.
http://lilypond.org/~graham/gop/gop_5.html
(proposal written by Phil Holmes, modified by Graham)
** Proposal summary
When you run make or make doc,
* All output will be saved to various log files. (including
output f
2011/7/14 :
> This has had its countdown; please push and close.
I attach the patch; I've send it to Mike but he must have missed it.
Anyone with push privileges - push it, please.
cheers,
Janek
From 38a23b5868b6029caf373d8571bc49289e8810e4 Mon Sep 17 00:00:00 2001
From: Janek Warchol
Date: Tue
2011/7/14 :
> This has had its countdown; please push and close.
I attach the patch, feel free to push it (i cannot).
cheers,
Janek
From 55ac6f7e56bcd42a6464a35378f02046aee4d2f7 Mon Sep 17 00:00:00 2001
From: Janek Warchol
Date: Mon, 4 Jul 2011 21:39:28 +0200
Subject: [PATCH] an example of mini
I think this doesn't need any discussion. I don't have git punch
abilities ;) so please push it.
cheers,
Janek
From c83ccb3d3a8463804a459c80d364584f4a6360de Mon Sep 17 00:00:00 2001
From: Janek Warchol
Date: Wed, 6 Jul 2011 23:13:53 +0200
Subject: [PATCH] add transposing instruments to GLISS lis
On 2011/07/14 19:50:37, Janek Warchol wrote:
The slash looks too long to me, especially when compared to halfopen
(unstopped).
I wondered about that myself. The line is exactly the same length as
the line in halfopen. Maybe I should make the glyph the same height as
halfopen, instead of havin
On Jul 14, 2011, at 3:51 PM, hanw...@gmail.com wrote:
> much better. I bet there will skeletons coming out the regtest closet
> now, but let's hope that we can fix things up if necessary
>
>
> http://codereview.appspot.com/4639075/diff/23001/lily/axis-group-interface.cc
> File lily/axis-group-i
On Thu, Jul 14, 2011 at 09:59:44PM +0200, Janek Warchoł wrote:
> I attach the patch, feel free to push it (i cannot).
Thanks, pushed.
Cheers,
- Graham
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypon
On Thu, Jul 14, 2011 at 10:01:24PM +0200, Janek Warchoł wrote:
> I think this doesn't need any discussion. I don't have git punch
> abilities ;) so please push it.
Thanks, pushed.
Cheers,
- Graham
___
lilypond-devel mailing list
lilypond-devel@gnu.org
Make and reg tests ok.
http://codereview.appspot.com/4714043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On 14 July 2011 21:01, m...@apollinemike.com wrote:
> I'll run the regtests tonight or tomorrow and report back.
I've just tried this and I think you've got an infinite loop somewhere
(I had to kill the process and reboot).
Edit: it's from tie-pitched-trill.ly; segfaults due to stack overflow.
2011/7/14 :
> On 2011/07/14 19:50:37, Janek Warchol wrote:
>>
>> The slash looks too long to me, especially when compared to halfopen
>> (unstopped).
>
> I wondered about that myself. The line is exactly the same length as
> the line in halfopen.
Either dvi proofing (run
mf feta20; gftodvi $fe
Hi Carl,
I can't comment on the code itself, but the name of the new glyph seems
wrong to me, since it implies that the existing glyph isn't for hihat.
IIRC, it was added specifically for this purpose, and looking at Elaine
Gould's example (p. 298 of Behind Bars) I'd say we already have the
corre
The slash looks too long to me, especially when compared to halfopen
(unstopped). I'd change factor to
factor := 11/10 * sqrt(1 + 25/16);
or maybe even
factor := 4/4 * sqrt(1 + 25/16);
otherwise LGTM.
thanks,
Janek
http://codereview.appspot.com/4714043/
___
Hi Joe,
Do you have a follow-up patch which defines ly:get-spacing-spec?
Cheers,
Neil
http://codereview.appspot.com/4724041/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On Thu, Jul 14, 2011 at 09:57:19PM +0200, Janek Warchoł wrote:
> I attach the patch; I've send it to Mike but he must have missed it.
> Anyone with push privileges - push it, please.
Thanks, pushed.
Cheers,
- Graham
___
lilypond-devel mailing list
lily
Hi Colin,
Previously I asked you to keep it to 3 patches per countdown, but
we're not clearing through the backlog. Could you increase it to
5 patches per countdown, at least until we're on top of things
again?
This is particularly relevant because of the upcoming automatic
formatting; any patch
On Thu, 14 Jul 2011 00:47:58 -0700, Trevor Daniels
wrote:
I was hoping to recommend going with this, so we could
wrap up this issue, but then I found
- new_context->event_source ()->
- add_listener (GET_LISTENER
(new_context->create_context_from_event),
+ new_context->event_source ()->
+ a
On 11-07-14 03:20 PM, Graham Percival wrote:
Hi Colin,
Previously I asked you to keep it to 3 patches per countdown, but
we're not clearing through the backlog. Could you increase it to
5 patches per countdown, at least until we're on top of things
again?
This is particularly relevant because
On Thu, Jul 14, 2011 at 10:29:37PM -0600, Colin Campbell wrote:
> I've been selecting patches with at least one positive comment.
> There are a great number of patches which don't have a positive
> indication of being complete.
No, don't view them like that -- the countdown is the (only) way
to ge
(this was originally off-list to reduce clutter, but perhaps it was a bad idea)
2011/7/13 Jan Nieuwenhuizen :
> Janek Warchoł writes:
> > in the recent clef survey you said that you don't like some aspects of my
> > clef.
> > I've modified my original suggestion - it's bigger now. It looks like
>
38 matches
Mail list logo
