LGTM, apart from minor changes noted
http://codereview.appspot.com/4568046/diff/1/Documentation/notation/staff.itely
File Documentation/notation/staff.itely (right):
http://codereview.appspot.com/4568046/diff/1/Documentation/notation/staff.itely#newcode1285
Documentation/notation/staff.itely:12
Reviewers: Graham Percival, Trevor Daniels,
Message:
Second Draft
I also just want to check with Reinhold as all I have done here is
document the \cueDuringWithClef function (as that is what is in the Reg
tests).
So is there an explicit \cueClef command that would be used in a
different case an
On Jun 1, 2011, at 10:54 PM, n.putt...@gmail.com wrote:
> I'm afraid it's still a bit flaky:
>
> \relative c' {
> \override NoteHead #'stem-attachment = ##f
> c8 d e f
> }
>
> Program received signal SIGSEGV, Segmentation fault.
> 0x0040bbfb in ly_cdr (x=0x404) at ./include/lily-guile.
LGTM.
http://codereview.appspot.com/4490045/diff/20001/lily/completion-note-heads-engraver.cc
File lily/completion-note-heads-engraver.cc (right):
http://codereview.appspot.com/4490045/diff/20001/lily/completion-note-heads-engraver.cc#newcode204
lily/completion-note-heads-engraver.cc:204:
event
On 2011/06/02 09:18:06, J_lowe wrote:
Second Draft
I also just want to check with Reinhold as all I have done here is
document the
\cueDuringWithClef function (as that is what is in the Reg tests).
So is there an explicit \cueClef command that would be used in a
different case
and shoul
- Original Message -
From: "Graham Percival"
To: "Phil Holmes"
Cc:
Sent: Wednesday, June 01, 2011 3:38 PM
Subject: Re: make doc
On Wed, Jun 01, 2011 at 03:27:14PM +0100, Phil Holmes wrote:
- Original Message - From: "Graham Percival"
>If that's true, then maybe this shoul
Carl's suggestions done !
Bertrand
http://codereview.appspot.com/4536068/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
http://codereview.appspot.com/4536068/diff/10008/lily/multi-measure-rest-engraver.cc
File lily/multi-measure-rest-engraver.cc (right):
http://codereview.appspot.com/4536068/diff/10008/lily/multi-measure-rest-engraver.cc#newcode232
lily/multi-measure-rest-engraver.cc:232: last_rest_->set_property
http://codereview.appspot.com/4547058/diff/7004/lily/stem.cc
File lily/stem.cc (right):
http://codereview.appspot.com/4547058/diff/7004/lily/stem.cc#newcode439
lily/stem.cc:439: me->set_property ("stencil", SCM_BOOL_F);
This looks like a hack; it's certainly not idiomatic (I can see only one
pla
http://codereview.appspot.com/4527086/diff/7002/scm/output-lib.scm
File scm/output-lib.scm (right):
http://codereview.appspot.com/4527086/diff/7002/scm/output-lib.scm#newcode795
scm/output-lib.scm:795: (define-public (glissando::before-line-breaking
grob)
Possibly silly question: can't you fold
Thanks, 'tis done.
http://codereview.appspot.com/4536068/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
11 matches
Mail list logo
