Re: Policy about not-yet-regression tests?

2011-04-11 Thread Graham Percival
On Sun, Apr 10, 2011 at 05:26:49PM +0200, David Kastrup wrote: > Graham Percival writes: > > > I do not think that this is an appropriate time to discuss changes > > to the bug squad policies, nor to our regtest organization. > > Please add an item to the GOP policy list about this, and we will >

Re: Policy about not-yet-regression tests?

2011-04-11 Thread David Kastrup
Graham Percival writes: > On Sun, Apr 10, 2011 at 05:26:49PM +0200, David Kastrup wrote: >> Graham Percival writes: >> >> > I do not think that this is an appropriate time to discuss changes >> > to the bug squad policies, nor to our regtest organization. >> > Please add an item to the GOP poli

Re: Policy about not-yet-regression tests?

2011-04-11 Thread Graham Percival
On Mon, Apr 11, 2011 at 09:23:25AM +0200, David Kastrup wrote: > I won't add any such an item to the GOP policy list since I won't > endorse announcing one thing in CG while adhering to a different policy > in reality. Ok, I added it myself: 86fa50596945324d6b5ab95f8fb018ab69a4e633 Cheers, - Grah

Re: [frogs] PATCHES: anything lost?

2011-04-11 Thread Marc Hohl
Am 11.04.2011 03:32, schrieb Graham Percival: On Sun, Apr 10, 2011 at 02:57:30PM +, James Lowe wrote: This one is missing (I think). http://lists.gnu.org/archive/html/lilypond-devel/2011-04/msg00121.html This was the one sent by Mark Hohl to Carl, but I didn't see anything done Thanks add

Re: Add predefined mandolin fretboards to lilypond. (issue4384055)

2011-04-11 Thread Marc Hohl
Am 11.04.2011 06:43, schrieb carl.d.soren...@gmail.com: Reviewers: , Message: Marc Hohl has prepared a patch for mandolin predefined fretboards. The patch looks good to me. Please review. Thanks, Carl http://codereview.appspot.com/4384055/diff/1/Documentation/notation/fretted-strings.itel

Re: Event listener to extract (some) music events. (issue4373046)

2011-04-11 Thread percival . music . ca
I've generalized the (print-foo ...) functions as (print-line ...), and indented with lispindent.lisp. http://codereview.appspot.com/4373046/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Allows users to prevent rests from automatically shifting. (issue4385053)

2011-04-11 Thread m...@apollinemike.com
On Apr 10, 2011, at 9:56 PM, carl.d.soren...@gmail.com wrote: > Instead of adding a property, is there a way to just make the default > value of the property be staff_space? > > Thanks, > > Carl > > > http://codereview.appspot.com/4385053/ The issue with this is that it'd kick all church rest

Re: Add some polyphonically directed grobs (issue4387046)

2011-04-11 Thread n . puttock
Hi Bertrand, There was a discussion last year about dynamics in polyphony which you might find interesting: http://lists.gnu.org/archive/html/bug-lilypond/2010-09/msg00253.html I'm afraid I agree with Trevor's reply in that thread. Cheers, Neil http://codereview.appspot.com/4387046/ ___

Changes the Y offset callback of multi-measure rest. (issue4389047)

2011-04-11 Thread mtsolo
Reviewers: , Message: I was able to figure out a way to do this w/o an extra offset (I think). Please, read, test, & report back. Cheers, MS Description: Changes the Y offset callback of multi-measure rest. Please review this at http://codereview.appspot.com/4389047/ Affected files: A inpu

Re: Issue 1471: Invalidate alterations upon key change rather than forgetting them. (issue4384050)

2011-04-11 Thread v . villenave
On 2011/04/10 05:38:50, Graham Percival wrote: LGTM Doesn't this require a regtest? V. http://codereview.appspot.com/4384050/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Issue 1471: Invalidate alterations upon key change rather than forgetting them. (issue4384050)

2011-04-11 Thread k-ohara5a5a
Works well for me. There is already a regtest 'accidental-clef-change.ly' that you could just update. Instead of texidoc = "Accidentals are reset for clef changes.", we want texidoc = "Accidentals are repeated after clef changes." You could put a c-natural in the final chord, and a key signature

Re: Changes the Y offset callback of multi-measure rest. (issue4389047)

2011-04-11 Thread Werner LEMBERG
> \ No newline at end of file You should adjust your editor's text mode to automatically insert a newline at the end of the file if it isn't present yet... IIRC, I've seen this diff message a few times already in your patches. :-) Werner ___ lil

Re: Changes the Y offset callback of multi-measure rest. (issue4389047)

2011-04-11 Thread Colin Campbell
On 11-04-11 05:11 PM, mts...@gmail.com wrote: Reviewers: , Message: I was able to figure out a way to do this w/o an extra offset (I think). Please, read, test, & report back. Cheers, MS Mike, is this a new patch against issue 1604? If at all possible, it helps uneducated bug squad folk a

Re: Changes the Y offset callback of multi-measure rest. (issue4389047)

2011-04-11 Thread Colin Campbell
On 11-04-11 05:11 PM, mts...@gmail.com wrote: Reviewers: , Message: I was able to figure out a way to do this w/o an extra offset (I think). Please, read, test, & report back. Cheers, MS Description: Changes the Y offset callback of multi-measure rest. Please review this at http://codereview

Re: Issue 1471: Invalidate alterations upon key change rather than forgetting them. (issue4384050)

2011-04-11 Thread dak
Reviewers: Graham Percival, Valentin Villenave, Keith, Message: On 2011/04/11 22:40:15, Valentin Villenave wrote: Doesn't this require a regtest? The original bug report http://code.google.com/p/lilypond/issues/detail?id=1471> has a test file. Adding the regtest together with the bug fix mak

Re: Issue 1471: Invalidate alterations upon key change rather than forgetting them. (issue4384050)

2011-04-11 Thread Graham Percival
On Tue, Apr 12, 2011 at 06:03:11AM +, d...@gnu.org wrote: > I have been > told that the policy documented in the contributor's guide regarding > regtests is different from the actual policy to be used, Merry christmas. 5ad4b3a291571e83bcf402656d346e46d8d9e667 > This does not make any sense to