Looks very good to me.
I'd like to see the property name changed to extra-stem-length.
Thanks,
Carl
http://codereview.appspot.com/3934041/diff/11001/lily/stem.cc
File lily/stem.cc (right):
http://codereview.appspot.com/3934041/diff/11001/lily/stem.cc#newcode322
lily/stem.cc:322: Real extra_
On 9 January 2011 19:48, Mike Solomon wrote:
> The patch set now fixes Issue 400 as well. It also fixes an unreported issue
> of time signature collisions.
Any chance of making the clef avoidance automatic? I'm not too
concerned about automating the time signature case since it usually
occurs
I seem to be playing bad-cop to Carl's good cop. Maybe I'm being picky
because the original issue didn't bother me very much, so I don't like
side effects to the fix. I'll say what I don't like, test at my own
suggestions at my slow pace, and let Carl overrule if appropriate.
http://codereview
On 1/11/11 5:31 PM, "k-ohara5...@oco.net" wrote:
> I seem to be playing bad-cop to Carl's good cop. Maybe I'm being picky
> because the original issue didn't bother me very much, so I don't like
> side effects to the fix. I'll say what I don't like, test at my own
> suggestions at my slow pace,
Cheers,
MS
0006-Better-reflects-what-is-actually-under-the-beam.patch
Description: Binary data
0005-Attempt-to-deal-with-smaller-font-sizes-like-cue-not.patch
Description: Binary data
0004-Changes-suggested-by-Carl.patch
Description: Binary data
0003-Intermediary-37-patch.patch
Description
New patch set uploaded.
http://codereview.appspot.com/3928041/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
New changes posted to Rietveld:
http://codereview.appspot.com/3928041/
Thanks,
Carl
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
On 2011/01/12 02:51:26, c_sorensen_byu.edu wrote:
What is the difference between "extra-raise-tip" and
"extra-stem-length" in
terms of how it acts?
I was associating variable-names with the names of functions whose
return values they affect. We are here adjusting the output of
Stem::calc_ste
