Re: Updates to bagpipe.ly (issue3825043)

2011-01-03 Thread Sven Axelsson
On 3 January 2011 00:39, wrote: > LGTM, could you send me a patch to apply?  (git format-patch origin) > > http://codereview.appspot.com/3825043/ > The patches are downloadabe from Rietveld. -- Sven Axelsson ++[>++>+++>++>++ ><-]>.+..>+.>

Re: Updates to bagpipe.ly (issue3825043)

2011-01-03 Thread Graham Percival
On Mon, Jan 03, 2011 at 09:52:58AM +0100, Sven Axelsson wrote: > On 3 January 2011 00:39, wrote: > > LGTM, could you send me a patch to apply?  (git format-patch origin) > > > > http://codereview.appspot.com/3825043/ > > The patches are downloadabe from Rietveld. But unfortunately not with your

Re: Updates to bagpipe.ly (issue3825043)

2011-01-03 Thread Sven Axelsson
On 3 January 2011 10:12, Graham Percival wrote: > On Mon, Jan 03, 2011 at 09:52:58AM +0100, Sven Axelsson wrote: >> On 3 January 2011 00:39,   wrote: >> > LGTM, could you send me a patch to apply?  (git format-patch origin) >> > >> > http://codereview.appspot.com/3825043/ >> >> The patches are dow

Re: Updates to bagpipe.ly (issue3825043)

2011-01-03 Thread Graham Percival
On Mon, Jan 03, 2011 at 10:26:20AM +0100, Sven Axelsson wrote: > The latest patch attached. Thanks, pushed. It'll appear in 2.13.46. Cheers, - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond

lilypond logging (Re: lilypond too noisy on the cmd line)

2011-01-03 Thread David Santamauro
On Sun, 2 Jan 2011 15:47:01 +0100 "Bertalan Fodor (LilyPondTool)" wrote: > You should consider using a proper logging framework with different > logging levels. > The first thing that jumps out at me is Apache log4cxx. It is a robust logging framework based on Java log4j. It introduces depende

Regtests for 13.45

2011-01-03 Thread Phil Holmes
A few minors things to report. In page-breaking-page-count3.log there are 4 extra lines reporting problems: "programming error: number of pages is out of bounds continuing, cross fingers programming error: tried to space systems on a bad number of pages continuing, cross fingers" The flags o

Re: critical issues

2011-01-03 Thread Phil Holmes
- Original Message - From: "Graham Percival" To: "Phil Holmes" Cc: Sent: Monday, January 03, 2011 3:15 AM Subject: Re: critical issues On Sun, Jan 02, 2011 at 04:37:35PM -, Phil Holmes wrote: " Priority-Critical: LilyPond segfaults, a regression (see below) against a previous s

Re: Updates to bagpipe.ly

2011-01-03 Thread Daniel Dadap
Sven Axelsson-3 wrote: > > I am the author of the bagpipe.ly mode included in the Lilypond > distribution. I'm sorry I haven't been very visible here the last > several years. I haven't had much user feedback for the bagpipe mode, > although I know there are people out there using it. Hi Sven.

Re: Fix Issue 1290 (issue3832046)

2011-01-03 Thread Carl . D . Sorensen
I've made the changes, and now the patch actually works. Thanks all for your comments! Carl http://codereview.appspot.com/3832046/diff/2001/lily/page-layout-problem.cc File lily/page-layout-problem.cc (right): http://codereview.appspot.com/3832046/diff/2001/lily/page-layout-problem.cc#newcod

Re: Change stringTunings entries from semitones to pitches (issue3842041)

2011-01-03 Thread pkx166h
For the Doc/Notation/fretted-strings.itely - that looks good. I can't comment on the rest. http://codereview.appspot.com/3842041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Issue 879

2011-01-03 Thread Phil Holmes
Is about knees, crossing staves, and the RemoveEmptyStaff command. It took me to engraver-init.ly where I found: RemoveEmptyStaves = \with { \remove "Axis_group_engraver" \remove "Hara_kiri_engraver" \consists "Hara_kiri_engraver" \override Beam #'auto-knee-gap = #'() \override VerticalAx

Re: lilypond logging (Re: lilypond too noisy on the cmd line)

2011-01-03 Thread Matthias Kilian
On Mon, Jan 03, 2011 at 06:16:08AM -0500, David Santamauro wrote: > The first thing that jumps out at me is Apache log4cxx. It is a robust > logging framework based on Java log4j. It introduces dependencies on > the apache portable runtime library That together makes 29708 lines of code just for l

what's up with optimal-page-breaking-hstretch.ly

2011-01-03 Thread James Bailey
Compiling this with 2.12.3 and 2.13.45 yields (to my eye) rather different results. I personally cannot tell if the systems are horizontally stretched or not. They appear to be centered. Or should this illustrate that only the systems on the first page are vertically stretched? Regardless, in 2.

Re: Optical spacing fails at tight situations

2011-01-03 Thread James Bailey
On Dec 30, 2010, at 12:48 PM, Janek Warchoł wrote: > Hi, > > didn't find it in the tracker so i report: > optical spacing doesn't work as expected in the following situation: > > \version "2.13.43" > \new Score { > \repeat unfold 12 { c''16 [ d'' b' c'' ] \noBreak } > } > > All 16ths are

Re: Fix Issue 1290 (issue3832046)

2011-01-03 Thread k-ohara5a5a
The new patch fixes the issue, but we can't yet use it in larger scores, if we want to do that. Whenever there is more than one staff in a system, and any non-zero skyline-horizontal-padding, minimum_distance is computed reasonably for the first and second systems, but not the third and later. F

Re: Fix Issue 1290 (issue3832046)

2011-01-03 Thread Carl . D . Sorensen
On 2011/01/04 01:46:45, Keith wrote: For a 2-staff system (with non-protruding bass clefs to make the math easier) the patch computes minimum_distance 3.05, 7.33, 29.41, 29.38 as it adds four systems to a page. Can you send me a test file so I can check it out? Thanks, Carl http://codere

Re: CG: out-of-tree building in main compile chapter. (issue3823045)

2011-01-03 Thread percival . music . ca
No complaints? I'll go ahead and push it in 24 hours if nobody objects or asks for more time. (you don't need to have any specific objections; if you're busy and can't review it for the next few days, but want to review it, just let me know and I'll wait) http://codereview.appspot.com/3823045/