git repository with fixed history ready

2010-03-22 Thread Jan Nieuwenhuizen
Hi, I've taken another look at fixing lily's history this weekend, it should be ready now to replace our old broken repository, have a look at the result git clone http://lilypond.org/people/janneke/vc/hysterical-lily.git Our current GIT archive suffers from major problems in the CVS->GIT co

Re: git repository with fixed history ready

2010-03-22 Thread Francisco Vila
2010/3/22 Jan Nieuwenhuizen : > Hi, > > I've taken another look at fixing lily's history this weekend, > it should be ready now to replace our old broken repository, Great! Thanks. Let's move. > Our current GIT archive suffers from major problems in the > CVS->GIT conversion, and also at the time

Re: git repository with fixed history ready

2010-03-22 Thread Jan Nieuwenhuizen
Op maandag 22-03-2010 om 10:34 uur [tijdzone +0100], schreef Francisco Vila: > 2010/3/22 Jan Nieuwenhuizen : > Great! Thanks. Let's move. Thanks! Don't we need some kind of coordination for this? Hmm, looking at IRC it seems that everyone is still asleep, this may indeed be a good time ;-) > Ho

PDF Named Destinations at each bar number

2010-03-22 Thread Amiel Heyde
Hi Everyone, I am trying add a feature to Lilypond but I have looked through the code a fair amount and really have no idea what is going on. I'm hoping someone may be able to give me some pointers (no pun intended). I am hoping to modify Lilypond so that a 'named destiation' pdfmark may be inclu

Re: Cleanup: sort header order, use explicit std:: prefix rather than using std; (issue681041)

2010-03-22 Thread Han-Wen Nienhuys
On Mon, Mar 22, 2010 at 3:24 AM, Werner LEMBERG wrote: >> there are some backward incompatible changes (removal of SCM >> functions), but I believe it should be safe, because the functions >> were not useful, little used anyway. > > In case someone has been using them, are there workarounds to > r

Re: [PATCH]: Allow context modifications to be stored in a variable and inserted into \context or \with

2010-03-22 Thread Reinhold Kainhofer
Am Dienstag, 16. März 2010 18:04:37 schrieb Reinhold Kainhofer: > Am Freitag, 12. März 2010 14:41:20 schrieb Reinhold Kainhofer: > > Our problems with \RemoveEmptyStaffContext resetting previous context > > modifications highlights one problem we have: So far, it was not possible > > to store a bun

Re: [PATCH]: Allow context modifications to be stored in a variable and inserted into \context or \with

2010-03-22 Thread David Kastrup
Reinhold Kainhofer writes: > Am Dienstag, 16. März 2010 18:04:37 schrieb Reinhold Kainhofer: >> Am Freitag, 12. März 2010 14:41:20 schrieb Reinhold Kainhofer: >> > Our problems with \RemoveEmptyStaffContext resetting previous context >> > modifications highlights one problem we have: So far, it w

Re: [PATCH]: Allow context modifications to be stored in a variable and inserted into \context or \with

2010-03-22 Thread Reinhold Kainhofer
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am Montag, 22. März 2010 16:15:31 schrieb David Kastrup: > Can't you just use > > whatever = \with { \remove "Some_engraver" } > > for those objects? > > It would seem that this syntax is not yet taken. The patch allows this as well (It treats \wit

Re: [PATCH]: Allow context modifications to be stored in a variable and inserted into \context or \with

2010-03-22 Thread David Kastrup
Reinhold Kainhofer writes: > Am Montag, 22. März 2010 16:15:31 schrieb David Kastrup: >> Can't you just use >> >> whatever = \with { \remove "Some_engraver" } >> >> for those objects? >> >> It would seem that this syntax is not yet taken. > > The patch allows this as well (It treats \with and

Re: [PATCH]: Allow context modifications to be stored in a variable and inserted into \context or \with

2010-03-22 Thread Werner LEMBERG
> So, do you all think that we should only go with \with? \with is fine for me. Werner ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Critical defects and collisions

2010-03-22 Thread Graham Percival
Hi all, Since last month, we have a net gain of 3 Critical issues. This isn't the right direction for releasing 2.14. Defects: ID Status PriorityOwner Summary 786 AcceptedCriticalnobody Extenders in lyrics stop prematurely if a single underscore is found 8

Re: [PATCH]: Allow context modifications to be stored in a variable and inserted into \context or \with

2010-03-22 Thread Ian Hulin
On 22/03/10 14:56, Reinhold Kainhofer wrote: Am Dienstag, 16. März 2010 18:04:37 schrieb Reinhold Kainhofer: Am Freitag, 12. März 2010 14:41:20 schrieb Reinhold Kainhofer: Our problems with \RemoveEmptyStaffContext resetting previous context modifications highlights one problem we have: So far,

Re: [PATCH]: Allow context modifications to be stored in a variable and inserted into \context or \with

2010-03-22 Thread David Kastrup
Ian Hulin writes: > On 22/03/10 14:56, Reinhold Kainhofer wrote: >> Am Dienstag, 16. März 2010 18:04:37 schrieb Reinhold Kainhofer: >>> Am Freitag, 12. März 2010 14:41:20 schrieb Reinhold Kainhofer: Our problems with \RemoveEmptyStaffContext resetting previous context modifications high

Re: Critical defects and collisions

2010-03-22 Thread Boris Shingarov
1027 Accepted Critical nobody Lyrics ignore minimum-Y-extent   This one, I have a suspicion that it may be related to the "Lyrics break estimation of vertical spacing" bug I am working on.  If no one else is looking at 1027, it *might* make sense to treat them together while I am in that area of

Font_metric code cleanup breaks fetaText positioning

2010-03-22 Thread Neil Puttock
Hi Han-Wen, Your first patch from the set you've pushed breaks the positioning of fetaText glyphs, since they now all have logical extents in the Y axis (rather than ink extents). I've attached picture with the debug code for checking extents switched on (the circle is supposed to be a string num

Re: Critical defects and collisions

2010-03-22 Thread Neil Puttock
On 22 March 2010 20:33, Boris Shingarov wrote: >> 1027 Accepted Critical nobody Lyrics ignore minimum-Y-extent > > > This one, I have a suspicion that it may be related to the "Lyrics break > estimation of vertical spacing" bug I am working on. This is a documentation issue, since minimum-Y-exten

Re: Font_metric code cleanup breaks fetaText positioning

2010-03-22 Thread Patrick McCarty
Hi Neil, On 2010-03-22, Neil Puttock wrote: > Hi Han-Wen, > > Your first patch from the set you've pushed breaks the positioning of > fetaText glyphs, since they now all have logical extents in the Y axis > (rather than ink extents). I have a patch in-progress, so I'll push a fix shortly. Thank

Re: Font_metric code cleanup breaks fetaText positioning

2010-03-22 Thread Patrick McCarty
On 2010-03-22, Patrick McCarty wrote: > > On 2010-03-22, Neil Puttock wrote: > > > > Your first patch from the set you've pushed breaks the positioning of > > fetaText glyphs, since they now all have logical extents in the Y axis > > (rather than ink extents). > > I have a patch in-progress, so

Re: Font_metric code cleanup breaks fetaText positioning

2010-03-22 Thread Neil Puttock
On 22 March 2010 21:54, Patrick McCarty wrote: > Okay, pushed.  Let me know if you find any problems. Cheers, Patrick. Looks fine so far. Thanks, Neil ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lily

Re: [PATCH]: Allow context modifications to be stored in a variableand inserted into \context or \with

2010-03-22 Thread Reinhold Kainhofer
Am Montag, 22. März 2010 16:51:50 schrieben Sie: > Reinhold Kainhofer wrote Monday, March 22, 2010 3:45 PM > > > The patch allows this as well (It treats \with and > > \contextmodifications > > exactly the same)... However, \with just doesn't tell you that > > this is only > > about Context modifi

Re: [PATCH]: Allow context modifications to be stored in a variable and inserted into \context or \with

2010-03-22 Thread Reinhold Kainhofer
Am Montag, 22. März 2010 19:50:47 schrieben Sie: > On 22/03/10 14:56, Reinhold Kainhofer wrote: > > Am Dienstag, 16. März 2010 18:04:37 schrieb Reinhold Kainhofer: > > Initially I used \contextModifications {...}, but as Neil points out, all > > parser keywords are supposed to be lowercase, so now

Re: Critical defects and collisions

2010-03-22 Thread Patrick McCarty
On 2010-03-22, Graham Percival wrote: > > Since last month, we have a net gain of 3 Critical issues. This isn't > the right direction for releasing 2.14. > > Defects: > IDStatus Priority Owner Summary > 915 Accepted Critical pnorcks Multi-measure rests dependent ... Unfo

Re: git repository with fixed history ready

2010-03-22 Thread Patrick McCarty
On 2010-03-22, Jan Nieuwenhuizen wrote: > > I've taken another look at fixing lily's history this weekend, > it should be ready now to replace our old broken repository, > have a look at the result > > git clone http://lilypond.org/people/janneke/vc/hysterical-lily.git Wow, this is very awes

Re: Font_metric code cleanup breaks fetaText positioning

2010-03-22 Thread Han-Wen Nienhuys
On Mon, Mar 22, 2010 at 6:02 PM, Neil Puttock wrote: > Your first patch from the set you've pushed breaks the positioning of > fetaText glyphs, since they now all have logical extents in the Y axis > (rather than ink extents). > > I've attached picture with the debug code for checking extents > sw

Re: Font_metric code cleanup breaks fetaText positioning

2010-03-22 Thread Han-Wen Nienhuys
On Mon, Mar 22, 2010 at 6:54 PM, Patrick McCarty wrote: >> > Your first patch from the set you've pushed breaks the positioning of >> > fetaText glyphs, since they now all have logical extents in the Y axis >> > (rather than ink extents). >> >> I have a patch in-progress, so I'll push a fix shortl

Re: Font_metric code cleanup breaks fetaText positioning

2010-03-22 Thread Han-Wen Nienhuys
On Mon, Mar 22, 2010 at 10:39 PM, Han-Wen Nienhuys wrote: >>> > Your first patch from the set you've pushed breaks the positioning of >>> > fetaText glyphs, since they now all have logical extents in the Y axis >>> > (rather than ink extents). >>> >>> I have a patch in-progress, so I'll push a fix

Re: git repository with fixed history ready

2010-03-22 Thread Graham Percival
On Mon, Mar 22, 2010 at 09:18:40AM +0100, Jan Nieuwenhuizen wrote: > There's one small problem with replacing the old repository, > *all* committishes change, and everyone will have to make > a fresh clone, and any work based on the old repository > must be copied over to the new clone using git fo

Re: Font_metric code cleanup breaks fetaText positioning

2010-03-22 Thread Patrick McCarty
On Mon, Mar 22, 2010 at 6:41 PM, Han-Wen Nienhuys wrote: > On Mon, Mar 22, 2010 at 10:39 PM, Han-Wen Nienhuys wrote: >>> >>> Okay, pushed.  Let me know if you find any problems. >> >> doesnt this equally mess up the vertical alignment, this time of normal text? > > More to the point, I'd expect t

Re: git repository with fixed history ready

2010-03-22 Thread Carl Sorensen
On 3/22/10 7:49 PM, "Graham Percival" wrote: > On Mon, Mar 22, 2010 at 09:18:40AM +0100, Jan Nieuwenhuizen wrote: >> There's one small problem with replacing the old repository, >> *all* committishes change, and everyone will have to make >> a fresh clone, and any work based on the old reposit

Re: Font_metric code cleanup breaks fetaText positioning

2010-03-22 Thread Han-Wen Nienhuys
On Mon, Mar 22, 2010 at 11:02 PM, Patrick McCarty wrote: > On Mon, Mar 22, 2010 at 6:41 PM, Han-Wen Nienhuys wrote: >> On Mon, Mar 22, 2010 at 10:39 PM, Han-Wen Nienhuys wrote: Okay, pushed.  Let me know if you find any problems. >>> >>> doesnt this equally mess up the vertical alignme

Re: Font_metric code cleanup breaks fetaText positioning

2010-03-22 Thread Patrick McCarty
On 2010-03-22, Han-Wen Nienhuys wrote: > On Mon, Mar 22, 2010 at 11:02 PM, Patrick McCarty > wrote: > > > > Previous to your changes, IIRC, text_stencil() was never called. > > Are you sure? > > SCM > Text_interface::interpret_string (SCM layout_smob, > SCM prop