Re: Fix #887: Use ly:string-percent-encode for textedit URIs. (issue193077)

2010-01-28 Thread pnorcks
Reviewers: lemzwerg, dak, Message: On 2010/01/25 09:28:36, dak wrote: http://codereview.appspot.com/193077/diff/1001/12 File lily/general-scheme.cc (right): http://codereview.appspot.com/193077/diff/1001/12#newcode230 lily/general-scheme.cc:230: return ((c >= 0x2D && c <= 0x2F) // hyphen, f

Re: Latest git (lilypond-translation) build fail

2010-01-28 Thread John Mandereau
Le jeudi 28 janvier 2010 à 00:07 +, Graham Percival a écrit : > On Wed, Jan 27, 2010 at 10:33:45PM +0100, Harmath Dénes wrote: > > make PACKAGE=LILYPOND package=lilypond -C ly-examples all && make > > PACKAGE=LILYPOND package=lilypond -C server all && true > > true > > make: *** server: No s

Re: [PATCH]: New G clef

2010-01-28 Thread Marc Hohl
Carl Sorensen schrieb: On 1/23/10 3:19 AM, "Marc Hohl" wrote: Carl Sorensen schrieb: Marc Hohl has worked on a new G clef that is rotated about 1.5 degrees clockwise to improve its balance, as suggested by Jan (see

Re: [PATCH]: New G clef

2010-01-28 Thread Marc Hohl
Carl Sorensen schrieb: On 1/23/10 3:19 AM, "Marc Hohl" wrote: Carl Sorensen schrieb: Marc Hohl has worked on a new G clef that is rotated about 1.5 degrees clockwise to improve its balance, as suggested by Jan (see

Re: Latest git (lilypond-translation) build fail

2010-01-28 Thread Harmath Dénes
On 2010.01.28., at 9:21, John Mandereau wrote: > Le jeudi 28 janvier 2010 à 00:07 +, Graham Percival a écrit : >> On Wed, Jan 27, 2010 at 10:33:45PM +0100, Harmath Dénes wrote: >>> make PACKAGE=LILYPOND package=lilypond -C ly-examples all && make >>> PACKAGE=LILYPOND package=lilypond -C ser

Re: Latest git (lilypond-translation) build fail

2010-01-28 Thread John Mandereau
2010/1/28 Harmath Dénes : > Yes, I'm building outside the source tree. > I ran ./configure in the source tree, and it didn't help. What are the exact > commands? Oops, you should have run the script configure of the source top directory with the *build directory* as current directory. Now you di

Re: Latest git (lilypond-translation) build fail

2010-01-28 Thread Harmath Dénes
Yes, these commands helped. Thanks! Unfortunately the CG still contains outdated information about this. It should mention that ./autogen.sh should be run with --noconfigure, and the --srcdir argument is superfluous. Best, Dénes On 2010.01.28., at 11:21, John Mandereau wrote: > 2010/1/28 Harma

Re: How to do this correctly?

2010-01-28 Thread David Kastrup
Neil Puttock writes: > 2010/1/27 Carl Sorensen : > >> I don't think there is a way to do this better as the code sits now.  The >> accidentals in the ambitus are AmbitusAccidentals, and are create by the >> Ambitus_engraver, so the standard accidental styles (which might do what you >> want) don'

Re: How to do this correctly?

2010-01-28 Thread Carl Sorensen
On 1/28/10 6:25 AM, "David Kastrup" wrote: > Neil Puttock writes: > >> 2010/1/27 Carl Sorensen : >> >>> I don't think there is a way to do this better as the code sits now.  The >>> accidentals in the ambitus are AmbitusAccidentals, and are create by the >>> Ambitus_engraver, so the standar

Re: How to do this correctly?

2010-01-28 Thread David Kastrup
Carl Sorensen writes: > On 1/28/10 6:25 AM, "David Kastrup" wrote: > >> Neil Puttock writes: >> >>> 2010/1/27 Carl Sorensen : >>> I don't think there is a way to do this better as the code sits now.  The accidentals in the ambitus are AmbitusAccidentals, and are create by the A

Re: Latest git (lilypond-translation) build fail

2010-01-28 Thread John Mandereau
Le jeudi 28 janvier 2010 à 12:27 +0100, Harmath Dénes a écrit : > Yes, these commands helped. Thanks! > Unfortunately the CG still contains outdated information about this. > It should mention that ./autogen.sh should be run with --noconfigure, > and the --srcdir argument is superfluous. A patch

Re: [PATCH]: New G clef

2010-01-28 Thread Patrick McCarty
On 2010-01-28, Marc Hohl wrote: > > One question to the developers: > > This patch concerns the metafont sources, so a simple > > make all > > won't do the job. > > If I do > > make clean > make all > > then the whole buch is recompiled. > > Is it ok to do just > > cd mf/ > make clean > cd

Re: [PATCH]: New G clef

2010-01-28 Thread Mats Bengtsson
Marc Hohl wrote: Is it ok to do just cd mf/ make clean cd .. make all since this is faster? Sure! You may save some typing by doing make -C mf clean make /Mats ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mail

Scheme Engraver - Removing Engravers

2010-01-28 Thread Eric Knapp
Hi, everyone. I'm learning Scheme and how to write scheme engravers. Is it possible to remove other engravers within a scheme engraver? Here's a snippet from the Notation manual: \new Staff { \new Voice \with { \remove "New_fingering_engraver" } \relative c'' { % notation ref } I would l

Re: How to do this correctly?

2010-01-28 Thread Carl Sorensen
On 1/28/10 7:25 AM, "David Kastrup" wrote: > Carl Sorensen writes: > >> On 1/28/10 6:25 AM, "David Kastrup" wrote: >> >>> Neil Puttock writes: >>> 2010/1/27 Carl Sorensen : > I don't think there is a way to do this better as the code sits now.  The > accidentals in the

Re: Scheme Engraver - Removing Engravers

2010-01-28 Thread Han-Wen Nienhuys
On Thu, Jan 28, 2010 at 8:53 AM, Eric Knapp wrote: > Hi, everyone. > > I'm learning Scheme and how to write scheme engravers. Is it possible > to remove other engravers within a scheme engraver? Here's a snippet > from the Notation manual: > > \new Staff { \new Voice \with { >    \remove "New_fing

Re: Scheme Engraver - Removing Engravers

2010-01-28 Thread Carl Sorensen
On 1/28/10 9:53 AM, "Eric Knapp" wrote: > Hi, everyone. > > I'm learning Scheme and how to write scheme engravers. Is it possible > to remove other engravers within a scheme engraver? Here's a snippet > from the Notation manual: > > \new Staff { \new Voice \with { > \remove "New_fingerin

Re: How to do this correctly?

2010-01-28 Thread David Kastrup
Carl Sorensen writes: > On 1/28/10 7:25 AM, "David Kastrup" wrote: >> And semi-visual composition is less of a pain in Scheme than in C++. > > The semi-visual composition is done in the output end, not in the > engraver. Ah right. I forgot that the "engraver" just does the job preparation and

Re: How to do this correctly?

2010-01-28 Thread David Kastrup
Carl Sorensen writes: > On 1/28/10 7:25 AM, "David Kastrup" wrote: > >> Anyway, I think that likely the ambitus engraver would be a good >> candidate for reimplementing as a Scheme engraver. It would appear >> reasonably straightforward but not trivially so, and it is one of those >> things whe

Re: How to do this correctly?

2010-01-28 Thread Kieren MacMillan
Hi all, > Two possibilities: > Side by side (works also for ottavation) This is the traditional way (q.v., instrument ranges in orchestration texts). For what it's worth... Kieren. ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.g

Re: How to do this correctly?

2010-01-28 Thread Carl Sorensen
On 1/28/10 12:49 PM, "David Kastrup" wrote: > Carl Sorensen writes: > >> On 1/28/10 7:25 AM, "David Kastrup" wrote: >> >>> Anyway, I think that likely the ambitus engraver would be a good >>> candidate for reimplementing as a Scheme engraver. It would appear >>> reasonably straightforward

[PATCH] GUB: Bump fontconfig to latest stable release.

2010-01-28 Thread Patrick McCarty
Hi, I believe 2.8.0 has a fix for font-cache corruption that was introduced in 2.7.3, so here's patch to bump the version. Thanks, Patrick From 73e8789534fcea0f192762c80ac230fa24020d96 Mon Sep 17 00:00:00 2001 From: Patrick McCarty Date: Thu, 28 Jan 2010 12:18:33 -0800 Subject: [PATCH] Bump font

Re: Scheme Engraver - Removing Engravers

2010-01-28 Thread Carl Sorensen
On 1/28/10 11:46 AM, "Eric Knapp" wrote: > Thanks, I guess the answer is that I should also write a context that > removes the engravers I want removed and then uses my new custom > engraver. I'll look into that, too. > Two points. First, policy is that we don't top post on this list. You'

Re: [PATCH] GUB: Bump fontconfig to latest stable release.

2010-01-28 Thread Graham Percival
On Thu, Jan 28, 2010 at 8:27 PM, Patrick McCarty wrote: > I believe 2.8.0 has a fix for font-cache corruption that was > introduced in 2.7.3, so here's patch to bump the version. Go ahead and test: http://lilypond.org/~graham/ Cheers, - Graham ___ li

Re: [PATCH] GUB: Bump fontconfig to latest stable release.

2010-01-28 Thread Patrick McCarty
On Thu, Jan 28, 2010 at 2:22 PM, Graham Percival wrote: > On Thu, Jan 28, 2010 at 8:27 PM, Patrick McCarty wrote: >> I believe 2.8.0 has a fix for font-cache corruption that was >> introduced in 2.7.3, so here's patch to bump the version. > > Go ahead and test: > http://lilypond.org/~graham/ Loo

Re: [PATCH] GUB: Bump fontconfig to latest stable release.

2010-01-28 Thread Graham Percival
On Thu, Jan 28, 2010 at 02:51:49PM -0800, Patrick McCarty wrote: > On Thu, Jan 28, 2010 at 2:22 PM, Graham Percival > wrote: > > Go ahead and test: > > http://lilypond.org/~graham/ > > Is this based on latest master, or the merge commit before that? Hmm... I just did "make lilypond", which I bel

Re: [PATCH] GUB: Bump fontconfig to latest stable release.

2010-01-28 Thread Patrick McCarty
On Thu, Jan 28, 2010 at 3:01 PM, Graham Percival wrote: > On Thu, Jan 28, 2010 at 02:51:49PM -0800, Patrick McCarty wrote: >> On Thu, Jan 28, 2010 at 2:22 PM, Graham Percival >> wrote: >> > Go ahead and test: >> > http://lilypond.org/~graham/ >> >> Is this based on latest master, or the merge com

Re: [PATCH] GUB: Bump fontconfig to latest stable release.

2010-01-28 Thread Patrick McCarty
On Thu, Jan 28, 2010 at 3:01 PM, Graham Percival wrote: > On Thu, Jan 28, 2010 at 02:51:49PM -0800, Patrick McCarty wrote: >> On Thu, Jan 28, 2010 at 2:22 PM, Graham Percival >> wrote: >> > Go ahead and test: >> > http://lilypond.org/~graham/ >> >> Is this based on latest master, or the merge com

Re: How to do this correctly?

2010-01-28 Thread Han-Wen Nienhuys
On Thu, Jan 28, 2010 at 11:49 AM, David Kastrup wrote: > Carl Sorensen writes: > >> On 1/28/10 7:25 AM, "David Kastrup" wrote: >> >>> Anyway, I think that likely the ambitus engraver would be a good >>> candidate for reimplementing as a Scheme engraver.  It would appear >>> reasonably straightfo

Re: How to do this correctly?

2010-01-28 Thread Carl Sorensen
On 1/28/10 9:22 PM, "Han-Wen Nienhuys" wrote: > On Thu, Jan 28, 2010 at 11:49 AM, David Kastrup wrote: >> Carl Sorensen writes: >> >>> On 1/28/10 7:25 AM, "David Kastrup" wrote: >>> Anyway, I think that likely the ambitus engraver would be a good candidate for reimplementing as

Re: Make tab-note-heads and fretboards use common code. (issue186268)

2010-01-28 Thread Carl . D . Sorensen
The patch set now seems to be complete. I've responded to Neil's comments, and regression tests all pass. Please review. Thanks, Carl http://codereview.appspot.com/186268/show ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.g

Re: How to do this correctly?

2010-01-28 Thread David Pounder
> > Using a (let ((var1 val1) (var2 val2)) (list ... > > around the whole engraver works to allow all members to access and modify > private variables. Other engravers have no access to them though. > > David. Now that I think about it, I'm not sure if it will work if there is more than one