Re: Some fixes to musicxml2ly

2006-09-16 Thread Tuukka Verho
On Fri, 2006-09-15 at 22:11 +0300, Tuukka Verho wrote: > The attached diff for musicxml.py now has an explanatory comment. Oops, sent a diff without the comment. Here comes the correnct version. Tuukka --- lilypond/python/musicxml.py 2006-08-26 01:04:08.0 +0300 +++ musicxml.py 2006-09-16

Re: Some fixes to musicxml2ly

2006-09-16 Thread Karl Hammar
[EMAIL PROTECTED]: > On Fri, 2006-09-15 at 19:33 +0200, Han-Wen Nienhuys wrote: > > > > > else: > > > - return 0 > > > + tolerance_exp = -4 # means that notes that are 1/32 or less > > > shorter > > > than 1/4 are quarter notes etc. > > > + return int (math

[patch] export functions from layout-page-layout.scm

2006-09-16 Thread Nicolas Sceaux
Hi, The attached patch exports some of the utility function names in scm/layout-page-layout.scm, so that they should be called by user defined page breaking functions. Make web runs fine, and the page breaking regression tests seem to look as expected. May I commit? nicolas Index: ChangeLog ===

Re: [patch] export functions from layout-page-layout.scm

2006-09-16 Thread Han-Wen Nienhuys
Nicolas Sceaux wrote: Hi, The attached patch exports some of the utility function names in scm/layout-page-layout.scm, so that they should be called by user defined page breaking functions. Make web runs fine, and the page breaking regression tests seem to look as expected. May I commit? plea

Re: [patch] export functions from layout-page-layout.scm

2006-09-16 Thread Han-Wen Nienhuys
Nicolas Sceaux wrote: Hi, The attached patch exports some of the utility function names in scm/layout-page-layout.scm, so that they should be called by user defined page breaking functions. Make web runs fine, and the page breaking regression tests seem to look as expected. May I commit? plea

The life of a Grob

2006-09-16 Thread Joe Neeman
Understanding the LilyPond source often boils down to figuring out what is happening to the Grobs. Where (and why) are they being created, modified and destroyed? I've spent many hours tracing Lily through a debugger and it is mind-blowingly tedious. So I quickly hacked a few things together and c

Re: The life of a Grob

2006-09-16 Thread Han-Wen Nienhuys
Joe Neeman wrote: Understanding the LilyPond source often boils down to figuring out what is happening to the Grobs. Where (and why) are they being created, modified and destroyed? I've spent many hours tracing Lily through a debugger and it is mind-blowingly tedious. So I quickly hacked a few t

Re: The life of a Grob

2006-09-16 Thread Werner LEMBERG
> The file test.ly produces a > graphviz output file, "graph.dot", that lets you visualise the changes > in Grobs throughout LilyPond execution. For now, you'll need to add a > closing brace to the end of graph.dot. Very nice! A minor suggestion: Please add a counter to the boxes so that they ar

Re: The life of a Grob

2006-09-16 Thread Joe Neeman
On Sat, 2006-09-16 at 16:29 +0200, Han-Wen Nienhuys wrote: > Some comments: > > * can you add another macro layer, so __LINE__ and __FILE__ aren't > sprinkled around in the code? For good measure, you could also add > __FUNCTION__ . How about something like the attached patch? I "overload" get_p

Re: The life of a Grob

2006-09-16 Thread Joe Neeman
On Sat, 2006-09-16 at 20:47 +0200, Werner LEMBERG wrote: > > The file test.ly produces a > > graphviz output file, "graph.dot", that lets you visualise the changes > > in Grobs throughout LilyPond execution. For now, you'll need to add a > > closing brace to the end of graph.dot. > > Very nice! A

Re: The life of a Grob

2006-09-16 Thread Han-Wen Nienhuys
Joe Neeman wrote: On Sat, 2006-09-16 at 16:29 +0200, Han-Wen Nienhuys wrote: Some comments: * can you add another macro layer, so __LINE__ and __FILE__ aren't sprinkled around in the code? For good measure, you could also add __FUNCTION__ . How about something like the attached patch? I "ove

Re: The life of a Grob

2006-09-16 Thread Joe Neeman
On Sun, 2006-09-17 at 01:20 +0200, Han-Wen Nienhuys wrote: > Joe Neeman wrote: > > On Sat, 2006-09-16 at 16:29 +0200, Han-Wen Nienhuys wrote: > >> Some comments: > >> > >> * can you add another macro layer, so __LINE__ and __FILE__ aren't > >> sprinkled around in the code? For good measure, you co

Re: The life of a Grob

2006-09-16 Thread Werner LEMBERG
> > Very nice! A minor suggestion: Please add a counter to the boxes so > > that they are enumerated. Then the start of an arrow should be > > labeled with the number of the target box, and the end of an arrow > > should tagged with the number of the origin box. > > I don't suppose you'd know ho

page breaking and vector_sort cleanups

2006-09-16 Thread Joe Neeman
This patch STL-ifies vector_sort much like my previous patch for binary_search. It also includes my patch for rewriting the interpretation step for page turns. These changes touch a lot of files, so I'd like to get them committed before I mess up my working tree with grob graphing stuff. 2006-09-