Re: Remove trailing whitespace {python,scm,lily,scripts}. (issue 547810043 by hanw...@gmail.com)

commit 2ddc627c3c3e0299c4dc0ba109340cff54c49710 Author: Han-Wen Nienhuys Date: Sat Mar 21 13:13:32 2020 +0100 Remove trailing whitespace in {python,scripts,*make*}. https://codereview.appspot.com/547810043/

Re: Remove trailing whitespace {python,scm,lily,scripts}. (issue 547810043 by hanw...@gmail.com)

On 2020/03/21 19:18:26, hanwenn wrote: > On Sat, Mar 21, 2020 at 8:10 PM wrote: > > > > On 2020/03/21 19:09:01, hanwenn wrote: > > > You suggested it yourself? I removed the lily/ and scm/ changes to > > > avoid conflicts. > > > > huh!? "maybe we can combine this w

Re: Remove trailing whitespace {python,scm,lily,scripts}. (issue 547810043 by hanw...@gmail.com)

On Sat, Mar 21, 2020 at 8:10 PM wrote: > > On 2020/03/21 19:09:01, hanwenn wrote: > > You suggested it yourself? I removed the lily/ and scm/ changes to > > avoid conflicts. > > huh!? "maybe we can combine this with running fixcc.py?" doesn't sound > like "please push immediately"! "After a messa

Re: Remove trailing whitespace {python,scm,lily,scripts}. (issue 547810043 by hanw...@gmail.com)

On 2020/03/21 19:09:01, hanwenn wrote: > You suggested it yourself? I removed the lily/ and scm/ changes to > avoid conflicts. huh!? "maybe we can combine this with running fixcc.py?" doesn't sound like "please push immediately"! https://codereview.appspot.com/547810043/

Re: Remove trailing whitespace {python,scm,lily,scripts}. (issue 547810043 by hanw...@gmail.com)

You suggested it yourself? I removed the lily/ and scm/ changes to avoid conflicts. On Sat, Mar 21, 2020 at 7:38 PM wrote: > > On 2020/03/21 18:20:09, hanwenn wrote: > > As discussed, will push this without countdown. > > Discussed where? David proposed on lilypond-devel to run fixcc.py > tomorro

Re: Remove trailing whitespace {python,scm,lily,scripts}. (issue 547810043 by hanw...@gmail.com)

On 2020/03/21 18:20:09, hanwenn wrote: > As discussed, will push this without countdown. Discussed where? David proposed on lilypond-devel to run fixcc.py tomorrow, but I see no reference to this patch. https://codereview.appspot.com/547810043/

Re: Remove trailing whitespace {python,scm,lily,scripts}. (issue 547810043 by hanw...@gmail.com)

As discussed, will push this without countdown. On Sat, Mar 21, 2020 at 3:36 PM wrote: > > On 2020/03/21 13:14:50, hahnjo wrote: > > Sending to lilypond-devel for broader notice. This is likely to give > conflicts, > > maybe we can combine this with running fixcc.py? > > I've backed out scm and l

Re: Remove trailing whitespace {python,scm,lily,scripts}. (issue 547810043 by hanw...@gmail.com)

On 2020/03/21 13:14:50, hahnjo wrote: > Sending to lilypond-devel for broader notice. This is likely to give conflicts, > maybe we can combine this with running fixcc.py? I've backed out scm and lily so it won't give conflicts with fixcc and fixscm. https://codereview.appspot.com/547810043/

Re: Remove trailing whitespace {python,scm,lily,scripts}. (issue 547810043 by hanw...@gmail.com)

nk it would take care of > trailing spaces in the C++ files. And the ones in the scm files should likely be combined with running fixscm.sh . I think that one warranted changing some block comments not in Emacs convention, so I hadn't done it on stable yet. https://codereview.appspot.com/547810043/

Re: Remove trailing whitespace {python,scm,lily,scripts}. (issue 547810043 by hanw...@gmail.com)

On 2020/03/21 13:14:50, hahnjo wrote: > Sending to lilypond-devel for broader notice. This is likely to give conflicts, > maybe we can combine this with running fixcc.py? Ah right, that one was still pending anyway. I think it would take care of trailing spaces in the C++ files.

Re: Remove trailing whitespace {python,scm,lily,scripts}. (issue 547810043 by hanw...@gmail.com)

Sending to lilypond-devel for broader notice. This is likely to give conflicts, maybe we can combine this with running fixcc.py? https://codereview.appspot.com/547810043/

Re: Allow all papersizes to be specified with a trailing "papersize" or "landscape" string. (issue 6461071)

LGTM http://codereview.appspot.com/6461071/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Allow all papersizes to be specified with a trailing "papersize" or "landscape" string. (issue 6461071)

Not tested, either, but LGTM from reading the patch. http://codereview.appspot.com/6461071/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Allow all papersizes to be specified with a trailing "papersize" or "landscape" string. (issue 6461071)

Not tested, but eyeballing LGTM http://codereview.appspot.com/6461071/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: lilypond-book: Remove trailing path separators in include paths. (issue 6342048)

LGTM http://codereview.appspot.com/6342048/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

lilypond-book: Remove trailing path separators in include paths. (issue 6342048)

LGTM I made these changes in lilypond-book.py in the 2.15.40 binary (different line numbers, but lines the same) and I can confirm they fix the problem on Windows. Thanks Julien! Trevor http://codereview.appspot.com/6342048/ ___ lilypond-devel mail

Removing trailing whitespace [was Re: [frogs] Patch for Issue #830]

e ^. Sorry. I also learned something. Using --whitespace=warn does nothing, because apply is not invoked, but --whitespace=fix forces a rebase, and hence apply is invoked. So how does this sound: To remove trailing whitespace during git am use git am --whitespace=fix ... To remove trailing whit

Re: trailing `\'

> You probably > want to do something like > > test = { > \property Foo > \property Bar > } Thanks. > This will hopefully also answer your earlier question regarding > dynamics for piano. Unfortunately not. I tried any combination with and without braces, using \notes, \score e

Re: trailing `\'

> Werner LEMBERG <[EMAIL PROTECTED]> writes: > > > Any reason why I can't continue a macro definition with a trailing > > `\'? > > > Example: > > > > test = \property Foo \ > > \property Bar > > We don

Re: trailing `\'

Werner LEMBERG <[EMAIL PROTECTED]> writes: > Any reason why I can't continue a macro definition with a trailing > `\'? > Example: > > test = \property Foo \ > \property Bar We don't have macros, only variables. Whitespace is ign

trailing `\'

Any reason why I can't continue a macro definition with a trailing `\'? Example: test = \property Foo \ \property Bar Werner ___ Lilypond-devel mailing list [EMAIL PROTECTED] http://mail.gnu.org/mailman/listinf