Re: [frogs] Re: tablature: ties and harmonics (issue1669041)

2010-06-30 Thread Marc Hohl
n.putt...@gmail.com schrieb: On 2010/06/30 07:48:12, marc wrote: So I tried to extend the parenthesize-stencil function in scm/stencil.scm. It compiles without error, but the regression file is cluttered up. I can't test this. Would you mind uploading another version here which includes al

Re: [frogs] Re: tablature: ties and harmonics (issue1669041)

2010-06-30 Thread Marc Hohl
Carl Sorensen schrieb: On 6/30/10 1:48 AM, "Marc Hohl" wrote: Carl Sorensen schrieb: [...] http://codereview.appspot.com/1669041/diff/26001/27004#newcode130 scm/define-grob-properties.scm:130: (bracket-width ,number? "Width of the harmonic angle bracket.") Why do we need brac

Re: tablature: ties and harmonics (issue1669041)

2010-06-30 Thread n . puttock
On 2010/06/30 07:48:12, marc wrote: So I tried to extend the parenthesize-stencil function in scm/stencil.scm. It compiles without error, but the regression file is cluttered up. I can't test this. Would you mind uploading another version here which includes all the changes since the first

Re: [frogs] Re: tablature: ties and harmonics (issue1669041)

2010-06-30 Thread Carl Sorensen
On 6/30/10 1:48 AM, "Marc Hohl" wrote: > Carl Sorensen schrieb: >> [...] http://codereview.appspot.com/1669041/diff/26001/27004#newcode130 scm/define-grob-properties.scm:130: (bracket-width ,number? "Width of the harmonic angle bracket.") Why do we need bracket-width? Why

Re: [frogs] Re: tablature: ties and harmonics (issue1669041)

2010-06-30 Thread Marc Hohl
Carl Sorensen schrieb: [...] http://codereview.appspot.com/1669041/diff/26001/27004#newcode130 scm/define-grob-properties.scm:130: (bracket-width ,number? "Width of the harmonic angle bracket.") Why do we need bracket-width? Why can't we just use the pre-existing width property? Hm, Nei

Re: [frogs] Re: tablature: ties and harmonics (issue1669041)

2010-06-27 Thread Carl Sorensen
On 6/27/10 3:19 AM, "Marc Hohl" wrote: > carl.d.soren...@gmail.com schrieb: >> http://codereview.appspot.com/1669041/diff/26001/27003 >> File scm/define-grob-interfaces.scm (right): >> >> http://codereview.appspot.com/1669041/diff/26001/27003#newcode91 >> scm/define-grob-interfaces.scm:91: 'harm

Re: [frogs] Re: tablature: ties and harmonics (issue1669041)

2010-06-27 Thread Marc Hohl
carl.d.soren...@gmail.com schrieb: Looks pretty good. I have a few comments about things that seem to be unnecessarily specific to harmonics. Thanks, Carl http://codereview.appspot.com/1669041/diff/26001/27003 File scm/define-grob-interfaces.scm (right): http://codereview.appspot.com/16690

Re: tablature: ties and harmonics (issue1669041)

2010-06-23 Thread Carl . D . Sorensen
Looks pretty good. I have a few comments about things that seem to be unnecessarily specific to harmonics. Thanks, Carl http://codereview.appspot.com/1669041/diff/26001/27003 File scm/define-grob-interfaces.scm (right): http://codereview.appspot.com/1669041/diff/26001/27003#newcode91 scm/de

Re: [frogs] Re: tablature: ties and harmonics (issue1669041)

2010-06-22 Thread Marc Hohl
n.putt...@gmail.com schrieb: On 2010/06/21 19:06:52, marc wrote: Now I *must* overlook the obvious, because the fret numbers still disappear, even if they are not tied together. Remember what I said about 'layer? Yes, of course, but since the HarmonicParenthesesItem *did* work before witho

Re: tablature: ties and harmonics (issue1669041)

2010-06-22 Thread n . puttock
On 2010/06/21 19:06:52, marc wrote: Now I *must* overlook the obvious, because the fret numbers still disappear, even if they are not tied together. Remember what I said about 'layer? Both TabNoteHead and HarmonicParenthesesItem have the same default layer (1), but the latter is likely to b