On 10/06/11 09:30, lemniskata.bernoull...@gmail.com wrote:
> Ian,
>
> thanks for review!
> http://codereview.appspot.com/4410049/diff/16001/lily/stem.cc#newcode792
> lily/stem.cc:792:
> On 2011/06/09 04:55:10, Ian Hulin (gmail) wrote:
>> /*
>> Look up the font character allowing for the varian
On 2011/06/09 08:12:53, MikeSol wrote:
Hey Janek,
All the metafont stuff looks good! Last time we touched base, I
recall that we
had talked about looking into embedding a lot of this info into the
font - did
that prove to be not doable? Other than that, I have one comment
below about
t
Ian,
thanks for review!
http://codereview.appspot.com/4410049/diff/16001/input/regression/shortened-flags-cues.ly
File input/regression/shortened-flags-cues.ly (right):
http://codereview.appspot.com/4410049/diff/16001/input/regression/shortened-flags-cues.ly#newcode6
input/regression/shortened
http://codereview.appspot.com/4410049/diff/16001/lily/stem.cc
File lily/stem.cc (right):
http://codereview.appspot.com/4410049/diff/16001/lily/stem.cc#newcode612
lily/stem.cc:612:
On 2011/06/09 08:12:54, MikeSol wrote:
I remember we worked on a Scheme version of this a while back
Code for fla
Hey Janek,
All the metafont stuff looks good! Last time we touched base, I recall
that we had talked about looking into embedding a lot of this info into
the font - did that prove to be not doable? Other than that, I have one
comment below about the C++ stuff.
Cheers,
Mike
http://codereview.
Spelling commenting and formatting changes only.
Cheers,
Ian
http://codereview.appspot.com/4410049/diff/16001/input/regression/shortened-flags-cues.ly
File input/regression/shortened-flags-cues.ly (right):
http://codereview.appspot.com/4410049/diff/16001/input/regression/shortened-flags-cues.ly
Hi,
2011/4/17 :
> Please add a stemful regtest with several overrides just to make sure
> that this works completely.
Added.
2011/4/18 Han-Wen Nienhuys :
> You are initializing this list just once, while in principle it can
> have different values for every loaded font. Even if it may work, it
On Mon, Apr 18, 2011 at 11:16 AM, Han-Wen Nienhuys wrote:
>> }
>> uses (i think) two different design sizes (one for cues, one for normal
>> notes) and yet everything is fine - change from regular flags to
>> shortened flags take place on note d both in cues and normal notes.
>> Also when i compi
On Mon, Apr 18, 2011 at 5:02 AM, wrote:
> \relative c'' {
> \new CueVoice {
> \voiceOne \autoBeamOff
> a8 b c d e f g a
> a,16 b c d e f g a
> }
>
> \new Voice {
> \voiceOne \autoBeamOff
> a,16
http://codereview.appspot.com/4410049/diff/1/lily/stem.cc
File lily/stem.cc (right):
http://codereview.appspot.com/4410049/diff/1/lily/stem.cc#newcode619
lily/stem.cc:619: static vector available_flag_lengths[2][5];
On 2011/04/18 03:42:53, hanwenn wrote:
You cannot do this.
This will screw u
http://codereview.appspot.com/4410049/diff/1/lily/stem.cc
File lily/stem.cc (right):
http://codereview.appspot.com/4410049/diff/1/lily/stem.cc#newcode619
lily/stem.cc:619: static vector available_flag_lengths[2][5];
You cannot do this.
This will screw up if two .ly files use fonts of different
Please add a stemful regtest with several overrides just to make sure
that this works completely.
http://codereview.appspot.com/4410049/diff/1/lily/stem.cc
File lily/stem.cc (right):
http://codereview.appspot.com/4410049/diff/1/lily/stem.cc#newcode620
lily/stem.cc:620:
It seems like this new st
Reviewers: ,
Message:
Passes regtests (i see a regression in partcombine-midi.ly, however from
Graham's message about midi regtests
http://lists.gnu.org/archive/html/lilypond-devel/2011-04/msg00283.html i
understand that it's not my fault).
If i understand correctly, the default way of calculati
13 matches
Mail list logo
